Skip to content

fix(firestore-send-email) restore headers support #2440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: next
Choose a base branch
from

Conversation

Nushio
Copy link

@Nushio Nushio commented May 27, 2025

I just noticed that this feature was removed, and wanted to contribute a quick fix.

Copy link

google-cla bot commented May 27, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Nushio
Copy link
Author

Nushio commented May 27, 2025

I've signed the CLA

Screenshot 2025-05-27 at 5 01 27 PM

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR restores support for custom email headers in the Firestore email sending extension by reintroducing the missing headers field and updating documentation accordingly.

  • Restores the headers property in the mail options in index.ts.
  • Bumps the extension version to 0.2.4 in extension.yaml.
  • Updates documentation and changelog to reflect this new feature.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
firestore-send-email/functions/src/index.ts Adds the headers field to email payload to support custom headers.
firestore-send-email/extension.yaml Updates the extension version.
firestore-send-email/README.md Adds a section on using custom headers with example JSON.
firestore-send-email/CHANGELOG.md Documents the addition of the headers field and updates the version.

@cabljac
Copy link
Contributor

cabljac commented May 30, 2025

Hi, can you run npm run generate-readme in the firestore-send-email/functions directory

@Nushio
Copy link
Author

Nushio commented May 30, 2025

I ran it but it removes the blurb I wrote about using Custom Headers.

Where should I place that instead? PREINSTALL.md ?

Edit: Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants