Fix Rubocop issues and config descriptions.

.rubocop.yml

@@ -1,4 +1,6 @@
 ---
+require:
+- rubocop/require_tools
 Style/MultipleComparison:
   Enabled: false
 Style/PercentLiteralDelimiters:
@@ -152,9 +154,6 @@ Style/IfInsideElse:
   Enabled: false
 Style/CollectionMethods:
   Enabled: false
-CrossPlatform/ForkUsage:
-  Exclude:
-  - "**/plugins/template/**/*"
 Style/MethodCallWithArgsParentheses:
   Enabled: true
   IgnoredMethods:

lib/fastlane/plugin/firebase_app_distribution/actions/firebase_app_distribution_action.rb

@@ -1,8 +1,9 @@
 require 'fastlane/action'
+require 'fastlane_core'
 require 'open3'
 require 'shellwords'
 require 'googleauth'
-require 'google/apis/firebaseappdistribution_v1'
+require_relative '../helper/firebase_app_distribution_apis'
 require_relative '../helper/firebase_app_distribution_helper'
 require_relative '../helper/firebase_app_distribution_error_message'
 require_relative '../helper/firebase_app_distribution_auth_client'
@@ -158,7 +159,9 @@ def self.xcode_archive_path
         # the same lane
         return nil if lane_platform == :android
 
+        # rubocop:disable Require/MissingRequireStatement
         Actions.lane_context[SharedValues::XCODEBUILD_ARCHIVE]
+        # rubocop:enable Require/MissingRequireStatement
       end
 
       def self.lane_platform
@@ -174,6 +177,7 @@ def self.platform_from_app_id(app_id)
         end
       end
 
+      # rubocop:disable Require/MissingRequireStatement
       def self.get_binary_path(platform, params)
         if platform == :ios
           return params[:ipa_path] ||
@@ -198,6 +202,7 @@ def self.get_binary_path(platform, params)
         UI.error("Unable to determine binary path for unsupported platform #{platform}.")
         nil
       end
+      # rubocop:enable Require/MissingRequireStatement
 
       def self.get_upload_timeout(params)
         if params[:upload_timeout]
@@ -236,7 +241,9 @@ def self.aab_info_name(app_name)
       def self.release_notes(params)
         release_notes_param =
           get_value_from_value_or_file(params[:release_notes], params[:release_notes_file])
+        # rubocop:disable Require/MissingRequireStatement
         release_notes_param || Actions.lane_context[SharedValues::FL_CHANGELOG]
+        # rubocop:enable Require/MissingRequireStatement
       end
 
       def self.poll_upload_release_operation(client, operation, binary_type)
@@ -506,7 +513,7 @@ def self.available_options
                                        type: String),
           FastlaneCore::ConfigItem.new(key: :groups_file,
                                        env_name: "FIREBASEAPPDISTRO_GROUPS_FILE",
-                                       description: "Path to file containing group aliases used for distribution, separated by commas",
+                                       description: "Path to file containing group aliases used for distribution, separated by commas or newlines",
                                        optional: true,
                                        type: String),
           FastlaneCore::ConfigItem.new(key: :testers,
@@ -516,7 +523,7 @@ def self.available_options
                                        type: String),
           FastlaneCore::ConfigItem.new(key: :testers_file,
                                        env_name: "FIREBASEAPPDISTRO_TESTERS_FILE",
-                                       description: "Path to file containing email addresses of testers, separated by commas",
+                                       description: "Path to file containing email addresses of testers, separated by commas or newlines",
                                        optional: true,
                                        type: String),
           FastlaneCore::ConfigItem.new(key: :release_notes,
@@ -533,12 +540,13 @@ def self.available_options
           # Release Testing
           FastlaneCore::ConfigItem.new(key: :test_devices,
                                        env_name: "FIREBASEAPPDISTRO_TEST_DEVICES",
-                                       description: "List of devices to run automated tests on, in the format 'model=<model-id>,version=<os-version-id>,locale=<locale>,orientation=<orientation>;model=<model-id>,...'. Run 'gcloud firebase test android|ios models list' to see available devices. Note: This feature is in beta",
+                                       description: "List of devices (separated by semicolons) to run automated tests on, in the format 'model=<model-id>,version=<os-version-id>,locale=<locale>,orientation=<orientation>;model=<model-id>,...'. Run 'gcloud firebase test android|ios models list' to see available devices. Note: This feature is in beta",
                                        optional: true,
                                        type: String),
           FastlaneCore::ConfigItem.new(key: :test_devices_file,
                                        env_name: "FIREBASEAPPDISTRO_TEST_DEVICES_FILE",
-                                       description: "Path to file containing a list of devices to run automated tests on, in the format 'model=<model-id>,version=<os-version-id>,locale=<locale>,orientation=<orientation>;model=<model-id>,...'. Run 'gcloud firebase test android|ios models list' to see available devices. Note: This feature is in beta",
+                                       description: "Path to file containing a list of devices (sepatated by semicolons or newlines) to run automated tests on, in the format 'model=<model-id>,version=<os-version-id>,locale=<locale>,orientation=<orientation>;model=<model-id>,...'. " \
+                                       "Run 'gcloud firebase test android|ios models list' to see available devices. Note: This feature is in beta",
                                        optional: true,
                                        type: String),
           FastlaneCore::ConfigItem.new(key: :test_username,

lib/fastlane/plugin/firebase_app_distribution/actions/firebase_app_distribution_add_testers_action.rb

@@ -1,7 +1,9 @@
 require 'fastlane/action'
+require 'fastlane_core'
 require 'fastlane_core/ui/ui'
-require 'google/apis/firebaseappdistribution_v1'
+require_relative '../helper/firebase_app_distribution_apis'
 require_relative '../helper/firebase_app_distribution_helper'
+require_relative '../helper/firebase_app_distribution_error_message'
 require_relative '../helper/firebase_app_distribution_auth_client'
 
 module Fastlane

lib/fastlane/plugin/firebase_app_distribution/actions/firebase_app_distribution_create_group_action.rb

@@ -1,7 +1,9 @@
 require 'fastlane/action'
+require 'fastlane_core'
 require 'fastlane_core/ui/ui'
-require 'google/apis/firebaseappdistribution_v1'
+require_relative '../helper/firebase_app_distribution_apis'
 require_relative '../helper/firebase_app_distribution_helper'
+require_relative '../helper/firebase_app_distribution_error_message'
 require_relative '../helper/firebase_app_distribution_auth_client'
 
 module Fastlane

lib/fastlane/plugin/firebase_app_distribution/actions/firebase_app_distribution_delete_group_action.rb

@@ -1,7 +1,9 @@
 require 'fastlane/action'
+require 'fastlane_core'
 require 'fastlane_core/ui/ui'
-require 'google/apis/firebaseappdistribution_v1'
+require_relative '../helper/firebase_app_distribution_apis'
 require_relative '../helper/firebase_app_distribution_helper'
+require_relative '../helper/firebase_app_distribution_error_message'
 require_relative '../helper/firebase_app_distribution_auth_client'
 
 module Fastlane

lib/fastlane/plugin/firebase_app_distribution/actions/firebase_app_distribution_get_latest_release.rb

@@ -1,6 +1,8 @@
 require 'fastlane/action'
-require 'google/apis/firebaseappdistribution_v1'
+require 'fastlane_core'
+require_relative '../helper/firebase_app_distribution_apis'
 require_relative '../helper/firebase_app_distribution_auth_client'
+require_relative '../helper/firebase_app_distribution_error_message'
 require_relative '../helper/firebase_app_distribution_helper'
 
 module Fastlane

lib/fastlane/plugin/firebase_app_distribution/actions/firebase_app_distribution_get_udids.rb

@@ -1,8 +1,9 @@
 require 'fastlane/action'
+require 'fastlane_core'
 require 'open3'
 require 'shellwords'
 require 'googleauth'
-require 'google/apis/firebaseappdistribution_v1alpha'
+require_relative '../helper/firebase_app_distribution_apis'
 require_relative '../helper/firebase_app_distribution_helper'
 require_relative '../helper/firebase_app_distribution_error_message'
 require_relative '../helper/firebase_app_distribution_auth_client'

lib/fastlane/plugin/firebase_app_distribution/actions/firebase_app_distribution_remove_testers_action.rb

@@ -1,7 +1,9 @@
 require 'fastlane/action'
+require 'fastlane_core'
 require 'fastlane_core/ui/ui'
-require 'google/apis/firebaseappdistribution_v1'
+require_relative '../helper/firebase_app_distribution_apis'
 require_relative '../helper/firebase_app_distribution_helper'
+require_relative '../helper/firebase_app_distribution_error_message'
 require_relative '../helper/firebase_app_distribution_auth_client'
 
 module Fastlane

lib/fastlane/plugin/firebase_app_distribution/helper/firebase_app_distribution_apis.rb

@@ -0,0 +1,2 @@
+require 'google/apis/firebaseappdistribution_v1'
+require 'google/apis/firebaseappdistribution_v1alpha'

lib/fastlane/plugin/firebase_app_distribution/helper/firebase_app_distribution_auth_client.rb

@@ -1,5 +1,6 @@
 require 'googleauth'
 require 'fastlane_core/ui/ui'
+require_relative './firebase_app_distribution_error_message'
 
 module Fastlane
   UI = FastlaneCore::UI unless Fastlane.const_defined?("UI")

lib/fastlane/plugin/firebase_app_distribution/helper/firebase_app_distribution_helper.rb

@@ -1,5 +1,8 @@
 require 'fastlane_core/ui/ui'
 require 'cfpropertylist'
+require 'google/apis/core'
+require 'google/apis/options'
+require_relative './firebase_app_distribution_error_message'
 
 module Fastlane
   UI = FastlaneCore::UI unless Fastlane.const_defined?("UI")