Skip to content

[Prototype] Migrate app distro to dagger. #4380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

[Prototype] Migrate app distro to dagger. #4380

wants to merge 8 commits into from

Conversation

vkryachko
Copy link
Member

No description provided.

lfkellogg and others added 6 commits November 18, 2022 12:47
@lfkellogg
Minor updates to the App Distribution test app. (#4088)
61d5c0b
@kaibolay @lfkellogg
Update various versions (#4090)
d1e3d17 
* Updated various versions (dependencies and SDK to fix Android resource linking failure (AAPT: error: resource android:attr/lStar not found.)

* Update compileSdk/targetSdkVersion from 31 to 33
@emilypgoogle @lfkellogg
Resolve strict mode violations in firebase-appdistribution (#4092)
58b7060
@kaibolay @lfkellogg
Remove release field. (#4174)
26f743d
@lfkellogg
Use shared executors in App Distribution SDK (#4338)
abdd518
@lfkellogg
Remove some synchronized blocks from FirebaseAppDistributionImpl (#4353)
1ae9488 
* Remove some synchronized blocks from FirebaseAppDistributionImpl

* Rename UpdateTaskCache.java to TaskCache.java

* Add @FunctionalInterface annotation

* Reformat a comment
@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 30, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-appdistribution

    Overall coverage changed from ? (1ae9488) to 0.00% (3c77fd0) by ?.

    53 individual files with coverage change

    FilenameBase (1ae9488)Merge (3c77fd0)Diff
    AabUpdater.java?0.00%?
    AabUpdater_Factory.java?0.00%?
    ActivityInjector.java?0.00%?
    ActivityInjector_Factory.java?0.00%?
    ApkInstaller.java?0.00%?
    ApkInstaller_Factory.java?0.00%?
    ApkUpdater.java?0.00%?
    ApkUpdater_Factory.java?0.00%?
    AppDistributionReleaseImpl.java?0.00%?
    AppDistributionReleaseInternal.java?0.00%?
    AppDistroComponent.java?0.00%?
    AppDistroComponent_MainModule_ProvidesAppNameFactory.java?0.00%?
    AppIconSource.java?0.00%?
    AutoValue_AppDistributionReleaseImpl.java?0.00%?
    AutoValue_AppDistributionReleaseInternal.java?0.00%?
    AutoValue_TesterApiDisabledErrorDetails.java?0.00%?
    AutoValue_TesterApiDisabledErrorDetails_HelpLink.java?0.00%?
    AutoValue_UpdateProgressImpl.java?0.00%?
    DaggerAppDistroComponent.java?0.00%?
    ErrorMessages.java?0.00%?
    FirebaseAppDistributionExceptions.java?0.00%?
    FirebaseAppDistributionFileProvider.java?0.00%?
    FirebaseAppDistributionImpl.java?0.00%?
    FirebaseAppDistributionImpl_Factory.java?0.00%?
    FirebaseAppDistributionLifecycleNotifier.java?0.00%?
    FirebaseAppDistributionLifecycleNotifier_Factory.java?0.00%?
    FirebaseAppDistributionNotificationsManager.java?0.00%?
    FirebaseAppDistributionNotificationsManager_Factory.java?0.00%?
    FirebaseAppDistributionRegistrar.java?0.00%?
    FirebaseAppDistributionTesterApiClient.java?0.00%?
    FirebaseAppDistributionTesterApiClient_Factory.java?0.00%?
    HttpsUrlConnectionFactory.java?0.00%?
    HttpsUrlConnectionFactory_Factory.java?0.00%?
    InstallActivity.java?0.00%?
    LogWrapper.java?0.00%?
    NewReleaseFetcher.java?0.00%?
    NewReleaseFetcher_Factory.java?0.00%?
    PackageInfoUtils.java?0.00%?
    ReleaseIdentifier.java?0.00%?
    ReleaseIdentifier_Factory.java?0.00%?
    ReleaseUtils.java?0.00%?
    SignInResultActivity.java?0.00%?
    SignInStorage.java?0.00%?
    SignInStorage_Factory.java?0.00%?
    TaskCache.java?0.00%?
    TaskUtils.java?0.00%?
    TesterApiDisabledErrorDetails.java?0.00%?
    TesterApiHttpClient.java?0.00%?
    TesterApiHttpClient_Factory.java?0.00%?
    TesterSignInManager.java?0.00%?
    TesterSignInManager_Factory.java?0.00%?
    UpdateProgressImpl.java?0.00%?
    UpdateTaskImpl.java?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/V31bhTclhC.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 30, 2022 •
edited
Loading

Size Report 1

Affected Products

  • firebase-appdistribution

    TypeBase (1ae9488)Merge (bf57f6f)Diff
    aar142 kB195 kB+53.8 kB (+38.0%)
    apk (aggressive)785 kB787 kB+1.56 kB (+0.2%)
    apk (release)2.01 MB2.02 MB+12.8 kB (+0.6%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/kDM8uK9qVb.html

@github-actions
Copy link
Contributor

Unit Test Results

   397 files     397 suites   18m 59s ⏱️
4 744 tests 4 722 ✔️ 22 💤 0 ❌
4 760 runs  4 738 ✔️ 22 💤 0 ❌

Results for commit df3b952.

@lfkellogg lfkellogg mentioned this pull request Jan 6, 2023
Merged
Base automatically changed from fad/next to master February 21, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/work-in-progress size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vkryachko @google-oss-bot @lfkellogg @kaibolay @emilypgoogle