Skip to content

Fix fcm tests. #4389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix fcm tests. #4389

wants to merge 1 commit into from

Conversation

vkryachko
Copy link
Member

No description provided.

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@vkryachko
Copy link
Member Author

@gsakakihara I am not actually sure it's fixing anything, I got an error message saying:

Main looper has queued unexecuted runnables. This might be the cause of the test failure. You might need a shadowOf(Looper.getMainLooper()).idle() call.

Wdyt?

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2022

Unit Test Results

474 tests   - 4 193   474 ✔️  - 4 170   3m 35s ⏱️ - 14m 37s
  27 suites  -    351       0 💤  -      22 
  27 files    -    351       0  -        1 

Results for commit 7a50112. ± Comparison against base commit e461cb7.

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

No changes between base commit (e461cb7) and merge commit (db753e8).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ZzPkt3VmEE.html

@vkryachko vkryachko enabled auto-merge (squash) December 1, 2022 18:55
@vkryachko vkryachko disabled auto-merge December 1, 2022 18:55
@google-oss-bot
Copy link
Contributor

@gsakakihara
Copy link
Contributor

@gsakakihara I am not actually sure it's fixing anything, I got an error message saying:

Main looper has queued unexecuted runnables. This might be the cause of the test failure. You might need a shadowOf(Looper.getMainLooper()).idle() call.

Wdyt?

Was there a specific test that failed with this? This is the cause of the test failure some times, but not always. Also, I suspect this wouldn't actual fix the tests since I think @after methods only get called after the test has completed (and would have already failed).

@vkryachko
Copy link
Member Author

This is the test that keeps failing for me testUnsubscribeFromTopic_withPrefix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants