Skip to content

WIP Use dagger for common. #4390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

WIP Use dagger for common. #4390

wants to merge 4 commits into from
+281 −153

Conversation

vkryachko
Copy link
Member

No description provided.

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 2, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-common

    Overall coverage changed from ? (b5a821d) to 0.00% (22ddf4c) by ?.

    56 individual files with coverage change

    FilenameBase (b5a821d)Merge (22ddf4c)Diff
    AppComponent.java?0.00%?
    AppComponent_MainModule_ProvideComponentRuntimeFactory.java?0.00%?
    AppComponent_MainModule_ProvidesBgExecutorFactory.java?0.00%?
    AppComponent_MainModule_ProvidesGlobalLibraryRegistrarFactory.java?0.00%?
    AppComponent_MainModule_ProvidesHeartBeatConsumersFactory.java?0.00%?
    AppComponent_MainModule_ProvidesPersistenceKeyFactory.java?0.00%?
    AppComponent_MainModule_ProvidesPublisherFactory.java?0.00%?
    AutoValue_HeartBeatResult.java?0.00%?
    AutoValue_LibraryVersion.java?0.00%?
    AutoValue_SdkHeartBeatResult.java?0.00%?
    AutoValue_StartupTime.java?0.00%?
    ComponentDiscoveryService.java?0.00%?
    ComponentMonitor.java?0.00%?
    CustomThreadFactory.java?0.00%?
    DaggerAppComponent.java?0.00%?
    DataCollectionConfigStorage.java?0.00%?
    DataCollectionConfigStorage_Factory.java?0.00%?
    DataCollectionDefaultChange.java?0.00%?
    DefaultHeartBeatController.java?0.00%?
    DefaultHeartBeatController_Factory.java?0.00%?
    DefaultUserAgentPublisher.java?0.00%?
    DefaultUserAgentPublisher_Factory.java?0.00%?
    DelegatingScheduledExecutorService.java?0.00%?
    DelegatingScheduledFuture.java?0.00%?
    EmulatedServiceSettings.java?0.00%?
    ExecutorsRegistrar.java?0.00%?
    FirebaseApp.java?0.00%?
    FirebaseAppLifecycleListener.java?0.00%?
    FirebaseApp_Factory.java?0.00%?
    FirebaseCommonRegistrar.java?0.00%?
    FirebaseError.java?0.00%?
    FirebaseExecutors.java?0.00%?
    FirebaseInitProvider.java?0.00%?
    FirebaseNetworkException.java?0.00%?
    FirebaseOptions.java?0.00%?
    FirebaseTooManyRequestsException.java?0.00%?
    FirebaseTrace.java?0.00%?
    GlobalLibraryVersionRegistrar.java?0.00%?
    HeartBeatConsumer.java?0.00%?
    HeartBeatConsumerComponent.java?0.00%?
    HeartBeatController.java?0.00%?
    HeartBeatInfo.java?0.00%?
    HeartBeatInfoStorage.java?0.00%?
    HeartBeatInfoStorage_Factory.java?0.00%?
    HeartBeatResult.java?0.00%?
    KotlinDetector.java?0.00%?
    LibraryVersion.java?0.00%?
    LibraryVersionComponent.java?0.00%?
    LibraryVersionsModule.java?0.00%?
    LibraryVersionsModule_ProvidesLibraryVersionsFactory.java?0.00%?
    PublicApi.java?0.00%?
    SdkHeartBeatResult.java?0.00%?
    SequentialExecutor.java?0.00%?
    StartupTime.java?0.00%?
    UiExecutor.java?0.00%?
    UserAgentPublisher.java?0.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/8patzhla8B.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 2, 2022 •
edited
Loading

Size Report 1

Affected Products

  • firebase-common

    TypeBase (b5a821d)Merge (22ddf4c)Diff
    aar67.4 kB93.8 kB+26.4 kB (+39.1%)
    apk (aggressive)95.1 kB97.2 kB+2.13 kB (+2.2%)
    apk (release)700 kB706 kB+6.00 kB (+0.9%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/4g13OlOoEt.html

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2022 •
edited
Loading

Unit Test Results

   342 files   -   55     342 suites   - 55   17m 58s ⏱️ -38s
4 308 tests  - 436  4 285 ✔️  - 434  22 💤 ±0  1 ❌  - 2 
4 324 runs   - 436  4 301 ✔️  - 434  22 💤 ±0  1 ❌  - 2 

For more details on these failures, see this check.

Results for commit fde652d. ± Comparison against base commit b5a821d.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 2, 2022 •
edited
Loading

Startup Time Report 1

The report is too large (78,484 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/9FGeeze2mo/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/work-in-progress size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vkryachko @google-oss-bot