Configurable executor limit for download/upload tasks on FirebaseStorage #4445
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now this library only works with a limit of 2 threads for upload operations and 3 for download operations. With this limitation being fixed it can create problems for applications in which rely heavily on firebase storage for uploading/downloading a huge number of files at a time (Eg: 400+). This limitation in this scenario leads to a bad user experience when the users have to wait several minutes, even hours, and this is also a totally different experience that the iOS library provides too with more than 2/3 requests at a time.
The goal with this PR is to make it more configurable giving the developers the ability to manually adjust this limit on their applications if they want to!
Here are some threads related to this:
https://stackoverflow.com/questions/50917737/firebase-storage-limit-of-simultaneous-file-uploads-with-sdk
https://stackoverflow.com/questions/60163889/android-firebase-storage-sdk-maximum-parallel-uploads