Skip to content

WIP: Fix storage Tests #4636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

WIP: Fix storage Tests #4636

wants to merge 7 commits into from

Conversation

maneesht
Copy link
Contributor

@maneesht maneesht commented Feb 8, 2023

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Add the 'main-merge-ack' label to your PR to confirm merging into the main branch is intended.

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

Unit Test Results

173 tests   - 619   173 ✔️  - 619   25m 16s ⏱️ + 20m 24s
  30 suites  -   30       0 💤 ±    0 
  30 files    -   30       0 ±    0 

Results for commit 4634481. ± Comparison against base commit ac5883e.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 8, 2023

Size Report 1

Affected Products

  • firebase-storage

    TypeBase (ac5883e)Merge (2d2bafa)Diff
    aar116 kB116 kB+83 B (+0.1%)
    apk (release)1.59 MB1.59 MB-256 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/pLKjAqKqS9.html

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • ComponentDiscovery

    DeviceStatisticsDistributions
    oriole-32
    Percentileac5883e7bda996DiffSignificant (?)
    p10459 ±53 μs440 ±27 μs-19.3 μs (-4.2%)NO
    p25508 ±57 μs482 ±34 μs-26.2 μs (-5.2%)NO
    p50593 ±65 μs570 ±37 μs-22.8 μs (-3.8%)NO
    p75702 ±81 μs671 ±45 μs-31.6 μs (-4.5%)NO
    p90860 ±103 μs848 ±72 μs-12.6 μs (-1.5%)NO

    20 test runs in comparison
    CommitTest Runs
    ac5883e
    • 2023-02-08_00:35:51.287348_liFb
    • 2023-02-08_00:35:51.291445_aZNZ
    • 2023-02-08_00:35:51.291460_pzxN
    • 2023-02-08_00:35:51.291468_bGQO
    • 2023-02-08_00:35:51.291475_oQrw
    • 2023-02-08_00:35:51.291482_XQTi
    • 2023-02-08_00:35:51.291489_dEhO
    • 2023-02-08_00:35:51.291495_vBwW
    • 2023-02-08_00:35:51.291502_BgFW
    • 2023-02-08_00:35:51.291508_YDiK
    7bda996
    • 2023-02-08_20:20:45.526155_ahpG
    • 2023-02-08_20:20:45.527818_nAVD
    • 2023-02-08_20:20:45.527828_vKcm
    • 2023-02-08_20:20:45.527834_iZnj
    • 2023-02-08_20:20:45.527840_Avkb
    • 2023-02-08_20:20:45.527848_iFmF
    • 2023-02-08_20:20:45.527853_tpcj
    • 2023-02-08_20:20:45.527858_CeXR
    • 2023-02-08_20:20:45.527864_igoo
    • 2023-02-08_20:20:45.527869_ANan
    redfin-30
    Percentileac5883e7bda996DiffSignificant (?)
    p10773 ±14 μs765 ±11 μs-7.93 μs (-1.0%)NO
    p25805 ±14 μs797 ±15 μs-8.28 μs (-1.0%)NO
    p50881 ±18 μs877 ±30 μs-4.72 μs (-0.5%)NO
    p751.11 ±0.07 ms1.09 ±0.07 ms-21.2 μs (-1.9%)NO
    p901.55 ±0.2 ms1.54 ±0.2 ms-4.38 μs (-0.3%)NO

    20 test runs in comparison
    CommitTest Runs
    ac5883e
    • 2023-02-08_00:35:51.287348_liFb
    • 2023-02-08_00:35:51.291445_aZNZ
    • 2023-02-08_00:35:51.291460_pzxN
    • 2023-02-08_00:35:51.291468_bGQO
    • 2023-02-08_00:35:51.291475_oQrw
    • 2023-02-08_00:35:51.291482_XQTi
    • 2023-02-08_00:35:51.291489_dEhO
    • 2023-02-08_00:35:51.291495_vBwW
    • 2023-02-08_00:35:51.291502_BgFW
    • 2023-02-08_00:35:51.291508_YDiK
    7bda996
    • 2023-02-08_20:20:45.526155_ahpG
    • 2023-02-08_20:20:45.527818_nAVD
    • 2023-02-08_20:20:45.527828_vKcm
    • 2023-02-08_20:20:45.527834_iZnj
    • 2023-02-08_20:20:45.527840_Avkb
    • 2023-02-08_20:20:45.527848_iFmF
    • 2023-02-08_20:20:45.527853_tpcj
    • 2023-02-08_20:20:45.527858_CeXR
    • 2023-02-08_20:20:45.527864_igoo
    • 2023-02-08_20:20:45.527869_ANan
  • Firebase

    DeviceStatisticsDistributions
    oriole-32
    Percentileac5883e7bda996DiffSignificant (?)
    p105.42 ±0.6 ms5.14 ±0.3 ms-282 μs (-5.2%)NO
    p255.67 ±0.6 ms5.41 ±0.3 ms-256 μs (-4.5%)NO
    p506.15 ±0.8 ms5.89 ±0.4 ms-267 μs (-4.3%)NO
    p756.71 ±0.8 ms6.54 ±0.5 ms-175 μs (-2.6%)NO
    p907.49 ±1 ms7.29 ±0.5 ms-202 μs (-2.7%)NO

    20 test runs in comparison
    CommitTest Runs
    ac5883e
    • 2023-02-08_00:35:51.287348_liFb
    • 2023-02-08_00:35:51.291445_aZNZ
    • 2023-02-08_00:35:51.291460_pzxN
    • 2023-02-08_00:35:51.291468_bGQO
    • 2023-02-08_00:35:51.291475_oQrw
    • 2023-02-08_00:35:51.291482_XQTi
    • 2023-02-08_00:35:51.291489_dEhO
    • 2023-02-08_00:35:51.291495_vBwW
    • 2023-02-08_00:35:51.291502_BgFW
    • 2023-02-08_00:35:51.291508_YDiK
    7bda996
    • 2023-02-08_20:20:45.526155_ahpG
    • 2023-02-08_20:20:45.527818_nAVD
    • 2023-02-08_20:20:45.527828_vKcm
    • 2023-02-08_20:20:45.527834_iZnj
    • 2023-02-08_20:20:45.527840_Avkb
    • 2023-02-08_20:20:45.527848_iFmF
    • 2023-02-08_20:20:45.527853_tpcj
    • 2023-02-08_20:20:45.527858_CeXR
    • 2023-02-08_20:20:45.527864_igoo
    • 2023-02-08_20:20:45.527869_ANan
    redfin-30
    Percentileac5883e7bda996DiffSignificant (?)
    p106.46 ±0.1 ms6.41 ±0.1 ms-48.5 μs (-0.8%)NO
    p256.68 ±0.1 ms6.63 ±0.1 ms-45.1 μs (-0.7%)NO
    p507.05 ±0.2 ms6.99 ±0.1 ms-54.5 μs (-0.8%)NO
    p757.66 ±0.1 ms7.70 ±0.2 ms+37.6 μs (+0.5%)NO
    p908.95 ±0.4 ms9.12 ±0.4 ms+169 μs (+1.9%)NO

    20 test runs in comparison
    CommitTest Runs
    ac5883e
    • 2023-02-08_00:35:51.287348_liFb
    • 2023-02-08_00:35:51.291445_aZNZ
    • 2023-02-08_00:35:51.291460_pzxN
    • 2023-02-08_00:35:51.291468_bGQO
    • 2023-02-08_00:35:51.291475_oQrw
    • 2023-02-08_00:35:51.291482_XQTi
    • 2023-02-08_00:35:51.291489_dEhO
    • 2023-02-08_00:35:51.291495_vBwW
    • 2023-02-08_00:35:51.291502_BgFW
    • 2023-02-08_00:35:51.291508_YDiK
    7bda996
    • 2023-02-08_20:20:45.526155_ahpG
    • 2023-02-08_20:20:45.527818_nAVD
    • 2023-02-08_20:20:45.527828_vKcm
    • 2023-02-08_20:20:45.527834_iZnj
    • 2023-02-08_20:20:45.527840_Avkb
    • 2023-02-08_20:20:45.527848_iFmF
    • 2023-02-08_20:20:45.527853_tpcj
    • 2023-02-08_20:20:45.527858_CeXR
    • 2023-02-08_20:20:45.527864_igoo
    • 2023-02-08_20:20:45.527869_ANan
  • Runtime

    DeviceStatisticsDistributions
    oriole-32
    Percentileac5883e7bda996DiffSignificant (?)
    p104.85 ±0.5 ms4.58 ±0.3 ms-270 μs (-5.6%)NO
    p255.04 ±0.6 ms4.83 ±0.3 ms-219 μs (-4.3%)NO
    p505.46 ±0.6 ms5.27 ±0.4 ms-198 μs (-3.6%)NO
    p755.98 ±0.7 ms5.82 ±0.4 ms-153 μs (-2.6%)NO
    p906.76 ±0.9 ms6.46 ±0.4 ms-292 μs (-4.3%)NO

    20 test runs in comparison
    CommitTest Runs
    ac5883e
    • 2023-02-08_00:35:51.287348_liFb
    • 2023-02-08_00:35:51.291445_aZNZ
    • 2023-02-08_00:35:51.291460_pzxN
    • 2023-02-08_00:35:51.291468_bGQO
    • 2023-02-08_00:35:51.291475_oQrw
    • 2023-02-08_00:35:51.291482_XQTi
    • 2023-02-08_00:35:51.291489_dEhO
    • 2023-02-08_00:35:51.291495_vBwW
    • 2023-02-08_00:35:51.291502_BgFW
    • 2023-02-08_00:35:51.291508_YDiK
    7bda996
    • 2023-02-08_20:20:45.526155_ahpG
    • 2023-02-08_20:20:45.527818_nAVD
    • 2023-02-08_20:20:45.527828_vKcm
    • 2023-02-08_20:20:45.527834_iZnj
    • 2023-02-08_20:20:45.527840_Avkb
    • 2023-02-08_20:20:45.527848_iFmF
    • 2023-02-08_20:20:45.527853_tpcj
    • 2023-02-08_20:20:45.527858_CeXR
    • 2023-02-08_20:20:45.527864_igoo
    • 2023-02-08_20:20:45.527869_ANan
    redfin-30
    Percentileac5883e7bda996DiffSignificant (?)
    p105.54 ±0.1 ms5.49 ±0.1 ms-44.6 μs (-0.8%)NO
    p255.71 ±0.1 ms5.67 ±0.1 ms-43.6 μs (-0.8%)NO
    p505.97 ±0.1 ms5.94 ±0.1 ms-32.5 μs (-0.5%)NO
    p756.38 ±0.2 ms6.38 ±0.2 ms+8.24 μs (+0.1%)NO
    p907.12 ±0.4 ms7.42 ±0.6 ms+307 μs (+4.3%)NO

    20 test runs in comparison
    CommitTest Runs
    ac5883e
    • 2023-02-08_00:35:51.287348_liFb
    • 2023-02-08_00:35:51.291445_aZNZ
    • 2023-02-08_00:35:51.291460_pzxN
    • 2023-02-08_00:35:51.291468_bGQO
    • 2023-02-08_00:35:51.291475_oQrw
    • 2023-02-08_00:35:51.291482_XQTi
    • 2023-02-08_00:35:51.291489_dEhO
    • 2023-02-08_00:35:51.291495_vBwW
    • 2023-02-08_00:35:51.291502_BgFW
    • 2023-02-08_00:35:51.291508_YDiK
    7bda996
    • 2023-02-08_20:20:45.526155_ahpG
    • 2023-02-08_20:20:45.527818_nAVD
    • 2023-02-08_20:20:45.527828_vKcm
    • 2023-02-08_20:20:45.527834_iZnj
    • 2023-02-08_20:20:45.527840_Avkb
    • 2023-02-08_20:20:45.527848_iFmF
    • 2023-02-08_20:20:45.527853_tpcj
    • 2023-02-08_20:20:45.527858_CeXR
    • 2023-02-08_20:20:45.527864_igoo
    • 2023-02-08_20:20:45.527869_ANan
  • fire-app-check

    DeviceStatisticsDistributions
    oriole-32
    Percentileac5883e7bda996DiffSignificant (?)
    p10506 ±536 μs368 ±394 μs-137 μs (-27.2%)NO
    p25530 ±550 μs387 ±406 μs-142 μs (-26.9%)NO
    p50593 ±618 μs412 ±414 μs-181 μs (-30.5%)NO
    p75651 ±645 μs474 ±419 μs-177 μs (-27.1%)NO
    p90784 ±702 μs548 ±454 μs-236 μs (-30.1%)NO

    20 test runs in comparison
    CommitTest Runs
    ac5883e
    • 2023-02-08_00:35:51.287348_liFb
    • 2023-02-08_00:35:51.291445_aZNZ
    • 2023-02-08_00:35:51.291460_pzxN
    • 2023-02-08_00:35:51.291468_bGQO
    • 2023-02-08_00:35:51.291475_oQrw
    • 2023-02-08_00:35:51.291482_XQTi
    • 2023-02-08_00:35:51.291489_dEhO
    • 2023-02-08_00:35:51.291495_vBwW
    • 2023-02-08_00:35:51.291502_BgFW
    • 2023-02-08_00:35:51.291508_YDiK
    7bda996
    • 2023-02-08_20:20:45.526155_ahpG
    • 2023-02-08_20:20:45.527818_nAVD
    • 2023-02-08_20:20:45.527828_vKcm
    • 2023-02-08_20:20:45.527834_iZnj
    • 2023-02-08_20:20:45.527840_Avkb
    • 2023-02-08_20:20:45.527848_iFmF
    • 2023-02-08_20:20:45.527853_tpcj
    • 2023-02-08_20:20:45.527858_CeXR
    • 2023-02-08_20:20:45.527864_igoo
    • 2023-02-08_20:20:45.527869_ANan
    redfin-30
    Percentileac5883e7bda996DiffSignificant (?)
    p101.28 ±2 ms1.71 ±2 ms+431 μs (+33.6%)NO
    p251.37 ±2 ms1.86 ±2 ms+493 μs (+35.9%)NO
    p501.51 ±2 ms2.06 ±2 ms+553 μs (+36.7%)NO
    p751.77 ±2 ms2.35 ±3 ms+579 μs (+32.7%)NO
    p902.21 ±3 ms2.78 ±3 ms+571 μs (+25.9%)NO

    20 test runs in comparison
    CommitTest Runs
    ac5883e
    • 2023-02-08_00:35:51.287348_liFb
    • 2023-02-08_00:35:51.291445_aZNZ
    • 2023-02-08_00:35:51.291460_pzxN
    • 2023-02-08_00:35:51.291468_bGQO
    • 2023-02-08_00:35:51.291475_oQrw
    • 2023-02-08_00:35:51.291482_XQTi
    • 2023-02-08_00:35:51.291489_dEhO
    • 2023-02-08_00:35:51.291495_vBwW
    • 2023-02-08_00:35:51.291502_BgFW
    • 2023-02-08_00:35:51.291508_YDiK
    7bda996
    • 2023-02-08_20:20:45.526155_ahpG
    • 2023-02-08_20:20:45.527818_nAVD
    • 2023-02-08_20:20:45.527828_vKcm
    • 2023-02-08_20:20:45.527834_iZnj
    • 2023-02-08_20:20:45.527840_Avkb
    • 2023-02-08_20:20:45.527848_iFmF
    • 2023-02-08_20:20:45.527853_tpcj
    • 2023-02-08_20:20:45.527858_CeXR
    • 2023-02-08_20:20:45.527864_igoo
    • 2023-02-08_20:20:45.527869_ANan
  • fire-gcs

    DeviceStatisticsDistributions
    oriole-32
    Percentileac5883e7bda996DiffSignificant (?)
    p1014.6 ±4 μs12.3 ±2 μs-2.22 μs (-15.2%)NO
    p2515.1 ±4 μs13.0 ±3 μs-2.12 μs (-14.1%)NO
    p5015.9 ±4 μs14.1 ±4 μs-1.80 μs (-11.3%)NO
    p7518.7 ±4 μs16.6 ±6 μs-2.15 μs (-11.5%)NO
    p9022.5 ±4 μs19.2 ±7 μs-3.28 μs (-14.6%)NO

    20 test runs in comparison
    CommitTest Runs
    ac5883e
    • 2023-02-08_00:35:51.287348_liFb
    • 2023-02-08_00:35:51.291445_aZNZ
    • 2023-02-08_00:35:51.291460_pzxN
    • 2023-02-08_00:35:51.291468_bGQO
    • 2023-02-08_00:35:51.291475_oQrw
    • 2023-02-08_00:35:51.291482_XQTi
    • 2023-02-08_00:35:51.291489_dEhO
    • 2023-02-08_00:35:51.291495_vBwW
    • 2023-02-08_00:35:51.291502_BgFW
    • 2023-02-08_00:35:51.291508_YDiK
    7bda996
    • 2023-02-08_20:20:45.526155_ahpG
    • 2023-02-08_20:20:45.527818_nAVD
    • 2023-02-08_20:20:45.527828_vKcm
    • 2023-02-08_20:20:45.527834_iZnj
    • 2023-02-08_20:20:45.527840_Avkb
    • 2023-02-08_20:20:45.527848_iFmF
    • 2023-02-08_20:20:45.527853_tpcj
    • 2023-02-08_20:20:45.527858_CeXR
    • 2023-02-08_20:20:45.527864_igoo
    • 2023-02-08_20:20:45.527869_ANan
    redfin-30
    Percentileac5883e7bda996DiffSignificant (?)
    p1032.4 ±7 μs28.0 ±7 μs-4.33 μs (-13.4%)NO
    p2533.7 ±7 μs29.6 ±7 μs-4.12 μs (-12.2%)NO
    p5035.5 ±8 μs31.7 ±8 μs-3.82 μs (-10.8%)NO
    p7537.7 ±8 μs35.3 ±9 μs-2.35 μs (-6.2%)NO
    p9044.8 ±15 μs46.7 ±15 μs+1.90 μs (+4.2%)NO

    20 test runs in comparison
    CommitTest Runs
    ac5883e
    • 2023-02-08_00:35:51.287348_liFb
    • 2023-02-08_00:35:51.291445_aZNZ
    • 2023-02-08_00:35:51.291460_pzxN
    • 2023-02-08_00:35:51.291468_bGQO
    • 2023-02-08_00:35:51.291475_oQrw
    • 2023-02-08_00:35:51.291482_XQTi
    • 2023-02-08_00:35:51.291489_dEhO
    • 2023-02-08_00:35:51.291495_vBwW
    • 2023-02-08_00:35:51.291502_BgFW
    • 2023-02-08_00:35:51.291508_YDiK
    7bda996
    • 2023-02-08_20:20:45.526155_ahpG
    • 2023-02-08_20:20:45.527818_nAVD
    • 2023-02-08_20:20:45.527828_vKcm
    • 2023-02-08_20:20:45.527834_iZnj
    • 2023-02-08_20:20:45.527840_Avkb
    • 2023-02-08_20:20:45.527848_iFmF
    • 2023-02-08_20:20:45.527853_tpcj
    • 2023-02-08_20:20:45.527858_CeXR
    • 2023-02-08_20:20:45.527864_igoo
    • 2023-02-08_20:20:45.527869_ANan
  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentileac5883e7bda996DiffSignificant (?)
    p10201 ±20 ms201 ±12 ms-371 μs (-0.2%)NO
    p25207 ±21 ms207 ±12 ms-531 μs (-0.3%)NO
    p50216 ±24 ms215 ±12 ms-444 μs (-0.2%)NO
    p75224 ±27 ms228 ±23 ms+3.41 ms (+1.5%)NO
    p90235 ±28 ms239 ±26 ms+4.50 ms (+1.9%)NO

    20 test runs in comparison
    CommitTest Runs
    ac5883e
    • 2023-02-08_00:35:51.287348_liFb
    • 2023-02-08_00:35:51.291445_aZNZ
    • 2023-02-08_00:35:51.291460_pzxN
    • 2023-02-08_00:35:51.291468_bGQO
    • 2023-02-08_00:35:51.291475_oQrw
    • 2023-02-08_00:35:51.291482_XQTi
    • 2023-02-08_00:35:51.291489_dEhO
    • 2023-02-08_00:35:51.291495_vBwW
    • 2023-02-08_00:35:51.291502_BgFW
    • 2023-02-08_00:35:51.291508_YDiK
    7bda996
    • 2023-02-08_20:20:45.526155_ahpG
    • 2023-02-08_20:20:45.527818_nAVD
    • 2023-02-08_20:20:45.527828_vKcm
    • 2023-02-08_20:20:45.527834_iZnj
    • 2023-02-08_20:20:45.527840_Avkb
    • 2023-02-08_20:20:45.527848_iFmF
    • 2023-02-08_20:20:45.527853_tpcj
    • 2023-02-08_20:20:45.527858_CeXR
    • 2023-02-08_20:20:45.527864_igoo
    • 2023-02-08_20:20:45.527869_ANan
    redfin-30
    Percentileac5883e7bda996DiffSignificant (?)
    p10231 ±4 ms254 ±5 ms+22.3 ms (+9.7%)MAYBE
    p25237 ±4 ms260 ±5 ms+23.1 ms (+9.7%)MAYBE
    p50244 ±4 ms268 ±6 ms+23.7 ms (+9.7%)MAYBE
    p75251 ±4 ms277 ±7 ms+25.6 ms (+10.2%)MAYBE
    p90259 ±5 ms289 ±9 ms+29.7 ms (+11.5%)MAYBE

    20 test runs in comparison
    CommitTest Runs
    ac5883e
    • 2023-02-08_00:35:51.287348_liFb
    • 2023-02-08_00:35:51.291445_aZNZ
    • 2023-02-08_00:35:51.291460_pzxN
    • 2023-02-08_00:35:51.291468_bGQO
    • 2023-02-08_00:35:51.291475_oQrw
    • 2023-02-08_00:35:51.291482_XQTi
    • 2023-02-08_00:35:51.291489_dEhO
    • 2023-02-08_00:35:51.291495_vBwW
    • 2023-02-08_00:35:51.291502_BgFW
    • 2023-02-08_00:35:51.291508_YDiK
    7bda996
    • 2023-02-08_20:20:45.526155_ahpG
    • 2023-02-08_20:20:45.527818_nAVD
    • 2023-02-08_20:20:45.527828_vKcm
    • 2023-02-08_20:20:45.527834_iZnj
    • 2023-02-08_20:20:45.527840_Avkb
    • 2023-02-08_20:20:45.527848_iFmF
    • 2023-02-08_20:20:45.527853_tpcj
    • 2023-02-08_20:20:45.527858_CeXR
    • 2023-02-08_20:20:45.527864_igoo
    • 2023-02-08_20:20:45.527869_ANan

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/7yALR2evz2/index.html

@google-oss-bot
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants