Skip to content

Parse stream invalidation message as a JSONObject. #4639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: realtime-rc-merge
Choose a base branch
from

Conversation

danasilver
Copy link
Contributor

@danasilver danasilver commented Feb 9, 2023

  • Use indexOf and lastIndexOf to find { and } in the invalidation message.
  • Convert string message to a JSONObject in the parsing method.
  • Unnest try {} catch {} since the enclosing if is no longer required since we're parsing the JSON in parseConfigUpdateMessage.

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-config

    Overall coverage changed from ? (9769f4d) to 81.71% (9758a1c) by ?.

    30 individual files with coverage change

    FilenameBase (9769f4d)Merge (9758a1c)Diff
    AutoValue_ConfigUpdate.java?29.41%?
    Code.java?0.00%?
    ConfigAutoFetch.java?87.63%?
    ConfigCacheClient.java?93.33%?
    ConfigContainer.java?93.27%?
    ConfigFetchHandler.java?92.86%?
    ConfigFetchHttpClient.java?86.21%?
    ConfigGetParameterHandler.java?96.45%?
    ConfigMetadataClient.java?92.31%?
    ConfigRealtimeHandler.java?41.38%?
    ConfigRealtimeHttpClient.java?45.76%?
    ConfigStorageClient.java?100.00%?
    ConfigUpdate.java?100.00%?
    ConfigUpdateListener.java?0.00%?
    ConfigUpdateListenerRegistration.java?0.00%?
    DefaultsXmlParser.java?0.00%?
    FirebaseRemoteConfig.java?88.14%?
    FirebaseRemoteConfigClientException.java?75.00%?
    FirebaseRemoteConfigException.java?95.65%?
    FirebaseRemoteConfigFetchThrottledException.java?100.00%?
    FirebaseRemoteConfigInfo.java?0.00%?
    FirebaseRemoteConfigInfoImpl.java?100.00%?
    FirebaseRemoteConfigServerException.java?84.21%?
    FirebaseRemoteConfigSettings.java?61.54%?
    FirebaseRemoteConfigValue.java?0.00%?
    FirebaseRemoteConfigValueImpl.java?84.62%?
    Personalization.java?91.43%?
    RemoteConfigComponent.java?89.61%?
    RemoteConfigConstants.java?0.00%?
    RemoteConfigRegistrar.java?100.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Tjud8FG5Cy.html

@github-actions
Copy link
Contributor

github-actions bot commented Feb 9, 2023

Unit Test Results

     63 files   -      63       63 suites   - 63   2m 3s ⏱️ - 1m 38s
1 243 tests ±       0  1 243 ✔️ ±       0  0 💤 ±0  0 ±0 
1 243 runs   - 1 243  1 243 ✔️  - 1 243  0 💤 ±0  0 ±0 

Results for commit cb7a915. ± Comparison against base commit 9769f4d.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • base

    TypeBase (9769f4d)Merge (9758a1c)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?8.65 kB? (?)
  • firebase-abt

    TypeBase (9769f4d)Merge (9758a1c)Diff
    aar?13.8 kB? (?)
    apk (aggressive)?116 kB? (?)
    apk (release)?1.27 MB? (?)
  • firebase-annotations

    TypeBase (9769f4d)Merge (9758a1c)Diff
    apk (aggressive)?8.39 kB? (?)
    apk (release)?9.46 kB? (?)
  • firebase-common

    TypeBase (9769f4d)Merge (9758a1c)Diff
    aar?67.4 kB? (?)
    apk (aggressive)?111 kB? (?)
    apk (release)?1.26 MB? (?)
  • firebase-components

    TypeBase (9769f4d)Merge (9758a1c)Diff
    aar?44.9 kB? (?)
    apk (aggressive)?23.1 kB? (?)
    apk (release)?596 kB? (?)
  • firebase-config

    TypeBase (9769f4d)Merge (9758a1c)Diff
    aar?88.3 kB? (?)
    apk (aggressive)?149 kB? (?)
    apk (release)?1.32 MB? (?)
  • firebase-installations

    TypeBase (9769f4d)Merge (9758a1c)Diff
    aar?55.0 kB? (?)
    apk (aggressive)?116 kB? (?)
    apk (release)?1.28 MB? (?)
  • firebase-installations-interop

    TypeBase (9769f4d)Merge (9758a1c)Diff
    aar?8.05 kB? (?)
    apk (aggressive)?65.0 kB? (?)
    apk (release)?651 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/gS4OC530Kr.html

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Startup time comparison between the CI merge commit (9758a1c) and the base commit (9769f4d) are not available.

No macrobenchmark data found for the base commit (9769f4d). Analysis for the CI merge commit (9758a1c) can be found at:

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/gjwG4tqAcJ/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants