Allow disabling Custom Tabs when handling In-App Message click actions #4728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thatfiredev
reviewed
Mar 1, 2023
| @@ -82,6 +82,8 @@ public class FirebaseInAppMessagingDisplay extends FirebaseInAppMessagingDisplay | |||
| 20 * 1000; // auto dismiss after 20 seconds for banner | |||
| static final long INTERVAL_MILLIS = 1000; | |||
|
|
|||
| public boolean useCustomTabs = true; | |||
There was a problem hiding this comment.
We should probably make this variable private and have public getters/setters to be consistent with other Firebase APIs.
This was referenced Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, In-App Message links are handled by opening a Custom Tab. This behavior might be undesirable because deep links don't open in the app. It would be great if there was a way of disabling Custom Tabs.
Related issue #4726
I implemented an alternative (arguably better) solution here #4729