Skip to content

Attempt to fix flaky storage test #4957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,7 @@ private static boolean isResultSuccess(int resultCode) {
static String getErrorMessageForCode(int errorCode) {
switch (errorCode) {
case ERROR_UNKNOWN:
System.out.println("Error code: " + errorCode);
return "An unknown error occurred, please check the HTTP result code and inner "
+ "exception for server response.";
case ERROR_OBJECT_NOT_FOUND:
Expand All @@ -150,6 +151,7 @@ static String getErrorMessageForCode(int errorCode) {
case ERROR_CANCELED:
return "The operation was cancelled.";
default:
System.out.println("Error code: " + errorCode);
return "An unknown error occurred, please check the HTTP result code and inner "
+ "exception for server response.";
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,7 @@ private boolean shouldContinue() {
// we attempt to recover by calling recoverStatus(true)
if (inErrorState) {
if (currentTime > deadLine || !recoverStatus(true)) {
System.out.println("Deadline reached!");
if (serverStateValid()) {
tryChangeState(INTERNAL_STATE_FAILURE, false);
}
Expand Down
Loading