Skip to content

Copybara fix #5598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Copybara fix #5598

wants to merge 6 commits into from

Conversation

VinayGuthal
Copy link
Contributor

No description provided.

Copy link

google-cla bot commented Dec 12, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Contributor

github-actions bot commented Dec 12, 2023

Javadoc Changes:
--- /Users/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/functions/FirebaseFunctions.html	2023-12-14 20:45:23.000000000 +0000
+++ /Users/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/functions/FirebaseFunctions.html	2023-12-14 20:42:14.000000000 +0000
@@ -91,7 +91,7 @@
           <tr>
             <td><code>void</code></td>
             <td>
-              <div><code><a href="/docs/reference/android/com/google/firebase/functions/FirebaseFunctions.html#useFunctionsEmulator(java.lang.String)">useFunctionsEmulator</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a>&nbsp;origin)</code></div>
+              <div><code><span><del><a href="/docs/reference/android/com/google/firebase/functions/FirebaseFunctions.html#useFunctionsEmulator(java.lang.String)">useFunctionsEmulator</a></del></span>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a>&nbsp;origin)</code></div>
               <p><strong>This method is deprecated.</strong>
                 <p>Use <code><a href="/docs/reference/android/com/google/firebase/functions/FirebaseFunctions.html#useEmulator(java.lang.String,int)">useEmulator</a></code> to connect to the emulator.</p>
               </p>
@@ -291,7 +291,7 @@
       </div>
       <div class="api-item"><a name="useFunctionsEmulator-java.lang.String-"></a><a name="usefunctionsemulator"></a>
         <h3 class="api-name" id="useFunctionsEmulator(java.lang.String)">useFunctionsEmulator</h3>
-        <pre class="api-signature no-pretty-print">public&nbsp;void&nbsp;<a href="/docs/reference/android/com/google/firebase/functions/FirebaseFunctions.html#useFunctionsEmulator(java.lang.String)">useFunctionsEmulator</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a>&nbsp;origin)</pre>
+        <pre class="api-signature no-pretty-print">public&nbsp;void&nbsp;<span><del><a href="/docs/reference/android/com/google/firebase/functions/FirebaseFunctions.html#useFunctionsEmulator(java.lang.String)">useFunctionsEmulator</a></del></span>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a>&nbsp;origin)</pre>
         <aside class="caution"><strong>This method is deprecated.</strong><br>
           <p>Use <code><a href="/docs/reference/android/com/google/firebase/functions/FirebaseFunctions.html#useEmulator(java.lang.String,int)">useEmulator</a></code> to connect to the emulator.</p>
         </aside>
--- /Users/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/functions/FirebaseFunctions.html	2023-12-14 20:45:23.000000000 +0000
+++ /Users/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/functions/FirebaseFunctions.html	2023-12-14 20:42:14.000000000 +0000
@@ -91,7 +91,7 @@
           <tr>
             <td><code><a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-unit/index.html">Unit</a></code></td>
             <td>
-              <div><code><a href="/docs/reference/kotlin/com/google/firebase/functions/FirebaseFunctions.html#useFunctionsEmulator(java.lang.String)">useFunctionsEmulator</a>(origin:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a>)</code></div>
+              <div><code><span><del><a href="/docs/reference/kotlin/com/google/firebase/functions/FirebaseFunctions.html#useFunctionsEmulator(java.lang.String)">useFunctionsEmulator</a></del></span>(origin:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a>)</code></div>
               <p><strong>This function is deprecated.</strong>
                 <p>Use <code><a href="/docs/reference/kotlin/com/google/firebase/functions/FirebaseFunctions.html#useEmulator(java.lang.String,int)">useEmulator</a></code> to connect to the emulator.</p>
               </p>
@@ -291,7 +291,7 @@
       </div>
       <div class="api-item"><a name="useFunctionsEmulator-java.lang.String-"></a><a name="usefunctionsemulator"></a>
         <h3 class="api-name" id="useFunctionsEmulator(java.lang.String)">useFunctionsEmulator</h3>
-        <pre class="api-signature no-pretty-print">fun&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/functions/FirebaseFunctions.html#useFunctionsEmulator(java.lang.String)">useFunctionsEmulator</a>(origin:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a>):&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-unit/index.html">Unit</a></pre>
+        <pre class="api-signature no-pretty-print">fun&nbsp;<span><del><a href="/docs/reference/kotlin/com/google/firebase/functions/FirebaseFunctions.html#useFunctionsEmulator(java.lang.String)">useFunctionsEmulator</a></del></span>(origin:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a>):&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-unit/index.html">Unit</a></pre>
         <aside class="caution"><strong>This function is deprecated.</strong><br>
           <p>Use <code><a href="/docs/reference/kotlin/com/google/firebase/functions/FirebaseFunctions.html#useEmulator(java.lang.String,int)">useEmulator</a></code> to connect to the emulator.</p>
         </aside>

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

Copy link
Contributor

github-actions bot commented Dec 12, 2023

buildSrc Test Results

37 tests   37 ✔️  1m 4s ⏱️
  8 suites    0 💤
  8 files      0

Results for commit 901cfca.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Dec 12, 2023

Unit Test Results

   776 files  +   770     776 suites  +770   28m 6s ⏱️ + 27m 47s
3 964 tests +3 945  3 959 ✔️ +3 940    5 💤 +  5  0 ±0 
7 989 runs  +7 951  7 979 ✔️ +7 941  10 💤 +10  0 ±0 

Results for commit 901cfca. ± Comparison against base commit ac19e5d5.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 12, 2023

Size Report 1

Affected Products

  • firebase-firestore

    TypeBase (ff6cc57)Merge (4d3786c)Diff
    aar1.41 MB1.41 MB+215 B (+0.0%)
    apk (release)11.2 MB11.2 MB+16 B (+0.0%)
  • firebase-firestore-ktx

    TypeBase (ff6cc57)Merge (4d3786c)Diff
    apk (release)11.2 MB11.2 MB+16 B (+0.0%)
  • firebase-functions

    TypeBase (ff6cc57)Merge (4d3786c)Diff
    aar52.0 kB52.0 kB+12 B (+0.0%)
  • firebase-inappmessaging

    TypeBase (ff6cc57)Merge (4d3786c)Diff
    aar461 kB461 kB+337 B (+0.1%)
    apk (release)11.5 MB11.5 MB+4 B (+0.0%)
  • firebase-inappmessaging-display

    TypeBase (ff6cc57)Merge (4d3786c)Diff
    apk (release)13.9 MB13.9 MB+12 B (+0.0%)
  • firebase-inappmessaging-display-ktx

    TypeBase (ff6cc57)Merge (4d3786c)Diff
    apk (release)13.9 MB13.9 MB+12 B (+0.0%)
  • firebase-inappmessaging-ktx

    TypeBase (ff6cc57)Merge (4d3786c)Diff
    apk (release)11.5 MB11.5 MB+4 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/1u2mFZiawJ.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 12, 2023

Coverage Report 1

Affected Products

  • firebase-messaging

    Overall coverage changed from 84.00% (ff6cc57) to 83.93% (4d3786c) by -0.08%.

    FilenameBase (ff6cc57)Merge (4d3786c)Diff
    FirebaseMessaging.java74.45%73.57%-0.88%
  • firebase-storage

    Overall coverage changed from 83.92% (ff6cc57) to 84.08% (4d3786c) by +0.17%.

    FilenameBase (ff6cc57)Merge (4d3786c)Diff
    StorageException.java65.45%69.09%+3.64%
    StorageTask.java83.38%83.69%+0.30%
    StreamDownloadTask.java88.41%88.89%+0.48%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/awyMsTK9YY.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Dec 12, 2023

Startup Time Report 1

The report is too large (122,640 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/xTtIFGwKoT/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants