Skip to content

Maintain sync for copybara #5599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Maintain sync for copybara #5599

wants to merge 3 commits into from

Conversation

VinayGuthal
Copy link
Contributor

No description provided.

Copy link

google-cla bot commented Dec 12, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Contributor

github-actions bot commented Dec 12, 2023

Javadoc Changes:
--- /Users/runner/diff/original/firebase-kotlindoc/android/com/google/firebase/functions/FirebaseFunctions.html	2023-12-12 18:23:37.000000000 +0000
+++ /Users/runner/diff/modified/firebase-kotlindoc/android/com/google/firebase/functions/FirebaseFunctions.html	2023-12-12 18:20:56.000000000 +0000
@@ -91,7 +91,7 @@
           <tr>
             <td><code>void</code></td>
             <td>
-              <div><code><a href="/docs/reference/android/com/google/firebase/functions/FirebaseFunctions.html#useFunctionsEmulator(java.lang.String)">useFunctionsEmulator</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a>&nbsp;origin)</code></div>
+              <div><code><span><del><a href="/docs/reference/android/com/google/firebase/functions/FirebaseFunctions.html#useFunctionsEmulator(java.lang.String)">useFunctionsEmulator</a></del></span>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a>&nbsp;origin)</code></div>
               <p><strong>This method is deprecated.</strong>
                 <p>Use <code><a href="/docs/reference/android/com/google/firebase/functions/FirebaseFunctions.html#useEmulator(java.lang.String,int)">useEmulator</a></code> to connect to the emulator.</p>
               </p>
@@ -291,7 +291,7 @@
       </div>
       <div class="api-item"><a name="useFunctionsEmulator-java.lang.String-"></a><a name="usefunctionsemulator"></a>
         <h3 class="api-name" id="useFunctionsEmulator(java.lang.String)">useFunctionsEmulator</h3>
-        <pre class="api-signature no-pretty-print">public&nbsp;void&nbsp;<a href="/docs/reference/android/com/google/firebase/functions/FirebaseFunctions.html#useFunctionsEmulator(java.lang.String)">useFunctionsEmulator</a>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a>&nbsp;origin)</pre>
+        <pre class="api-signature no-pretty-print">public&nbsp;void&nbsp;<span><del><a href="/docs/reference/android/com/google/firebase/functions/FirebaseFunctions.html#useFunctionsEmulator(java.lang.String)">useFunctionsEmulator</a></del></span>(@<a href="https://developer.android.com/reference/kotlin/androidx/annotation/NonNull.html">NonNull</a> <a href="https://developer.android.com/reference/kotlin/java/lang/String.html">String</a>&nbsp;origin)</pre>
         <aside class="caution"><strong>This method is deprecated.</strong><br>
           <p>Use <code><a href="/docs/reference/android/com/google/firebase/functions/FirebaseFunctions.html#useEmulator(java.lang.String,int)">useEmulator</a></code> to connect to the emulator.</p>
         </aside>
--- /Users/runner/diff/original/firebase-kotlindoc/kotlin/com/google/firebase/functions/FirebaseFunctions.html	2023-12-12 18:23:37.000000000 +0000
+++ /Users/runner/diff/modified/firebase-kotlindoc/kotlin/com/google/firebase/functions/FirebaseFunctions.html	2023-12-12 18:20:56.000000000 +0000
@@ -91,7 +91,7 @@
           <tr>
             <td><code><a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-unit/index.html">Unit</a></code></td>
             <td>
-              <div><code><a href="/docs/reference/kotlin/com/google/firebase/functions/FirebaseFunctions.html#useFunctionsEmulator(java.lang.String)">useFunctionsEmulator</a>(origin:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a>)</code></div>
+              <div><code><span><del><a href="/docs/reference/kotlin/com/google/firebase/functions/FirebaseFunctions.html#useFunctionsEmulator(java.lang.String)">useFunctionsEmulator</a></del></span>(origin:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a>)</code></div>
               <p><strong>This function is deprecated.</strong>
                 <p>Use <code><a href="/docs/reference/kotlin/com/google/firebase/functions/FirebaseFunctions.html#useEmulator(java.lang.String,int)">useEmulator</a></code> to connect to the emulator.</p>
               </p>
@@ -291,7 +291,7 @@
       </div>
       <div class="api-item"><a name="useFunctionsEmulator-java.lang.String-"></a><a name="usefunctionsemulator"></a>
         <h3 class="api-name" id="useFunctionsEmulator(java.lang.String)">useFunctionsEmulator</h3>
-        <pre class="api-signature no-pretty-print">fun&nbsp;<a href="/docs/reference/kotlin/com/google/firebase/functions/FirebaseFunctions.html#useFunctionsEmulator(java.lang.String)">useFunctionsEmulator</a>(origin:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a>):&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-unit/index.html">Unit</a></pre>
+        <pre class="api-signature no-pretty-print">fun&nbsp;<span><del><a href="/docs/reference/kotlin/com/google/firebase/functions/FirebaseFunctions.html#useFunctionsEmulator(java.lang.String)">useFunctionsEmulator</a></del></span>(origin:&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-string/index.html">String</a>):&nbsp;<a href="https://kotlinlang.org/api/latest/jvm/stdlib/kotlin/-unit/index.html">Unit</a></pre>
         <aside class="caution"><strong>This function is deprecated.</strong><br>
           <p>Use <code><a href="/docs/reference/kotlin/com/google/firebase/functions/FirebaseFunctions.html#useEmulator(java.lang.String,int)">useEmulator</a></code> to connect to the emulator.</p>
         </aside>

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

Copy link
Contributor

buildSrc Test Results

37 tests   37 ✔️  1m 1s ⏱️
  8 suites    0 💤
  8 files      0

Results for commit 09422a5.

@google-oss-bot
Copy link
Contributor

Copy link
Contributor

Unit Test Results

20 files  +14  20 suites  +14   27s ⏱️ +8s
23 tests +  4  23 ✔️ +  4  0 💤 ±0  0 ±0 
68 runs  +30  68 ✔️ +30  0 💤 ±0  0 ±0 

Results for commit 09422a5. ± Comparison against base commit ac19e5d5.

This pull request removes 19 and adds 23 tests. Note that renamed tests count towards both.
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_disabledAnrs_doesNotPersistsAppExitInfo
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_enabledAnrs_doesNotPersistsAppExitInfoIfItDoesntExist
com.google.firebase.crashlytics.internal.common.CrashlyticsControllerRobolectricTest ‑ testDoCloseSession_enabledAnrs_persistsAppExitInfoIfItExists
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_notPersistIfAnrBeforeSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_notPersistIfAppExitInfoNotAnrButWithinSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_persistIfAnrWithinSession
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testAppExitInfoEvent_persistIfAnrWithinSession_multipleAppExitInfo
com.google.firebase.crashlytics.internal.common.SessionReportingCoordinatorRobolectricTest ‑ testconvertInputStreamToString_worksSuccessfully
com.google.firebase.crashlytics.internal.model.CrashlyticsReportTest ‑ testGetBinaryImageUuidUtf8Bytes_returnsNullWhenUuidIsNull
com.google.firebase.crashlytics.internal.model.CrashlyticsReportTest ‑ testGetBinaryImageUuidUtf8Bytes_returnsProperBytes
…
com.google.firebase.functions.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallable should build callable with FAC settings (when false)
com.google.firebase.functions.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallable should build callable with FAC settings (when true)
com.google.firebase.functions.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallable should not use limited-use tokens by default
com.google.firebase.functions.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallableFromUrl callable with FAC settings (when false)
com.google.firebase.functions.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallableFromUrl callable with FAC settings (when true)
com.google.firebase.functions.AppCheckLimitedUseTest ‑ FirebaseFunctions#getHttpsCallableFromUrl should not use limited-use tokens by default
com.google.firebase.functions.FunctionsRegistrarTest ‑ getComponents_publishesLibVersionComponent
com.google.firebase.functions.FunctionsTests ‑ Firebase#functions should delegate to FirebaseFunctions#getInstance(FirebaseApp, region)
com.google.firebase.functions.FunctionsTests ‑ Firebase#functions should delegate to FirebaseFunctions#getInstance(region)
com.google.firebase.functions.FunctionsTests ‑ FirebaseApp#functions should delegate to FirebaseFunctions#getInstance(FirebaseApp)
…

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-functions

    TypeBase (ac19e5d)Merge (db8fb56)Diff
    aar52.0 kB52.0 kB+12 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/rujTKLf4Pr.html

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-fn

    DeviceStatisticsDistributions
    oriole-32
    Percentileac19e5ddb8fb56DiffSignificant (?)
    p1065.2 ±7 μs117 ±163 μs+52.1 μs (+79.9%)NO
    p2571.8 ±11 μs123 ±164 μs+51.1 μs (+71.1%)NO
    p5085.5 ±22 μs136 ±167 μs+50.7 μs (+59.3%)NO
    p75102 ±32 μs156 ±170 μs+54.3 μs (+53.4%)NO
    p90141 ±69 μs207 ±187 μs+66.7 μs (+47.4%)NO

    20 test runs in comparison
    CommitTest Runs
    ac19e5d
    • 2023-12-11_17:57:32.684838_NfMM
    • 2023-12-11_17:57:32.684869_uoQk
    • 2023-12-11_17:57:32.684878_oVGz
    • 2023-12-11_17:57:32.684888_osqN
    • 2023-12-11_17:57:32.684896_UMRH
    • 2023-12-11_17:57:32.684904_AWOJ
    • 2023-12-11_17:57:32.684913_CIBN
    • 2023-12-11_17:57:32.684922_VxRn
    • 2023-12-11_17:57:32.684929_WOyY
    • 2023-12-11_17:57:32.684936_prLf
    db8fb56
    • 2023-12-12_18:26:21.468322_tvTa
    • 2023-12-12_18:26:21.468356_ztjm
    • 2023-12-12_18:26:21.468363_zMQy
    • 2023-12-12_18:26:21.468368_XoZZ
    • 2023-12-12_18:26:21.468383_IDAg
    • 2023-12-12_18:26:21.468391_dOBP
    • 2023-12-12_18:26:21.468399_JDhk
    • 2023-12-12_18:26:21.468407_ABOB
    • 2023-12-12_18:26:21.468415_twwY
    • 2023-12-12_18:26:21.468422_kbqj
    redfin-30
    Percentileac19e5ddb8fb56DiffSignificant (?)
    p10244 ±222 μs190 ±166 μs-54.1 μs (-22.2%)NO
    p25250 ±222 μs197 ±169 μs-52.4 μs (-21.0%)NO
    p50259 ±223 μs208 ±171 μs-51.1 μs (-19.7%)NO
    p75276 ±226 μs223 ±173 μs-53.1 μs (-19.3%)NO
    p90351 ±271 μs242 ±177 μs-110 μs (-31.2%)NO

    20 test runs in comparison
    CommitTest Runs
    ac19e5d
    • 2023-12-11_17:57:32.684838_NfMM
    • 2023-12-11_17:57:32.684869_uoQk
    • 2023-12-11_17:57:32.684878_oVGz
    • 2023-12-11_17:57:32.684888_osqN
    • 2023-12-11_17:57:32.684896_UMRH
    • 2023-12-11_17:57:32.684904_AWOJ
    • 2023-12-11_17:57:32.684913_CIBN
    • 2023-12-11_17:57:32.684922_VxRn
    • 2023-12-11_17:57:32.684929_WOyY
    • 2023-12-11_17:57:32.684936_prLf
    db8fb56
    • 2023-12-12_18:26:21.468322_tvTa
    • 2023-12-12_18:26:21.468356_ztjm
    • 2023-12-12_18:26:21.468363_zMQy
    • 2023-12-12_18:26:21.468368_XoZZ
    • 2023-12-12_18:26:21.468383_IDAg
    • 2023-12-12_18:26:21.468391_dOBP
    • 2023-12-12_18:26:21.468399_JDhk
    • 2023-12-12_18:26:21.468407_ABOB
    • 2023-12-12_18:26:21.468415_twwY
    • 2023-12-12_18:26:21.468422_kbqj
  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentileac19e5ddb8fb56DiffSignificant (?)
    p10204 ±4 ms206 ±4 ms+1.87 ms (+0.9%)NO
    p25211 ±5 ms213 ±3 ms+1.94 ms (+0.9%)NO
    p50218 ±5 ms220 ±3 ms+2.33 ms (+1.1%)NO
    p75227 ±5 ms230 ±3 ms+3.03 ms (+1.3%)NO
    p90236 ±6 ms242 ±7 ms+6.06 ms (+2.6%)NO

    20 test runs in comparison
    CommitTest Runs
    ac19e5d
    • 2023-12-11_17:57:32.684838_NfMM
    • 2023-12-11_17:57:32.684869_uoQk
    • 2023-12-11_17:57:32.684878_oVGz
    • 2023-12-11_17:57:32.684888_osqN
    • 2023-12-11_17:57:32.684896_UMRH
    • 2023-12-11_17:57:32.684904_AWOJ
    • 2023-12-11_17:57:32.684913_CIBN
    • 2023-12-11_17:57:32.684922_VxRn
    • 2023-12-11_17:57:32.684929_WOyY
    • 2023-12-11_17:57:32.684936_prLf
    db8fb56
    • 2023-12-12_18:26:21.468322_tvTa
    • 2023-12-12_18:26:21.468356_ztjm
    • 2023-12-12_18:26:21.468363_zMQy
    • 2023-12-12_18:26:21.468368_XoZZ
    • 2023-12-12_18:26:21.468383_IDAg
    • 2023-12-12_18:26:21.468391_dOBP
    • 2023-12-12_18:26:21.468399_JDhk
    • 2023-12-12_18:26:21.468407_ABOB
    • 2023-12-12_18:26:21.468415_twwY
    • 2023-12-12_18:26:21.468422_kbqj
    redfin-30
    Percentileac19e5ddb8fb56DiffSignificant (?)
    p10250 ±3 ms272 ±6 ms+22.3 ms (+8.9%)MAYBE
    p25256 ±3 ms279 ±6 ms+22.9 ms (+8.9%)MAYBE
    p50263 ±3 ms287 ±6 ms+23.9 ms (+9.1%)MAYBE
    p75273 ±3 ms298 ±7 ms+24.9 ms (+9.1%)MAYBE
    p90283 ±4 ms311 ±8 ms+28.5 ms (+10.1%)MAYBE

    20 test runs in comparison
    CommitTest Runs
    ac19e5d
    • 2023-12-11_17:57:32.684838_NfMM
    • 2023-12-11_17:57:32.684869_uoQk
    • 2023-12-11_17:57:32.684878_oVGz
    • 2023-12-11_17:57:32.684888_osqN
    • 2023-12-11_17:57:32.684896_UMRH
    • 2023-12-11_17:57:32.684904_AWOJ
    • 2023-12-11_17:57:32.684913_CIBN
    • 2023-12-11_17:57:32.684922_VxRn
    • 2023-12-11_17:57:32.684929_WOyY
    • 2023-12-11_17:57:32.684936_prLf
    db8fb56
    • 2023-12-12_18:26:21.468322_tvTa
    • 2023-12-12_18:26:21.468356_ztjm
    • 2023-12-12_18:26:21.468363_zMQy
    • 2023-12-12_18:26:21.468368_XoZZ
    • 2023-12-12_18:26:21.468383_IDAg
    • 2023-12-12_18:26:21.468391_dOBP
    • 2023-12-12_18:26:21.468399_JDhk
    • 2023-12-12_18:26:21.468407_ABOB
    • 2023-12-12_18:26:21.468415_twwY
    • 2023-12-12_18:26:21.468422_kbqj

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/uunKQ2IPXD/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants