Skip to content

Set LRU GC as the default for memory cache. #5823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Set LRU GC as the default for memory cache. #5823

wants to merge 2 commits into from

Conversation

wu-hui
Copy link
Contributor

@wu-hui wu-hui commented Apr 2, 2024

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 2, 2024 •
edited
Loading

Release note changes

No release note changes were detected. If you made changes that should be
present in the next release, ensure you've added an entry in the appropriate
CHANGELOG.md file(s).

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 2, 2024 •
edited
Loading

Unit Test Results

   180 files  ±0     180 suites  ±0   4m 6s ⏱️ +6s
1 228 tests ±0  1 212 ✔️ ±0  16 💤 ±0  0 ❌ ±0 
2 480 runs  ±0  2 448 ✔️ ±0  32 💤 ±0  0 ❌ ±0 

Results for commit 7db4507. ± Comparison against base commit 6c3fc22.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 2, 2024 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 44.80% (6c3fc22) to 44.79% (55337e3) by -0.02%.

    FilenameBase (6c3fc22)Merge (55337e3)Diff
    DeleteMutation.java90.48%95.24%+4.76%
    FirebaseFirestoreSettings.java77.53%76.40%-1.12%
    Firestore.kt42.31%36.54%-5.77%
    MemoryComponentProvider.java82.93%95.12%+12.20%
    MemoryEagerGcSettings.java71.43%0.00%-71.43%
    MemoryLruGcSettings.java62.50%87.50%+25.00%
    PatchMutation.java100.00%98.39%-1.61%
    SetMutation.java97.22%94.44%-2.78%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/KkVXPfDCAr.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 2, 2024 •
edited
Loading

Size Report 1

Affected Products

  • firebase-firestore

    TypeBase (6c3fc22)Merge (55337e3)Diff
    aar1.41 MB1.41 MB+6 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/0QDJ3PzTLq.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 2, 2024 •
edited
Loading

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-fst

    DeviceStatisticsDistributions
    oriole-32
    Percentile6c3fc2255337e3DiffSignificant (?)
    p10411 ±210 μs462 ±236 μs+51.1 μs (+12.4%)NO
    p25422 ±213 μs480 ±239 μs+57.9 μs (+13.7%)NO
    p50441 ±217 μs510 ±236 μs+69.0 μs (+15.6%)NO
    p75502 ±212 μs594 ±229 μs+92.5 μs (+18.4%)NO
    p90577 ±196 μs694 ±260 μs+116 μs (+20.2%)NO

    20 test runs in comparison
    CommitTest Runs
    6c3fc22
    • 2024-03-29_14:30:42.971974_HFoA
    • 2024-03-29_14:30:42.972002_bsDe
    • 2024-03-29_14:30:42.972011_xphe
    • 2024-03-29_14:30:42.972021_rNjN
    • 2024-03-29_14:30:42.972029_myyk
    • 2024-03-29_14:30:42.972037_gMGs
    • 2024-03-29_14:30:42.972044_DBLm
    • 2024-03-29_14:30:42.972051_AhJt
    • 2024-03-29_14:30:42.972058_yUeV
    • 2024-03-29_14:30:42.972065_wXfB
    55337e3
    • 2024-04-03_16:51:28.991542_AbsD
    • 2024-04-03_16:51:28.991583_itPE
    • 2024-04-03_16:51:28.991595_nSCi
    • 2024-04-03_16:51:28.991605_Vnuk
    • 2024-04-03_16:51:28.991614_umLr
    • 2024-04-03_16:51:28.991623_JNfH
    • 2024-04-03_16:51:28.991628_JswZ
    • 2024-04-03_16:51:28.991632_ULdE
    • 2024-04-03_16:51:28.991636_XVEx
    • 2024-04-03_16:51:28.991640_kFkz
    redfin-30
    Percentile6c3fc2255337e3DiffSignificant (?)
    p10757 ±248 μs655 ±175 μs-102 μs (-13.5%)NO
    p25773 ±247 μs669 ±177 μs-104 μs (-13.4%)NO
    p50797 ±243 μs693 ±179 μs-105 μs (-13.1%)NO
    p75832 ±236 μs732 ±188 μs-99.6 μs (-12.0%)NO
    p90879 ±232 μs859 ±389 μs-20.0 μs (-2.3%)NO

    20 test runs in comparison
    CommitTest Runs
    6c3fc22
    • 2024-03-29_14:30:42.971974_HFoA
    • 2024-03-29_14:30:42.972002_bsDe
    • 2024-03-29_14:30:42.972011_xphe
    • 2024-03-29_14:30:42.972021_rNjN
    • 2024-03-29_14:30:42.972029_myyk
    • 2024-03-29_14:30:42.972037_gMGs
    • 2024-03-29_14:30:42.972044_DBLm
    • 2024-03-29_14:30:42.972051_AhJt
    • 2024-03-29_14:30:42.972058_yUeV
    • 2024-03-29_14:30:42.972065_wXfB
    55337e3
    • 2024-04-03_16:51:28.991542_AbsD
    • 2024-04-03_16:51:28.991583_itPE
    • 2024-04-03_16:51:28.991595_nSCi
    • 2024-04-03_16:51:28.991605_Vnuk
    • 2024-04-03_16:51:28.991614_umLr
    • 2024-04-03_16:51:28.991623_JNfH
    • 2024-04-03_16:51:28.991628_JswZ
    • 2024-04-03_16:51:28.991632_ULdE
    • 2024-04-03_16:51:28.991636_XVEx
    • 2024-04-03_16:51:28.991640_kFkz

  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentile6c3fc2255337e3DiffSignificant (?)
    p10198 ±2 ms205 ±4 ms+6.52 ms (+3.3%)NO
    p25204 ±2 ms210 ±4 ms+6.50 ms (+3.2%)NO
    p50211 ±3 ms218 ±4 ms+6.38 ms (+3.0%)NO
    p75219 ±3 ms226 ±5 ms+7.79 ms (+3.6%)NO
    p90228 ±4 ms238 ±9 ms+10.5 ms (+4.6%)NO

    20 test runs in comparison
    CommitTest Runs
    6c3fc22
    • 2024-03-29_14:30:42.971974_HFoA
    • 2024-03-29_14:30:42.972002_bsDe
    • 2024-03-29_14:30:42.972011_xphe
    • 2024-03-29_14:30:42.972021_rNjN
    • 2024-03-29_14:30:42.972029_myyk
    • 2024-03-29_14:30:42.972037_gMGs
    • 2024-03-29_14:30:42.972044_DBLm
    • 2024-03-29_14:30:42.972051_AhJt
    • 2024-03-29_14:30:42.972058_yUeV
    • 2024-03-29_14:30:42.972065_wXfB
    55337e3
    • 2024-04-03_16:51:28.991542_AbsD
    • 2024-04-03_16:51:28.991583_itPE
    • 2024-04-03_16:51:28.991595_nSCi
    • 2024-04-03_16:51:28.991605_Vnuk
    • 2024-04-03_16:51:28.991614_umLr
    • 2024-04-03_16:51:28.991623_JNfH
    • 2024-04-03_16:51:28.991628_JswZ
    • 2024-04-03_16:51:28.991632_ULdE
    • 2024-04-03_16:51:28.991636_XVEx
    • 2024-04-03_16:51:28.991640_kFkz
    redfin-30
    Percentile6c3fc2255337e3DiffSignificant (?)
    p10247 ±3 ms270 ±7 ms+23.0 ms (+9.3%)MAYBE
    p25253 ±3 ms275 ±8 ms+22.3 ms (+8.8%)MAYBE
    p50259 ±4 ms283 ±8 ms+23.7 ms (+9.2%)MAYBE
    p75266 ±4 ms292 ±9 ms+26.0 ms (+9.8%)MAYBE
    p90274 ±5 ms302 ±12 ms+28.9 ms (+10.6%)NO

    20 test runs in comparison
    CommitTest Runs
    6c3fc22
    • 2024-03-29_14:30:42.971974_HFoA
    • 2024-03-29_14:30:42.972002_bsDe
    • 2024-03-29_14:30:42.972011_xphe
    • 2024-03-29_14:30:42.972021_rNjN
    • 2024-03-29_14:30:42.972029_myyk
    • 2024-03-29_14:30:42.972037_gMGs
    • 2024-03-29_14:30:42.972044_DBLm
    • 2024-03-29_14:30:42.972051_AhJt
    • 2024-03-29_14:30:42.972058_yUeV
    • 2024-03-29_14:30:42.972065_wXfB
    55337e3
    • 2024-04-03_16:51:28.991542_AbsD
    • 2024-04-03_16:51:28.991583_itPE
    • 2024-04-03_16:51:28.991595_nSCi
    • 2024-04-03_16:51:28.991605_Vnuk
    • 2024-04-03_16:51:28.991614_umLr
    • 2024-04-03_16:51:28.991623_JNfH
    • 2024-04-03_16:51:28.991628_JswZ
    • 2024-04-03_16:51:28.991632_ULdE
    • 2024-04-03_16:51:28.991636_XVEx
    • 2024-04-03_16:51:28.991640_kFkz

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/C5x0fPalX8/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wu-hui @google-oss-bot