Skip to content

Shorten the length of the Crashlytics folder prefix for long package names #6067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

samedson
Copy link
Contributor

@samedson samedson commented Jul 1, 2024

Context in: b/338001446

@samedson samedson requested review from themiswang and mrober July 1, 2024 17:27
Copy link
Contributor

github-actions bot commented Jul 1, 2024

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor

Copy link
Contributor

github-actions bot commented Jul 1, 2024

Unit Test Results

  6 files   -      942    6 suites   - 942   14s ⏱️ - 34m 24s
19 tests  -   5 191  19 ✔️  -   5 170  0 💤  - 21  0 ±0 
38 runs   - 10 467  38 ✔️  - 10 425  0 💤  - 42  0 ±0 

Results for commit 6aa1a75. ± Comparison against base commit b4b096b.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-crashlytics

    TypeBase (b4b096b)Merge (cd5989f)Diff
    aar409 kB409 kB+3 B (+0.0%)
    apk (aggressive)688 kB688 kB-24 B (-0.0%)
    apk (release)5.84 MB5.84 MB-36 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/9lwQtGZ1Jc.html

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-cls

    DeviceStatisticsDistributions
    oriole-32
    Percentileb4b096bcd5989fDiffSignificant (?)
    p1010.6 ±2 ms9.99 ±3 ms-634 μs (-6.0%)NO
    p2511.3 ±2 ms10.6 ±3 ms-752 μs (-6.6%)NO
    p5012.3 ±2 ms11.4 ±3 ms-817 μs (-6.7%)NO
    p7513.7 ±3 ms12.6 ±3 ms-1.06 ms (-7.8%)NO
    p9015.4 ±3 ms14.2 ±4 ms-1.26 ms (-8.2%)NO

    20 test runs in comparison
    CommitTest Runs
    b4b096b
    • 2024-06-28_16:25:54.390976_oqrt
    • 2024-06-28_16:25:54.391032_dVvV
    • 2024-06-28_16:25:54.391042_BiAz
    • 2024-06-28_16:25:54.391050_dGvj
    • 2024-06-28_16:25:54.391057_HTyQ
    • 2024-06-28_16:25:54.391064_SiXR
    • 2024-06-28_16:25:54.391071_dDAt
    • 2024-06-28_16:25:54.391077_OcXT
    • 2024-06-28_16:25:54.391084_hhYt
    • 2024-06-28_16:25:54.391097_ceci
    cd5989f
    • 2024-07-01_17:40:05.998049_rWSk
    • 2024-07-01_17:40:05.998096_XfFf
    • 2024-07-01_17:40:05.998107_zrnc
    • 2024-07-01_17:40:05.998114_CMzi
    • 2024-07-01_17:40:05.998121_wYID
    • 2024-07-01_17:40:05.998128_CIQo
    • 2024-07-01_17:40:05.998135_jUwf
    • 2024-07-01_17:40:05.998141_LfzZ
    • 2024-07-01_17:40:05.998148_ZlWN
    • 2024-07-01_17:40:05.998155_seRz
    redfin-30
    Percentileb4b096bcd5989fDiffSignificant (?)
    p1014.1 ±5 ms14.8 ±6 ms+739 μs (+5.3%)NO
    p2514.8 ±6 ms15.6 ±7 ms+782 μs (+5.3%)NO
    p5015.9 ±6 ms16.6 ±8 ms+706 μs (+4.4%)NO
    p7517.2 ±7 ms17.8 ±8 ms+687 μs (+4.0%)NO
    p9018.9 ±7 ms20.0 ±9 ms+1.13 ms (+6.0%)NO

    20 test runs in comparison
    CommitTest Runs
    b4b096b
    • 2024-06-28_16:25:54.390976_oqrt
    • 2024-06-28_16:25:54.391032_dVvV
    • 2024-06-28_16:25:54.391042_BiAz
    • 2024-06-28_16:25:54.391050_dGvj
    • 2024-06-28_16:25:54.391057_HTyQ
    • 2024-06-28_16:25:54.391064_SiXR
    • 2024-06-28_16:25:54.391071_dDAt
    • 2024-06-28_16:25:54.391077_OcXT
    • 2024-06-28_16:25:54.391084_hhYt
    • 2024-06-28_16:25:54.391097_ceci
    cd5989f
    • 2024-07-01_17:40:05.998049_rWSk
    • 2024-07-01_17:40:05.998096_XfFf
    • 2024-07-01_17:40:05.998107_zrnc
    • 2024-07-01_17:40:05.998114_CMzi
    • 2024-07-01_17:40:05.998121_wYID
    • 2024-07-01_17:40:05.998128_CIQo
    • 2024-07-01_17:40:05.998135_jUwf
    • 2024-07-01_17:40:05.998141_LfzZ
    • 2024-07-01_17:40:05.998148_ZlWN
    • 2024-07-01_17:40:05.998155_seRz
  • fire-rc

    DeviceStatisticsDistributions
    oriole-32
    Percentileb4b096bcd5989fDiffSignificant (?)
    p10270 ±537 μs100 ±56 μs-170 μs (-63.0%)NO
    p25282 ±556 μs106 ±59 μs-176 μs (-62.4%)NO
    p50306 ±594 μs118 ±73 μs-188 μs (-61.4%)NO
    p75355 ±664 μs144 ±90 μs-211 μs (-59.4%)NO
    p90420 ±777 μs183 ±93 μs-237 μs (-56.4%)NO

    20 test runs in comparison
    CommitTest Runs
    b4b096b
    • 2024-06-28_16:25:54.390976_oqrt
    • 2024-06-28_16:25:54.391032_dVvV
    • 2024-06-28_16:25:54.391042_BiAz
    • 2024-06-28_16:25:54.391050_dGvj
    • 2024-06-28_16:25:54.391057_HTyQ
    • 2024-06-28_16:25:54.391064_SiXR
    • 2024-06-28_16:25:54.391071_dDAt
    • 2024-06-28_16:25:54.391077_OcXT
    • 2024-06-28_16:25:54.391084_hhYt
    • 2024-06-28_16:25:54.391097_ceci
    cd5989f
    • 2024-07-01_17:40:05.998049_rWSk
    • 2024-07-01_17:40:05.998096_XfFf
    • 2024-07-01_17:40:05.998107_zrnc
    • 2024-07-01_17:40:05.998114_CMzi
    • 2024-07-01_17:40:05.998121_wYID
    • 2024-07-01_17:40:05.998128_CIQo
    • 2024-07-01_17:40:05.998135_jUwf
    • 2024-07-01_17:40:05.998141_LfzZ
    • 2024-07-01_17:40:05.998148_ZlWN
    • 2024-07-01_17:40:05.998155_seRz
    redfin-30
    Percentileb4b096bcd5989fDiffSignificant (?)
    p10565 ±634 μs401 ±324 μs-164 μs (-29.0%)NO
    p25657 ±746 μs499 ±447 μs-158 μs (-24.1%)NO
    p50830 ±913 μs682 ±663 μs-147 μs (-17.8%)NO
    p751.00 ±1 ms851 ±836 μs-152 μs (-15.1%)NO
    p901.28 ±1 ms1.20 ±1 ms-81.3 μs (-6.4%)NO

    20 test runs in comparison
    CommitTest Runs
    b4b096b
    • 2024-06-28_16:25:54.390976_oqrt
    • 2024-06-28_16:25:54.391032_dVvV
    • 2024-06-28_16:25:54.391042_BiAz
    • 2024-06-28_16:25:54.391050_dGvj
    • 2024-06-28_16:25:54.391057_HTyQ
    • 2024-06-28_16:25:54.391064_SiXR
    • 2024-06-28_16:25:54.391071_dDAt
    • 2024-06-28_16:25:54.391077_OcXT
    • 2024-06-28_16:25:54.391084_hhYt
    • 2024-06-28_16:25:54.391097_ceci
    cd5989f
    • 2024-07-01_17:40:05.998049_rWSk
    • 2024-07-01_17:40:05.998096_XfFf
    • 2024-07-01_17:40:05.998107_zrnc
    • 2024-07-01_17:40:05.998114_CMzi
    • 2024-07-01_17:40:05.998121_wYID
    • 2024-07-01_17:40:05.998128_CIQo
    • 2024-07-01_17:40:05.998135_jUwf
    • 2024-07-01_17:40:05.998141_LfzZ
    • 2024-07-01_17:40:05.998148_ZlWN
    • 2024-07-01_17:40:05.998155_seRz
  • fire-sessions

    DeviceStatisticsDistributions
    oriole-32
    Percentileb4b096bcd5989fDiffSignificant (?)
    p103.01 ±0.9 ms2.63 ±0.6 ms-381 μs (-12.7%)NO
    p253.20 ±0.9 ms2.80 ±0.6 ms-402 μs (-12.6%)NO
    p503.57 ±1 ms3.14 ±0.7 ms-430 μs (-12.1%)NO
    p754.12 ±1 ms3.72 ±0.7 ms-398 μs (-9.7%)NO
    p904.99 ±1 ms4.32 ±0.8 ms-670 μs (-13.4%)NO

    20 test runs in comparison
    CommitTest Runs
    b4b096b
    • 2024-06-28_16:25:54.390976_oqrt
    • 2024-06-28_16:25:54.391032_dVvV
    • 2024-06-28_16:25:54.391042_BiAz
    • 2024-06-28_16:25:54.391050_dGvj
    • 2024-06-28_16:25:54.391057_HTyQ
    • 2024-06-28_16:25:54.391064_SiXR
    • 2024-06-28_16:25:54.391071_dDAt
    • 2024-06-28_16:25:54.391077_OcXT
    • 2024-06-28_16:25:54.391084_hhYt
    • 2024-06-28_16:25:54.391097_ceci
    cd5989f
    • 2024-07-01_17:40:05.998049_rWSk
    • 2024-07-01_17:40:05.998096_XfFf
    • 2024-07-01_17:40:05.998107_zrnc
    • 2024-07-01_17:40:05.998114_CMzi
    • 2024-07-01_17:40:05.998121_wYID
    • 2024-07-01_17:40:05.998128_CIQo
    • 2024-07-01_17:40:05.998135_jUwf
    • 2024-07-01_17:40:05.998141_LfzZ
    • 2024-07-01_17:40:05.998148_ZlWN
    • 2024-07-01_17:40:05.998155_seRz
    redfin-30
    Percentileb4b096bcd5989fDiffSignificant (?)
    p105.86 ±0.6 ms6.64 ±1 ms+778 μs (+13.3%)NO
    p256.21 ±0.7 ms7.27 ±2 ms+1.06 ms (+17.0%)NO
    p506.70 ±0.9 ms8.13 ±2 ms+1.42 ms (+21.2%)NO
    p757.28 ±1 ms9.34 ±4 ms+2.06 ms (+28.3%)NO
    p908.38 ±2 ms11.3 ±5 ms+2.89 ms (+34.5%)NO

    20 test runs in comparison
    CommitTest Runs
    b4b096b
    • 2024-06-28_16:25:54.390976_oqrt
    • 2024-06-28_16:25:54.391032_dVvV
    • 2024-06-28_16:25:54.391042_BiAz
    • 2024-06-28_16:25:54.391050_dGvj
    • 2024-06-28_16:25:54.391057_HTyQ
    • 2024-06-28_16:25:54.391064_SiXR
    • 2024-06-28_16:25:54.391071_dDAt
    • 2024-06-28_16:25:54.391077_OcXT
    • 2024-06-28_16:25:54.391084_hhYt
    • 2024-06-28_16:25:54.391097_ceci
    cd5989f
    • 2024-07-01_17:40:05.998049_rWSk
    • 2024-07-01_17:40:05.998096_XfFf
    • 2024-07-01_17:40:05.998107_zrnc
    • 2024-07-01_17:40:05.998114_CMzi
    • 2024-07-01_17:40:05.998121_wYID
    • 2024-07-01_17:40:05.998128_CIQo
    • 2024-07-01_17:40:05.998135_jUwf
    • 2024-07-01_17:40:05.998141_LfzZ
    • 2024-07-01_17:40:05.998148_ZlWN
    • 2024-07-01_17:40:05.998155_seRz
  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentileb4b096bcd5989fDiffSignificant (?)
    p10200 ±6 ms203 ±3 ms+3.30 ms (+1.7%)NO
    p25206 ±8 ms208 ±3 ms+2.49 ms (+1.2%)NO
    p50214 ±12 ms216 ±3 ms+2.73 ms (+1.3%)NO
    p75224 ±20 ms224 ±3 ms-386 μs (-0.2%)NO
    p90233 ±23 ms234 ±5 ms+888 μs (+0.4%)NO

    20 test runs in comparison
    CommitTest Runs
    b4b096b
    • 2024-06-28_16:25:54.390976_oqrt
    • 2024-06-28_16:25:54.391032_dVvV
    • 2024-06-28_16:25:54.391042_BiAz
    • 2024-06-28_16:25:54.391050_dGvj
    • 2024-06-28_16:25:54.391057_HTyQ
    • 2024-06-28_16:25:54.391064_SiXR
    • 2024-06-28_16:25:54.391071_dDAt
    • 2024-06-28_16:25:54.391077_OcXT
    • 2024-06-28_16:25:54.391084_hhYt
    • 2024-06-28_16:25:54.391097_ceci
    cd5989f
    • 2024-07-01_17:40:05.998049_rWSk
    • 2024-07-01_17:40:05.998096_XfFf
    • 2024-07-01_17:40:05.998107_zrnc
    • 2024-07-01_17:40:05.998114_CMzi
    • 2024-07-01_17:40:05.998121_wYID
    • 2024-07-01_17:40:05.998128_CIQo
    • 2024-07-01_17:40:05.998135_jUwf
    • 2024-07-01_17:40:05.998141_LfzZ
    • 2024-07-01_17:40:05.998148_ZlWN
    • 2024-07-01_17:40:05.998155_seRz
    redfin-30
    Percentileb4b096bcd5989fDiffSignificant (?)
    p10246 ±12 ms262 ±3 ms+16.1 ms (+6.5%)NO
    p25252 ±12 ms267 ±3 ms+15.5 ms (+6.2%)NO
    p50259 ±14 ms274 ±3 ms+15.0 ms (+5.8%)NO
    p75268 ±19 ms282 ±4 ms+14.4 ms (+5.4%)NO
    p90281 ±29 ms295 ±5 ms+14.2 ms (+5.1%)NO

    20 test runs in comparison
    CommitTest Runs
    b4b096b
    • 2024-06-28_16:25:54.390976_oqrt
    • 2024-06-28_16:25:54.391032_dVvV
    • 2024-06-28_16:25:54.391042_BiAz
    • 2024-06-28_16:25:54.391050_dGvj
    • 2024-06-28_16:25:54.391057_HTyQ
    • 2024-06-28_16:25:54.391064_SiXR
    • 2024-06-28_16:25:54.391071_dDAt
    • 2024-06-28_16:25:54.391077_OcXT
    • 2024-06-28_16:25:54.391084_hhYt
    • 2024-06-28_16:25:54.391097_ceci
    cd5989f
    • 2024-07-01_17:40:05.998049_rWSk
    • 2024-07-01_17:40:05.998096_XfFf
    • 2024-07-01_17:40:05.998107_zrnc
    • 2024-07-01_17:40:05.998114_CMzi
    • 2024-07-01_17:40:05.998121_wYID
    • 2024-07-01_17:40:05.998128_CIQo
    • 2024-07-01_17:40:05.998135_jUwf
    • 2024-07-01_17:40:05.998141_LfzZ
    • 2024-07-01_17:40:05.998148_ZlWN
    • 2024-07-01_17:40:05.998155_seRz

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/QMGzFkPkxR/index.html

@mrober
Copy link
Contributor

mrober commented Jul 2, 2024

We can't just change the path, we have to make a v3 so the sdk can clean up old files. So useV2FileSystem() becomes useV3FileSystem(), and the cleanupPreviousFileSystems needs to clean up v1 and v2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants