Skip to content

VertexAI: make FunctionCallPart.args nullable #6106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tanzimfh
Copy link
Contributor

@tanzimfh tanzimfh commented Jul 17, 2024

FunctionCall.args is an optional field in the proto.

Requires google-gemini/deprecated-generative-ai-android#207 to be released.

Copy link
Contributor

github-actions bot commented Jul 17, 2024

Release note changes

The following release notes were modified. Please ensure they look correct.

Release Notes
firebase-vertexai
### {{firebase_vertexai}} version 16.0.0-beta04 {: #vertex-ai_v16-0-0-beta04}

* {{feature}} added support for `responseSchema` in `GenerationConfig`.

* {{changed}} Made `FunctionCallPart.args` nullable.

@tanzimfh tanzimfh force-pushed the tanzim/nullable branch 2 times, most recently from 0aaf478 to 18da7b4 Compare July 17, 2024 02:48
Copy link
Contributor

github-actions bot commented Jul 17, 2024

Unit Test Results

0 files   -     4  0 suites   - 4   0s ⏱️ -3s
0 tests  -   50  0 ✔️  -   50  0 💤 ±0  0 ±0 
0 runs   - 100  0 ✔️  - 100  0 💤 ±0  0 ±0 

Results for commit 4823bbf. ± Comparison against base commit 9017c35.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-vertexai

    TypeBase (a41af7d)Merge (4d609dd)Diff
    aar161 kB161 kB-53 B (-0.0%)
    apk (aggressive)1.32 MB1.32 MB+112 B (+0.0%)
    apk (release)9.32 MB9.32 MB+104 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/BEjN5fuaET.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 17, 2024

Coverage Report 1

Affected Products

No changes between base commit (9017c35) and merge commit (88bd7cf).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/KDVtnhSZMS.html

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

The report is too large (122,624 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/RTXreGhD87/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants