-
Notifications
You must be signed in to change notification settings - Fork 608
feat: Instant
support
#6235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: Instant
support
#6235
Conversation
Following up. @tom-andersen, I just realized you requested that I tag you here. |
@tom-andersen, the latest test failures seem to be unrelated to my change, and this branch is fully caught-up. |
Thanks! I will copy the branch over to make the CI run properly. I will also need to understand how this is backward compatible. |
Thanks.
The same way googleapis/java-firestore#1586 was. |
Consider adding support for https://kotlinlang.org/api/kotlinx-datetime/kotlinx-datetime/kotlinx.datetime/-instant/ |
Done. Also added tests. |
@@ -142,6 +142,7 @@ dependencies { | |||
implementation libs.grpc.stub | |||
implementation libs.kotlin.stdlib | |||
implementation libs.kotlinx.coroutines.core | |||
implementation libs.kotlinx.datetime |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change this dependency to "compileOnly" so we don't unnecessarily pull in a dependency on the kotlinx.datetime library if it's not used by the downstream dependent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Add support for
java.time.Instant
as a timestamp type.This is a port of googleapis/java-firestore#1586.