Skip to content

feat: Instant support #6235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

feat: Instant support #6235

wants to merge 11 commits into from

Conversation

eranl
Copy link

@eranl eranl commented Sep 7, 2024

Add support for java.time.Instant as a timestamp type.
This is a port of googleapis/java-firestore#1586.

@eranl
Copy link
Author

eranl commented Apr 16, 2025

Following up. @tom-andersen, I just realized you requested that I tag you here.

@tom-andersen tom-andersen self-assigned this Apr 18, 2025
@eranl
Copy link
Author

eranl commented Apr 18, 2025

@tom-andersen, the latest test failures seem to be unrelated to my change, and this branch is fully caught-up.

@tom-andersen
Copy link
Contributor

tom-andersen commented Apr 22, 2025

Thanks! I will copy the branch over to make the CI run properly.

I will also need to understand how this is backward compatible.

@eranl
Copy link
Author

eranl commented Apr 22, 2025

Thanks! I will copy the branch over to make the CI run properly.

Thanks.

I will also need to understand how this is backward compatible.

The same way googleapis/java-firestore#1586 was.

@dconeybe
Copy link
Contributor

Consider adding support for kotlinx.datetime.Instant as well.

https://kotlinlang.org/api/kotlinx-datetime/kotlinx-datetime/kotlinx.datetime/-instant/

@eranl
Copy link
Author

eranl commented Apr 24, 2025

Consider adding support for kotlinx.datetime.Instant as well.

Done. Also added tests.

@@ -142,6 +142,7 @@ dependencies {
implementation libs.grpc.stub
implementation libs.kotlin.stdlib
implementation libs.kotlinx.coroutines.core
implementation libs.kotlinx.datetime
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change this dependency to "compileOnly" so we don't unnecessarily pull in a dependency on the kotlinx.datetime library if it's not used by the downstream dependent.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants