Skip to content

update headers in the correct location #6948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2025
Merged

update headers in the correct location #6948

merged 1 commit into from
May 8, 2025

Conversation

VinayGuthal
Copy link
Contributor

No description provided.

@VinayGuthal VinayGuthal requested a review from daymxn May 8, 2025 19:31
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 8, 2025 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@VinayGuthal VinayGuthal enabled auto-merge (squash) May 8, 2025 19:32
@google-oss-bot
Copy link
Contributor

1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

daymxn
daymxn approved these changes May 8, 2025
View reviewed changes
Copy link
Member

@daymxn daymxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we revert the vertexai one too?

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

No changes between base commit (78360ad) and merge commit (2871497).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/gRH6ban5gL.html

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 8, 2025

Test Results

 22 files  + 22   22 suites  +22   34s ⏱️ +34s
100 tests +100  100 ✅ +100  0 💤 ±0  0 ❌ ±0 
200 runs  +200  200 ✅ +200  0 💤 ±0  0 ❌ ±0 

Results for commit 416b709. ± Comparison against base commit 78360ad.

@VinayGuthal VinayGuthal merged commit 2a17764 into main May 8, 2025
33 checks passed
@VinayGuthal VinayGuthal deleted the update_headers_correctly branch May 8, 2025 19:40
@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-ai

    TypeBase (78360ad)Merge (2871497)Diff
    aar819 kB819 kB+25 B (+0.0%)
    apk (release)9.52 MB9.52 MB+4 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/TGXCTPEa4X.html

@daymxn daymxn mentioned this pull request May 8, 2025
Merged
daymxn added a commit that referenced this pull request May 9, 2025
@daymxn
Revert "Update headers to track vertex ai/developer usage in kotlin (… (
eee76b4 
#6949)

This reverts commit #6944.

The change was meant to be for `firebase-ai`, which we corrected with
#6948.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daymxn daymxn daymxn approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VinayGuthal @google-oss-bot @daymxn