Skip to content

Implement new cold app start detection heuristic #6950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 9, 2025
Merged

Implement new cold app start detection heuristic #6950

merged 3 commits into from
May 9, 2025

Conversation

mrober
Copy link
Contributor

@mrober mrober commented May 9, 2025

Implement new cold app start detection heuristic.

This is just the reading part, and all the scaffolding. Next step will be to start writing the process data map.

Tested by unit tests and manual testing with the sessions test app

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 9, 2025

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v13.0

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 9, 2025 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-sessions

    Overall coverage changed from ? (c24f04a) to 81.66% (3af3441) by ?.

    47 individual files with coverage change

    FilenameBase (c24f04a)Merge (3af3441)Diff
    ApplicationInfo.kt?100.00%?
    AutoSessionEventEncoder.java?100.00%?
    DaggerFirebaseSessionsComponent.java?94.23%?
    EventGDTLogger.kt?70.00%?
    EventGDTLogger_Factory.java?0.00%?
    FirebaseSessions.kt?53.57%?
    FirebaseSessionsComponent.kt?65.79%?
    FirebaseSessionsComponent_MainModule_Companion_ApplicationInfoFactory.java?0.00%?
    FirebaseSessionsComponent_MainModule_Companion_SessionConfigsDataStoreFactory.java?0.00%?
    FirebaseSessionsComponent_MainModule_Companion_SessionDataStoreFactory.java?0.00%?
    FirebaseSessionsComponent_MainModule_Companion_TimeProviderFactory.java?100.00%?
    FirebaseSessionsComponent_MainModule_Companion_UuidGeneratorFactory.java?100.00%?
    FirebaseSessionsDependencies.kt?85.71%?
    FirebaseSessionsRegistrar.kt?90.91%?
    FirebaseSessions_Factory.java?0.00%?
    InstallationId.kt?100.00%?
    LocalOverrideSettings.kt?100.00%?
    LocalOverrideSettings_Factory.java?0.00%?
    ProcessDataManager.kt?62.50%?
    ProcessDataManagerImpl_Factory.java?0.00%?
    ProcessDetailsProvider.kt?76.67%?
    RemoteSettings.kt?88.41%?
    RemoteSettingsFetcher.kt?10.00%?
    RemoteSettingsFetcher_Factory.java?0.00%?
    RemoteSettings_Factory.java?0.00%?
    SessionConfigs.kt?95.45%?
    SessionData.kt?58.82%?
    SessionDataSerializer_Factory.java?0.00%?
    SessionDetails.kt?85.71%?
    SessionEvent.kt?100.00%?
    SessionEvents.kt?98.00%?
    SessionFirelogPublisher.kt?83.33%?
    SessionFirelogPublisherImpl_Factory.java?0.00%?
    SessionGenerator.kt?100.00%?
    SessionGenerator_Factory.java?0.00%?
    SessionsActivityLifecycleCallbacks.kt?18.75%?
    SessionsActivityLifecycleCallbacks_Factory.java?0.00%?
    SessionsSettings.kt?93.75%?
    SessionsSettings_Factory.java?0.00%?
    SessionSubscriber.kt?75.00%?
    SettingsCache.kt?80.56%?
    SettingsCacheImpl_Factory.java?0.00%?
    SettingsProvider.kt?50.00%?
    SharedSessionRepository.kt?82.98%?
    SharedSessionRepositoryImpl_Factory.java?0.00%?
    TimeProvider.kt?75.00%?
    UuidGenerator.kt?100.00%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/naWdGbkVoY.html

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 9, 2025 •
edited
Loading

Test Results

 38 files   38 suites   46s ⏱️
 83 tests  83 ✅ 0 💤 0 ❌
166 runs  166 ✅ 0 💤 0 ❌

Results for commit 833211e.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 9, 2025 •
edited
Loading

Size Report 1

Affected Products

  • base

    TypeBase (c24f04a)Merge (3af3441)Diff
    apk (aggressive)?8.80 kB? (?)
    apk (release)?9.77 kB? (?)

  • firebase-sessions

    TypeBase (c24f04a)Merge (3af3441)Diff
    aar?217 kB? (?)
    apk (aggressive)?538 kB? (?)
    apk (release)?5.79 MB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/qPG7EK6qGk.html

@44Sergeipakudin
Copy link

firebase-sessions/src/main/kotlin/com/google/firebase/sessions/ProcessDataManager.kt

@mrober mrober merged commit 97de840 into sessions-sharedrepo May 9, 2025
32 checks passed
@mrober mrober deleted the mrober/coldstart branch May 9, 2025 19:37
mrober added a commit that referenced this pull request May 12, 2025
@mrober
Implement new cold app start detection heuristic (#6950)
7aa927d 
Implement new cold app start detection heuristic.

This is just the reading part, and all the scaffolding. Next step will
be to start writing the process data map.

Tested by unit tests and manual testing with the sessions test app
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tejasd tejasd tejasd approved these changes

@44Sergeipakudin 44Sergeipakudin 44Sergeipakudin approved these changes

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mrober @google-oss-bot @44Sergeipakudin @tejasd