Skip to content

Add Firebase AI to recipe version generation #6951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 9, 2025
Merged

Conversation

daymxn
Copy link
Member

@daymxn daymxn commented May 9, 2025

Per b/416734504,

This updates the GenerateTutorialBundleTask that we use to generate the tutorial bundle versions (recipe versions) to support firebase-ai. More specifically, it replaces the existing firebase-vertexai entry in the process.

While this PR removes firebase-vertexai from the tutorial bundle, it does not remove it from the BoM. That will be a breaking change we'll make down the road.

@daymxn daymxn requested a review from rlazo May 9, 2025 17:42
@daymxn daymxn self-assigned this May 9, 2025
Copy link
Contributor

github-actions bot commented May 9, 2025

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@daymxn daymxn enabled auto-merge (squash) May 9, 2025 17:42
Copy link
Contributor

github-actions bot commented May 9, 2025

Test Results

 1 056 files  + 1 038   1 056 suites  +1 038   36m 15s ⏱️ + 35m 40s
 5 976 tests + 5 888   5 954 ✅ + 5 866  22 💤 +22  0 ❌ ±0 
12 015 runs  +11 839  11 971 ✅ +11 795  44 💤 +44  0 ❌ ±0 

Results for commit 56ab9ad. ± Comparison against base commit eee76b4.

@google-oss-bot
Copy link
Contributor

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.22% (eee76b4) to 50.16% (3f1fa47) by -0.05%.

    FilenameBase (eee76b4)Merge (3f1fa47)Diff
    ChildChangeAccumulator.java96.67%83.33%-13.33%
    WriteTree.java77.22%76.67%-0.56%
  • firebase-messaging

    Overall coverage changed from 84.10% (eee76b4) to 84.02% (3f1fa47) by -0.07%.

    FilenameBase (eee76b4)Merge (3f1fa47)Diff
    FirebaseMessaging.java75.60%76.00%+0.40%
    Metadata.java41.27%36.51%-4.76%
  • firebase-ml-modeldownloader

    Overall coverage changed from 82.11% (eee76b4) to 81.86% (3f1fa47) by -0.25%.

    FilenameBase (eee76b4)Merge (3f1fa47)Diff
    FirebaseModelDownloader.java84.66%82.21%-2.45%
  • firebase-perf

    Overall coverage changed from 70.64% (eee76b4) to 70.61% (3f1fa47) by -0.03%.

    FilenameBase (eee76b4)Merge (3f1fa47)Diff
    TransportManager.java94.88%93.95%-0.93%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/yOLut8VNHj.html

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

The report is too large (122,572 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/LurMplDgeH/index.html

@daymxn daymxn merged commit 1e2e2c1 into main May 9, 2025
269 of 271 checks passed
@daymxn daymxn deleted the daymon-add-fai-to-recipe branch May 9, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants