Skip to content

[action] Only include merge message on sdk changes #6955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2025
Merged

Conversation

rlazo
Copy link
Collaborator

@rlazo rlazo commented May 10, 2025

The "Merge to main" workflow adds a comment to the PR so authors know that their changes shouldn't break the main branch, as it should always remain stable and releasable. This only makes sense when the change affects an SDK, as only those get released. Now we filter the message so it doesn't spam PRs that only touch infra (plugin & github folders)

The "Merge to main" workflow adds a comment to the PR so authors know
that their changes shouldn't break the main branch, as it should
always remain stable and releasable. This only makes sense when the
change affects an SDK, as only those get released. Now we filter the
message so it doesn't spam PRs that only touch infra (plugin & github
folders)
@rlazo rlazo requested a review from daymxn May 10, 2025 03:22
Copy link
Contributor

github-actions bot commented May 10, 2025

Test Results

 1 094 files  + 38   1 094 suites  +38   36m 45s ⏱️ +5s
 5 976 tests ±  0   5 953 ✅ ±  0  22 💤 ±0  1 ❌ ±0 
12 663 runs  +648  12 618 ✅ +648  44 💤 ±0  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit 17565f8. ± Comparison against base commit 1e2e2c1.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.16% (1e2e2c1) to 50.21% (cbdf983) by +0.04%.

    FilenameBase (1e2e2c1)Merge (cbdf983)Diff
    ChildChangeAccumulator.java83.33%96.67%+13.33%
  • firebase-storage

    Overall coverage changed from 83.96% (1e2e2c1) to 84.33% (cbdf983) by +0.37%.

    FilenameBase (1e2e2c1)Merge (cbdf983)Diff
    StorageException.java65.45%69.09%+3.64%
    StorageTask.java83.38%83.99%+0.60%
    UploadTask.java81.52%83.17%+1.65%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/p7TMONcOGB.html

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

The report is too large (122,564 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/7mjvfEmnaY/index.html

@rlazo rlazo merged commit 24cc366 into main May 11, 2025
423 of 428 checks passed
@rlazo rlazo deleted the rl.action.filter branch May 11, 2025 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants