Skip to content

fix(ai): pass FunctionDeclaration#description arg to internal class #6957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 20, 2025

Conversation

thatfiredev
Copy link
Member

@thatfiredev thatfiredev commented May 13, 2025

It seems like the value set in FunctionDeclaration#description was never making it to the API.

Aside: I wonder if this is why some function calls would sometimes fail (ie. the model wouldn't know which function to call) Nevermind, I found a bug in the implementation I was testing with.

@thatfiredev thatfiredev requested review from rlazo and davidmotson May 13, 2025 11:05
Copy link
Contributor

github-actions bot commented May 13, 2025

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Copy link
Contributor

github-actions bot commented May 13, 2025

Test Results

 24 files   -   168   24 suites   - 168   35s ⏱️ - 9m 26s
102 tests  - 1 098  102 ✅  - 1 097  0 💤  - 1  0 ❌ ±0 
204 runs   - 2 228  204 ✅  - 2 226  0 💤  - 2  0 ❌ ±0 

Results for commit 332c6f4. ± Comparison against base commit 331905b.

This pull request removes 1100 and adds 2 tests. Note that renamed tests count towards both.
com.google.firebase.appcheck.debug.testing.DebugAppCheckTestHelperTest ‑ testDebugAppCheckTestHelper_withDebugProviderDefaultApp_installsDebugProvider
com.google.firebase.appcheck.debug.testing.DebugAppCheckTestHelperTest ‑ testDebugAppCheckTestHelper_withDebugProviderNamedApp_installsDebugProvider
com.google.firebase.appcheck.debug.testing.DebugAppCheckTestHelperTest ‑ testDebugAppCheckTestHelper_withDebugProvider_noPreviousProvider_installsDebugProvider
com.google.firebase.appcheck.debug.testing.FirebaseAppCheckDebugTestingRegistrarTest ‑ testGetComponents
com.google.firebase.dataconnect.AnyValueSerializerUnitTest ‑ descriptor should have expected values
com.google.firebase.dataconnect.AnyValueSerializerUnitTest ‑ deserialize() should throw UnsupportedOperationException
com.google.firebase.dataconnect.AnyValueSerializerUnitTest ‑ serialize() should throw UnsupportedOperationException
com.google.firebase.dataconnect.AnyValueUnitTest ‑ constructor(Boolean) creates an object with the expected value
com.google.firebase.dataconnect.AnyValueUnitTest ‑ constructor(Double) creates an object with the expected value (edge cases)
com.google.firebase.dataconnect.AnyValueUnitTest ‑ constructor(Double) creates an object with the expected value (normal cases)
…
com.google.firebase.ai.type.FunctionDeclarationTest ‑ Basic FunctionDeclaration with name, description and parameters
com.google.firebase.ai.type.FunctionDeclarationTest ‑ FunctionDeclaration with optional parameters

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 13, 2025

Coverage Report 1

Affected Products

No changes between base commit (331905b) and merge commit (7830f83).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/PRBCDHjjqx.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 13, 2025

@thatfiredev thatfiredev enabled auto-merge (squash) May 20, 2025 17:07
@thatfiredev thatfiredev merged commit 9c00477 into main May 20, 2025
32 checks passed
@thatfiredev thatfiredev deleted the rpf-wire-function-declaration-description branch May 20, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants