Skip to content

Add macrobenchmark module for sessions test app #6982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2025
Merged

Conversation

mrober
Copy link
Contributor

@mrober mrober commented May 22, 2025

Add macrobenchmark module for sessions test app. This is just the setup and the example startup benchmark. I will add more in the PerfAQS project, and write instructions in the readme then.

Copy link
Contributor

github-actions bot commented May 22, 2025

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

Copy link
Contributor

github-actions bot commented May 22, 2025

Test Results

 1 058 files  ±0   1 058 suites  ±0   36m 4s ⏱️ +26s
 5 978 tests ±0   5 956 ✅ ±0  22 💤 ±0  0 ❌ ±0 
12 019 runs  ±0  11 975 ✅ ±0  44 💤 ±0  0 ❌ ±0 

Results for commit 489df8d. ± Comparison against base commit 61d972c.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

Copy link
Contributor

@tejasd tejasd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on a sanity check - ./gradlew :firebase-sessions:benchmark:connectedCheck

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-database

    Overall coverage changed from 50.21% (61d972c) to 50.22% (b0b62f1) by +0.01%.

    FilenameBase (61d972c)Merge (b0b62f1)Diff
    QueryParams.java89.76%90.36%+0.60%
  • firebase-sessions

    Overall coverage changed from 66.56% (61d972c) to 66.67% (b0b62f1) by +0.11%.

    FilenameBase (61d972c)Merge (b0b62f1)Diff
    RemoteSettings.kt87.32%88.73%+1.41%
  • firebase-firestore

    FilenameBase (61d972c)Merge (b0b62f1)Diff
    PatchMutation.java98.39%100.00%+1.61%
    SetMutation.java97.22%94.44%-2.78%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/cNKJffhO6G.html

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

The report is too large (122,559 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/sNfoa8ZCzQ/index.html

@mrober mrober merged commit 9f5839f into main May 22, 2025
269 of 270 checks passed
@mrober mrober deleted the mrober/sessions-benchmark branch May 22, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants