Skip to content

Remove the copy of Guava Function interface #6983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Remove the copy of Guava Function interface #6983

wants to merge 3 commits into from

Conversation

tom-andersen
Copy link
Contributor

@tom-andersen tom-andersen commented May 22, 2025 •
edited
Loading

Since Guava version now supports Function interface, there is no longer a reason to have a copy in Firestore.

@tom-andersen
fix: Remove the copy of Function interface, and instead make use of t…
d2bfa55 
…he Function interface now offered as part of minimum API version.
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 22, 2025 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@tom-andersen tom-andersen changed the title fix: Remove the copy of Function interface, and instead make use of t… fix: Remove the copy of Guava Function interface May 22, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 22, 2025 •
edited
Loading

Test Results

  186 files  +  122    186 suites  +122   4m 34s ⏱️ + 2m 13s
1 235 tests +  916  1 219 ✅ +  901  16 💤 +15  0 ❌ ±0 
2 494 runs  +1 852  2 462 ✅ +1 822  32 💤 +30  0 ❌ ±0 

Results for commit da7f788. ± Comparison against base commit ec4b353.

This pull request removes 319 and adds 1235 tests. Note that renamed tests count towards both. 
com.google.firebase.inappmessaging.FirebaseInAppMessagingTest ‑ addClickListener_forwardsEventListenerRequestsToDeveloperListenerManager
com.google.firebase.inappmessaging.FirebaseInAppMessagingTest ‑ addDismissListener_forwardsEventListenerRequestsToDeveloperListenerManager
com.google.firebase.inappmessaging.FirebaseInAppMessagingTest ‑ addDisplayErrorListener_forwardsEventListenerRequestsToDeveloperListenerManager
com.google.firebase.inappmessaging.FirebaseInAppMessagingTest ‑ addImpressionListener_forwardsEventListenerRequestsToDeveloperListenerManager
com.google.firebase.inappmessaging.FirebaseInAppMessagingTest ‑ addRemoveAllListeners_WorksAsExpected
com.google.firebase.inappmessaging.FirebaseInAppMessagingTest ‑ addRemoveListeners_WorksAsExpected
com.google.firebase.inappmessaging.FirebaseInAppMessagingTest ‑ automaticDataCollectionDisabling_clearsInDataCollectionHelper
com.google.firebase.inappmessaging.FirebaseInAppMessagingTest ‑ automaticDataCollectionDisabling_disablesInDataCollectionHelper
com.google.firebase.inappmessaging.FirebaseInAppMessagingTest ‑ automaticDataCollectionEnabling_enablesInDataCollectionHelper
com.google.firebase.inappmessaging.FirebaseInAppMessagingTest ‑ clearDisplayListener_removesListener
…

com.google.firebase.firestore.AggregateQuerySnapshotTest ‑ createWithCountShouldReturnInstanceWithTheGivenQueryAndCount
com.google.firebase.firestore.AggregateQueryTest ‑ testSourceMustNotBeNull
com.google.firebase.firestore.BlobTest ‑ testComparison
com.google.firebase.firestore.BlobTest ‑ testEquals
com.google.firebase.firestore.BlobTest ‑ testMutableBytes
com.google.firebase.firestore.CollectionReferenceTest ‑ testEquals
com.google.firebase.firestore.DocumentChangeTest ‑ randomTests
com.google.firebase.firestore.DocumentChangeTest ‑ testAdditions
com.google.firebase.firestore.DocumentChangeTest ‑ testChangesWithSortOrderChange
com.google.firebase.firestore.DocumentChangeTest ‑ testDeletions
…
This pull request removes 1 skipped test and adds 16 skipped tests. Note that renamed tests count towards both. 
com.google.firebase.inappmessaging.display.FirebaseInAppMessagingDisplayTest ‑ streamListener_onNotifiedCard_showsCardMessage

com.google.firebase.firestore.FirestoreRegistrarTest ‑ storageRegistrar_getComponents_publishesLibVersionComponent
com.google.firebase.firestore.local.MemoryLocalStoreTest ‑ testDoesNotReplaceResumeTokenWithEmptyByteString
com.google.firebase.firestore.local.MemoryLocalStoreTest ‑ testHandlesSetMutationThenAckThenTransformThenAckThenTransform
com.google.firebase.firestore.local.MemoryLocalStoreTest ‑ testIgnoresTargetMappingAfterExistenceFilterMismatch
com.google.firebase.firestore.local.MemoryLocalStoreTest ‑ testPersistsResumeTokens
com.google.firebase.firestore.local.MemoryLocalStoreTest ‑ testQueriesFilterDocumentsThatNoLongerMatch
com.google.firebase.firestore.local.MemoryLocalStoreTest ‑ testQueriesIncludeDocumentsFromOtherQueries
com.google.firebase.firestore.local.MemoryLocalStoreTest ‑ testQueriesIncludeLocallyModifiedDocuments
com.google.firebase.firestore.local.MemoryLocalStoreTest ‑ testUsesTargetMappingToExecuteQueries
com.google.firebase.firestore.local.SQLiteLocalStoreTest ‑ testCollectsGarbageAfterAcknowledgedMutation
…

♻️ This comment has been updated with latest results.

@tom-andersen tom-andersen requested a review from rlazo May 22, 2025 19:57
@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 45.77% (ec4b353) to 45.76% (367d7e9) by -0.01%.

    FilenameBase (ec4b353)Merge (367d7e9)Diff
    LruGarbageCollector.java97.27%93.64%-3.64%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/gjQjJLbVkT.html

@tom-andersen tom-andersen changed the title fix: Remove the copy of Guava Function interface Remove the copy of Guava Function interface May 22, 2025
@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-firestore

    TypeBase (ec4b353)Merge (367d7e9)Diff
    aar1.45 MB1.45 MB-234 B (-0.0%)
    apk (release)11.4 MB11.4 MB-256 B (-0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/NvYN39a8wr.html

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-fst

    DeviceStatisticsDistributions
    oriole-32
    Percentileec4b353367d7e9DiffSignificant (?)
    p10258 ±14 μs260 ±8 μs+2.61 μs (+1.0%)NO
    p25268 ±15 μs269 ±9 μs+1.84 μs (+0.7%)NO
    p50288 ±30 μs293 ±26 μs+4.94 μs (+1.7%)NO
    p75348 ±71 μs354 ±78 μs+5.59 μs (+1.6%)NO
    p90405 ±107 μs442 ±117 μs+36.5 μs (+9.0%)NO

    20 test runs in comparison
    CommitTest Runs
    ec4b353
    • 2025-05-22_18:50:15.497154_NUXL
    • 2025-05-22_18:50:15.497195_oUaZ
    • 2025-05-22_18:50:15.497205_hrGe
    • 2025-05-22_18:50:15.497220_xqil
    • 2025-05-22_18:50:15.497228_czLQ
    • 2025-05-22_18:50:15.497235_HSoT
    • 2025-05-22_18:50:15.497242_tvEj
    • 2025-05-22_18:50:15.497248_QYyQ
    • 2025-05-22_18:50:15.497255_XThK
    • 2025-05-22_18:50:15.497262_ZLJp
    367d7e9
    • 2025-05-22_20:13:32.481232_TZYy
    • 2025-05-22_20:13:32.481284_ROoZ
    • 2025-05-22_20:13:32.481297_qRsn
    • 2025-05-22_20:13:32.481320_ihDj
    • 2025-05-22_20:13:32.481329_qaWd
    • 2025-05-22_20:13:32.481335_fMVk
    • 2025-05-22_20:13:32.481342_CRtw
    • 2025-05-22_20:13:32.481349_GqDq
    • 2025-05-22_20:13:32.481355_iZmX
    • 2025-05-22_20:13:32.481362_VJdG
    redfin-30
    Percentileec4b353367d7e9DiffSignificant (?)
    p10520 ±63 μs510 ±33 μs-9.99 μs (-1.9%)NO
    p25535 ±66 μs530 ±34 μs-5.03 μs (-0.9%)NO
    p50555 ±66 μs555 ±33 μs-672 ns (-0.1%)NO
    p75581 ±67 μs585 ±34 μs+4.49 μs (+0.8%)NO
    p90622 ±81 μs631 ±53 μs+8.59 μs (+1.4%)NO

    20 test runs in comparison
    CommitTest Runs
    ec4b353
    • 2025-05-22_18:50:15.497154_NUXL
    • 2025-05-22_18:50:15.497195_oUaZ
    • 2025-05-22_18:50:15.497205_hrGe
    • 2025-05-22_18:50:15.497220_xqil
    • 2025-05-22_18:50:15.497228_czLQ
    • 2025-05-22_18:50:15.497235_HSoT
    • 2025-05-22_18:50:15.497242_tvEj
    • 2025-05-22_18:50:15.497248_QYyQ
    • 2025-05-22_18:50:15.497255_XThK
    • 2025-05-22_18:50:15.497262_ZLJp
    367d7e9
    • 2025-05-22_20:13:32.481232_TZYy
    • 2025-05-22_20:13:32.481284_ROoZ
    • 2025-05-22_20:13:32.481297_qRsn
    • 2025-05-22_20:13:32.481320_ihDj
    • 2025-05-22_20:13:32.481329_qaWd
    • 2025-05-22_20:13:32.481335_fMVk
    • 2025-05-22_20:13:32.481342_CRtw
    • 2025-05-22_20:13:32.481349_GqDq
    • 2025-05-22_20:13:32.481355_iZmX
    • 2025-05-22_20:13:32.481362_VJdG

  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentileec4b353367d7e9DiffSignificant (?)
    p10199 ±5 ms200 ±4 ms+979 μs (+0.5%)NO
    p25204 ±5 ms206 ±4 ms+1.61 ms (+0.8%)NO
    p50212 ±5 ms214 ±4 ms+1.93 ms (+0.9%)NO
    p75219 ±5 ms222 ±5 ms+3.56 ms (+1.6%)NO
    p90225 ±6 ms234 ±9 ms+8.23 ms (+3.7%)NO

    20 test runs in comparison
    CommitTest Runs
    ec4b353
    • 2025-05-22_18:50:15.497154_NUXL
    • 2025-05-22_18:50:15.497195_oUaZ
    • 2025-05-22_18:50:15.497205_hrGe
    • 2025-05-22_18:50:15.497220_xqil
    • 2025-05-22_18:50:15.497228_czLQ
    • 2025-05-22_18:50:15.497235_HSoT
    • 2025-05-22_18:50:15.497242_tvEj
    • 2025-05-22_18:50:15.497248_QYyQ
    • 2025-05-22_18:50:15.497255_XThK
    • 2025-05-22_18:50:15.497262_ZLJp
    367d7e9
    • 2025-05-22_20:13:32.481232_TZYy
    • 2025-05-22_20:13:32.481284_ROoZ
    • 2025-05-22_20:13:32.481297_qRsn
    • 2025-05-22_20:13:32.481320_ihDj
    • 2025-05-22_20:13:32.481329_qaWd
    • 2025-05-22_20:13:32.481335_fMVk
    • 2025-05-22_20:13:32.481342_CRtw
    • 2025-05-22_20:13:32.481349_GqDq
    • 2025-05-22_20:13:32.481355_iZmX
    • 2025-05-22_20:13:32.481362_VJdG
    redfin-30
    Percentileec4b353367d7e9DiffSignificant (?)
    p10225 ±5 ms248 ±3 ms+22.6 ms (+10.0%)MAYBE
    p25232 ±5 ms255 ±2 ms+22.8 ms (+9.8%)MAYBE
    p50239 ±4 ms262 ±3 ms+23.1 ms (+9.7%)YES
    p75247 ±5 ms271 ±5 ms+24.0 ms (+9.7%)MAYBE
    p90257 ±6 ms284 ±9 ms+27.4 ms (+10.7%)MAYBE

    20 test runs in comparison
    CommitTest Runs
    ec4b353
    • 2025-05-22_18:50:15.497154_NUXL
    • 2025-05-22_18:50:15.497195_oUaZ
    • 2025-05-22_18:50:15.497205_hrGe
    • 2025-05-22_18:50:15.497220_xqil
    • 2025-05-22_18:50:15.497228_czLQ
    • 2025-05-22_18:50:15.497235_HSoT
    • 2025-05-22_18:50:15.497242_tvEj
    • 2025-05-22_18:50:15.497248_QYyQ
    • 2025-05-22_18:50:15.497255_XThK
    • 2025-05-22_18:50:15.497262_ZLJp
    367d7e9
    • 2025-05-22_20:13:32.481232_TZYy
    • 2025-05-22_20:13:32.481284_ROoZ
    • 2025-05-22_20:13:32.481297_qRsn
    • 2025-05-22_20:13:32.481320_ihDj
    • 2025-05-22_20:13:32.481329_qaWd
    • 2025-05-22_20:13:32.481335_fMVk
    • 2025-05-22_20:13:32.481342_CRtw
    • 2025-05-22_20:13:32.481349_GqDq
    • 2025-05-22_20:13:32.481355_iZmX
    • 2025-05-22_20:13:32.481362_VJdG

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/u1X7wtHWJi/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlazo rlazo Awaiting requested review from rlazo

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tom-andersen @google-oss-bot