dataconnect: testing: internal refactor of chain of "ifs" to a "when" expression

[dconeybe]

This PR slightly improves code readability and maintainability within the Data Connect unit testing suite by replacing a multi-conditional if-else if structure with a Kotlin when expression. No functional changes were made by this PR.

Highlights

• Refactoring: The pull request refactors a chain of if-else if statements into a more concise and readable when expression within the Value.hasNestedKind extension function.
• No Logic Change: This change is purely a refactoring and does not alter the existing logic or behavior of the unit test code.

Changelog

• protoUnitTest.kt
  • Converted an if-else if chain to a when expression in the Value.hasNestedKind function for improved readability.

[gemini-code-assist]

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

[github-actions]

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

[google-oss-bot]

Coverage Report ¹

Affected Products

No changes between base commit (6dab936) and merge commit (21930bf).

Test Logs

• Base (6dab936): https://github.com/firebase/firebase-android-sdk/actions/runs/20479270061
• Merge (21930bf): https://github.com/firebase/firebase-android-sdk/actions/runs/20663695088

1. https://storage.googleapis.com/firebase-sdk-metric-reports/dTGrQofFQL.html

[dconeybe]

/gemini review

[dconeybe]

/gemini summary

[gemini-code-assist]

Code Review

This pull request is a nice, small refactoring that improves code quality. It replaces a chain of if-else if expressions with a more idiomatic Kotlin when expression within a test file. This change, suggested by Android Studio, enhances readability without altering any logic. I have one minor suggestion to make the code even more concise.

[gemini-code-assist]

Summary of Changes

This pull request focuses on improving code readability and maintainability within the Data Connect unit testing suite. It replaces a multi-conditional if-else if structure with a Kotlin when expression, as suggested by Android Studio, without introducing any functional changes to the codebase.

Highlights

• Refactoring: The pull request refactors a chain of if-else if statements into a more concise and readable when expression within the Value.hasNestedKind extension function.
• No Logic Change: This change is purely a refactoring and does not alter the existing logic or behavior of the unit test code.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• firebase-dataconnect/testutil/src/test/kotlin/com/google/firebase/dataconnect/testutil/property/arbitrary/protoUnitTest.kt
  • Converted an if-else if chain to a when expression in the Value.hasNestedKind function for improved readability.

Activity

• gemini-code-assist[bot] provided information regarding the use of Gemini Code Assist.
• github-actions[bot] posted a reminder about merging into the main branch.
• google-oss-bot generated a coverage report, indicating no changes between base and merge commits.
• dconeybe invoked /gemini review and /gemini summary.
• gemini-code-assist[bot] suggested a minor improvement to remove the explicit this@hasNestedKind label for better conciseness.