adding tests

Author: Lyokone

example/basic/firebase.json

@@ -25,9 +25,15 @@
     "ui": {
       "enabled": true,
       "port": 4000
+    },
+    "storage": {
+      "port": 9199
     }
   },
   "database": {
     "rules": "database.rules.json"
+  },
+  "storage": {
+    "rules": "storage.rules"
   }
 }

example/basic/lib/main.dart

@@ -425,7 +425,7 @@ void main(List<String> args) async {
     // ==========================================================================
 
     // Storage onObjectFinalized - triggers when an object is created/overwritten
-    firebase.storage.onObjectFinalized(bucket: 'my-bucket', (event) async {
+    firebase.storage.onObjectFinalized(bucket: 'demo-test.firebasestorage.app', (event) async {
       final data = event.data;
       print('Object finalized in bucket: ${event.bucket}');
       print('  Name: ${data?.name}');
@@ -434,22 +434,22 @@ void main(List<String> args) async {
     });
 
     // Storage onObjectArchived - triggers when an object is archived
-    firebase.storage.onObjectArchived(bucket: 'my-bucket', (event) async {
+    firebase.storage.onObjectArchived(bucket: 'demo-test.firebasestorage.app', (event) async {
       final data = event.data;
       print('Object archived in bucket: ${event.bucket}');
       print('  Name: ${data?.name}');
       print('  Storage Class: ${data?.storageClass}');
     });
 
     // Storage onObjectDeleted - triggers when an object is deleted
-    firebase.storage.onObjectDeleted(bucket: 'my-bucket', (event) async {
+    firebase.storage.onObjectDeleted(bucket: 'demo-test.firebasestorage.app', (event) async {
       final data = event.data;
       print('Object deleted in bucket: ${event.bucket}');
       print('  Name: ${data?.name}');
     });
 
     // Storage onObjectMetadataUpdated - triggers when object metadata changes
-    firebase.storage.onObjectMetadataUpdated(bucket: 'my-bucket', (
+    firebase.storage.onObjectMetadataUpdated(bucket: 'demo-test.firebasestorage.app', (
       event,
     ) async {
       final data = event.data;

example/basic/storage.rules

@@ -0,0 +1,8 @@
+rules_version = '2';
+service firebase.storage {
+  match /b/{bucket}/o {
+    match /{allPaths=**} {
+      allow read, write: if true;
+    }
+  }
+}

example/client_app/index.html

@@ -194,26 +194,47 @@ <h2>6. Raw POST to Callable (without SDK)</h2>
     <div id="rawResult" class="result" style="display: none;"></div>
   </div>
 
+  <!-- Storage Upload Demo -->
+  <div class="card">
+    <h2>7. Storage - File Upload (triggers onObjectFinalized)</h2>
+    <p>Uploads a file to Cloud Storage via the Firebase SDK. The emulator automatically triggers <code>onObjectFinalized</code> on the Dart function. Check the emulator logs to see the trigger fire.</p>
+
+    <div>
+      <input type="file" id="storageFile">
+    </div>
+    <div>
+      <input type="text" id="storagePath" placeholder="Upload path" value="uploads/" style="width: 300px;">
+      <button onclick="uploadFile()">Upload to Storage</button>
+      <button onclick="deleteFile()">Delete Last Upload</button>
+    </div>
+
+    <div id="storageResult" class="result" style="display: none;"></div>
+  </div>
+
   <!-- Firebase SDK -->
   <script type="module">
     // Import Firebase SDK
     import { initializeApp } from 'https://www.gstatic.com/firebasejs/12.8.0/firebase-app.js';
     import { getFunctions, httpsCallable, connectFunctionsEmulator } from 'https://www.gstatic.com/firebasejs/12.8.0/firebase-functions.js';
     import { getAuth, connectAuthEmulator, signInWithEmailAndPassword, createUserWithEmailAndPassword, signOut as firebaseSignOut, onAuthStateChanged } from 'https://www.gstatic.com/firebasejs/12.8.0/firebase-auth.js';
+    import { getStorage, connectStorageEmulator, ref, uploadBytes, deleteObject, getMetadata } from 'https://www.gstatic.com/firebasejs/12.8.0/firebase-storage.js';
 
     // Initialize Firebase (minimal config for Functions)
     const firebaseConfig = {
       projectId: 'demo-test',
       apiKey: 'fake-api-key', // Not needed for emulator
+      storageBucket: 'demo-test.firebasestorage.app',
     };
 
     const app = initializeApp(firebaseConfig);
     const functions = getFunctions(app, 'us-central1');
     const auth = getAuth(app);
+    const storage = getStorage(app);
 
     // Connect to emulators
     connectFunctionsEmulator(functions, '127.0.0.1', 5001);
     connectAuthEmulator(auth, 'http://127.0.0.1:9099', { disableWarnings: true });
+    connectStorageEmulator(storage, '127.0.0.1', 9199);
 
     // Track auth state
     onAuthStateChanged(auth, (user) => {
@@ -234,8 +255,13 @@ <h2>6. Raw POST to Callable (without SDK)</h2>
     window.signInWithEmailAndPassword = signInWithEmailAndPassword;
     window.createUserWithEmailAndPassword = createUserWithEmailAndPassword;
     window.firebaseSignOut = firebaseSignOut;
+    window.storage = storage;
+    window.storageRef = ref;
+    window.uploadBytes = uploadBytes;
+    window.deleteObject = deleteObject;
+    window.getMetadata = getMetadata;
 
-    console.log('Firebase initialized and connected to emulators (Functions + Auth)');
+    console.log('Firebase initialized and connected to emulators (Functions + Auth + Storage)');
   </script>
 
   <script>
@@ -465,6 +491,64 @@ <h2>6. Raw POST to Callable (without SDK)</h2>
       }
     }
     window.callRawCallable = callRawCallable;
+
+    // 7. Storage - File upload (triggers onObjectFinalized)
+    let lastUploadedRef = null;
+
+    async function uploadFile() {
+      const fileInput = document.getElementById('storageFile');
+      const pathPrefix = document.getElementById('storagePath').value || 'uploads/';
+
+      if (!fileInput.files.length) {
+        showResult('storageResult', 'Please select a file first.', true);
+        return;
+      }
+
+      const file = fileInput.files[0];
+      const fullPath = pathPrefix + file.name;
+
+      try {
+        const fileRef = window.storageRef(window.storage, fullPath);
+        const snapshot = await window.uploadBytes(fileRef, file, {
+          contentType: file.type,
+        });
+
+        lastUploadedRef = fileRef;
+        const metadata = await window.getMetadata(fileRef);
+
+        showResult('storageResult', {
+          status: 'Upload complete - check emulator logs for onObjectFinalized trigger',
+          path: fullPath,
+          contentType: metadata.contentType,
+          size: metadata.size,
+          bucket: metadata.bucket,
+          timeCreated: metadata.timeCreated,
+        });
+      } catch (error) {
+        showResult('storageResult', `Upload error: ${error.message}`, true);
+      }
+    }
+    window.uploadFile = uploadFile;
+
+    async function deleteFile() {
+      if (!lastUploadedRef) {
+        showResult('storageResult', 'No file uploaded yet. Upload a file first.', true);
+        return;
+      }
+
+      try {
+        await window.deleteObject(lastUploadedRef);
+
+        showResult('storageResult', {
+          status: 'File deleted - check emulator logs for onObjectDeleted trigger',
+          path: lastUploadedRef.fullPath,
+        });
+        lastUploadedRef = null;
+      } catch (error) {
+        showResult('storageResult', `Delete error: ${error.message}`, true);
+      }
+    }
+    window.deleteFile = deleteFile;
   </script>
 </body>
 </html>

lib/builder.dart

@@ -541,8 +541,8 @@ class _FirebaseFunctionsVisitor extends RecursiveAstVisitor<void> {
     final bucketName = node.extractLiteralForArg('bucket');
     if (bucketName == null) return;
 
-    // Generate function name from bucket (remove hyphens to match Node.js behavior)
-    final sanitizedBucket = bucketName.replaceAll('-', '');
+    // Generate function name from bucket (strip non-alphanumeric chars for valid function ID)
+    final sanitizedBucket = bucketName.replaceAll(RegExp('[^a-zA-Z0-9]'), '');
     final functionName = '${methodName}_$sanitizedBucket';
 
     endpoints[functionName] = EndpointSpec(

lib/src/server.dart

@@ -533,17 +533,21 @@ Future<(Request, FirebaseFunctionDeclaration?)> _tryMatchCloudEventFunction(
     // - google.cloud.storage.object.v1.metadataUpdated
     if (type.startsWith('google.cloud.storage.object.v1.')) {
       // Extract bucket name from source URL
+      // Source format: //storage.googleapis.com/projects/_/buckets/{bucket}/objects/{path}
+      // or just: //storage.googleapis.com/projects/_/buckets/{bucket}
       String? bucketName;
       if (source.contains('/buckets/')) {
-        bucketName = source.split('/buckets/').last;
+        final afterBuckets = source.split('/buckets/').last;
+        // Bucket name is the first path segment (before any /objects/... suffix)
+        bucketName = afterBuckets.split('/').first;
       }
 
       if (bucketName != null) {
         // Map CloudEvent type to method name
         final methodName = _mapCloudEventTypeToStorageMethod(type);
         if (methodName != null) {
           // Sanitize bucket name to match function naming convention
-          final sanitizedBucket = bucketName.replaceAll('-', '');
+          final sanitizedBucket = bucketName.replaceAll(RegExp('[^a-zA-Z0-9]'), '');
           final expectedFunctionName = '${methodName}_$sanitizedBucket';
 
           // Try to find a matching function

lib/src/storage/storage_namespace.dart

@@ -159,7 +159,7 @@ class StorageNamespace extends FunctionsNamespace {
   /// Examples:
   /// - ('onObjectFinalized', 'my-bucket') -> 'onObjectFinalized_mybucket'
   String _bucketToFunctionName(String methodName, String bucket) {
-    final sanitizedBucket = bucket.replaceAll('-', '');
+    final sanitizedBucket = bucket.replaceAll(RegExp('[^a-zA-Z0-9]'), '');
     return '${methodName}_$sanitizedBucket';
   }
 

test/e2e/e2e_test.dart

@@ -13,13 +13,15 @@ import 'helpers/emulator.dart';
 import 'helpers/firestore_client.dart';
 import 'helpers/http_client.dart';
 import 'helpers/pubsub_client.dart';
+import 'helpers/storage_client.dart';
 import 'tests/database_tests.dart';
 import 'tests/firestore_tests.dart';
 import 'tests/https_onrequest_tests.dart';
 import 'tests/identity_tests.dart';
 import 'tests/integration_tests.dart';
 import 'tests/pubsub_tests.dart';
 import 'tests/scheduler_tests.dart';
+import 'tests/storage_tests.dart';
 
 void main() {
   late EmulatorHelper emulator;
@@ -28,6 +30,7 @@ void main() {
   late FirestoreClient firestoreClient;
   late DatabaseClient databaseClient;
   late AuthClient authClient;
+  late StorageClient storageClient;
 
   // Debug: Show Directory.current.path at module load time
   print('DEBUG e2e_test: Directory.current.path = ${Directory.current.path}');
@@ -90,6 +93,12 @@ void main() {
     // Create Auth client
     authClient = AuthClient(emulator.authUrl, 'demo-test');
 
+    // Create Storage client
+    storageClient = StorageClient(
+      emulator.storageUrl,
+      'demo-test.firebasestorage.app',
+    );
+
     // Give emulator a moment to fully initialize
     await Future<void>.delayed(const Duration(seconds: 2));
   });
@@ -106,6 +115,7 @@ void main() {
     firestoreClient.close();
     databaseClient.close();
     authClient.close();
+    storageClient.close();
     await emulator.stop();
   });
 
@@ -116,6 +126,7 @@ void main() {
   runFirestoreTests(() => examplePath, () => firestoreClient, () => emulator);
   runDatabaseTests(() => examplePath, () => databaseClient, () => emulator);
   runIdentityTests(() => examplePath, () => authClient, () => emulator);
+  runStorageTests(() => examplePath, () => storageClient, () => emulator);
   runSchedulerTests(
     () => examplePath,
     () => emulator,

test/e2e/helpers/emulator.dart

@@ -11,6 +11,7 @@ class EmulatorHelper {
     this.firestorePort = 8080,
     this.databasePort = 9000,
     this.authPort = 9099,
+    this.storagePort = 9199,
     this.startupTimeout = const Duration(seconds: 90),
   });
   Process? _process;
@@ -20,6 +21,7 @@ class EmulatorHelper {
   final int firestorePort;
   final int databasePort;
   final int authPort;
+  final int storagePort;
   final Duration startupTimeout;
 
   // Completer to signal when emulator is ready
@@ -56,7 +58,7 @@ class EmulatorHelper {
         'emulators:start',
         '--debug',
         '--only',
-        'functions,pubsub,firestore,database,auth',
+        'functions,pubsub,firestore,database,auth,storage',
         '--project',
         'demo-test',
         '--non-interactive',
@@ -278,6 +280,9 @@ class EmulatorHelper {
   /// Gets the base URL for the Auth emulator REST API.
   String get authUrl => 'http://localhost:$authPort';
 
+  /// Gets the base URL for the Storage emulator REST API.
+  String get storageUrl => 'http://localhost:$storagePort';
+
   /// Verifies that a function was executed in the emulator logs.
   /// Returns true if we find both "Beginning execution" and "Finished" messages.
   bool verifyFunctionExecution(String functionName) {