Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
- Update `FirebaseFunctionDeclaration` and `registerFunction` to store `allowedOrigins` - Update `onRequest`, `onCall`, and `onCallWithData` to pass CORS options - Update `server.dart` to intercept `OPTIONS` preflight requests and append headers to responses - Add unit tests for origin matching (`server_test.dart`) and option passing (`https_namespace_test.dart`)
demolaf
reviewed
Apr 1, 2026
| // from the Node.js model does not apply here. | ||
|
|
||
| // Validate HTTP method for event functions | ||
| if (request.method.toUpperCase() == 'OPTIONS' && |
Member
There was a problem hiding this comment.
yeah this fixes the validation order too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FirebaseFunctionDeclarationandregisterFunctionto storeallowedOriginsonRequest,onCall, andonCallWithDatato pass CORS optionsserver.dartto interceptOPTIONSpreflight requests and append headers to responsesserver_test.dart) and option passing (https_namespace_test.dart)Fixes #100