Skip to content

fix: dont leak error details to client #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lyokone merged 2 commits into from
Feb 4, 2026
Merged

fix: dont leak error details to client #33

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68cfae9
fix: dont leak error details to client
Lyokone Feb 4, 2026
97554c6
format
Lyokone Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions lib/src/https/https_namespace.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,12 @@ class HttpsNamespace extends FunctionsNamespace {
body: jsonEncode(e.toErrorResponse()),
headers: {'Content-Type': 'application/json'},
);
} catch (e) {
// Unexpected error - return internal error
final error = InternalError(e.toString());
} catch (e, stackTrace) {
// Unexpected error - log server-side but don't expose details to client
print(
'Unexpected error in onRequest function "$name": $e\n$stackTrace',
);
final error = InternalError();
return Response(
error.httpStatusCode,
body: jsonEncode(error.toErrorResponse()),
Expand Down Expand Up @@ -335,9 +338,10 @@ class HttpsNamespace extends FunctionsNamespace {
body: jsonEncode(e.toErrorResponse()),
headers: {'Content-Type': 'application/json'},
);
} catch (e) {
// Unexpected error
final error = InternalError(e.toString());
} catch (e, stackTrace) {
// Unexpected error - log server-side but don't expose details to client
print('Unexpected error in callable function: $e\n$stackTrace');
final error = InternalError();

if (callableRequest.acceptsStreaming && !callableResponse.aborted) {
callableResponse.writeSSE(error.toErrorResponse());
Expand Down
Loading