fix(firestore): read old_value for delete events in onDocumentDeleted handler#57
Merged
fix(firestore): read old_value for delete events in onDocumentDeleted handler#57
Conversation
# Conflicts: # lib/src/firestore/firestore_namespace.dart
demolaf
force-pushed
the
fix-doc-deleted
branch
from
6ecf073 to
39b38d0
Compare
demolaf
changed the title
Lyokone
reviewed
Feb 27, 2026
Lyokone
reviewed
Feb 27, 2026
Lyokone
reviewed
Feb 27, 2026
Co-authored-by: Guillaume Bernos <guillaume@bernos.dev>
Lyokone
reviewed
Feb 27, 2026
Lyokone
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
_registerDocumentHandler()was unconditionally readingparsed?['value'](the post-write state) for all event types, but for delete events the pre-deletion document is inparsed?['old_value']— causingevent.datato always benullinonDocumentDeletedhandlers. Fixed by selecting the field based on the method name.Testing
Added a test that checks the emulator logs in
'onDocumentDeleted fires with final document state'e2e test to verify event.data is not null.