Skip to content

Remove dependency on pkg:jose#87

Merged
kevmoo merged 4 commits intofirebase:mainfrom
kevmoo:crypto_better
Mar 19, 2026
Merged

Remove dependency on pkg:jose#87
kevmoo merged 4 commits intofirebase:mainfrom
kevmoo:crypto_better

Conversation

@kevmoo
Copy link
Copy Markdown
Collaborator

@kevmoo kevmoo commented Mar 19, 2026

Standardize on pkg:dart_jsonwebtoken

Standardize on pkg:dart_jsonwebtoken
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the handling of JSON Web Tokens by replacing the jose package with dart_jsonwebtoken. This change standardizes the approach to JWT verification and key management, leading to a more consistent and potentially more maintainable codebase for authentication-related functionalities.

Highlights

  • Dependency Migration: The project has migrated from using the pkg:jose package for JSON Web Token (JWT) operations to pkg:dart_jsonwebtoken.
  • JWT Verification Logic Update: The token verification process in AuthBlockingTokenVerifier has been refactored to utilize the new dart_jsonwebtoken API for decoding, key retrieval, and verification.
  • Key Caching Mechanism Refinement: The static caching mechanism for Google's public keys has been updated from JsonWebKeyStore to a Map<String, JWTKey> to align with the new dart_jsonwebtoken types.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully replaces the jose package with dart_jsonwebtoken for handling JWTs, which helps standardize dependencies. The changes in token_verifier.dart correctly adapt the logic for token decoding, public key fetching, and signature verification to the new library's API. The overall implementation is solid, but I've identified a minor improvement to enhance type safety during token verification, making it more robust against potentially malformed JWTs.

@kevmoo
Copy link
Copy Markdown
Collaborator Author

kevmoo commented Mar 19, 2026

Can haz merge?

@kevmoo kevmoo merged commit fb963c7 into firebase:main Mar 19, 2026
8 checks passed
@kevmoo kevmoo deleted the crypto_better branch March 19, 2026 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants