Skip to content

cleanup: simplify InternalExpression logic #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lyokone merged 2 commits into from
Mar 27, 2026
Merged

cleanup: simplify InternalExpression logic #92

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64c9ba7
cleanup: simplify InternalExpression logic
kevmoo Mar 27, 2026
adfc5fe
review nit
kevmoo Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 30 additions & 39 deletions lib/src/common/params.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -792,11 +792,25 @@ class _EnumSelectParamInput<T extends Enum> extends ParamInput<List<T>> {
/// These are special expressions that read from Firebase environment
/// variables and are always available without being defined by the user.
class InternalExpression extends Param<String> {
const InternalExpression._(String name, this.getter) : super(name, null);
final String Function(Map<String, String>) getter;
const InternalExpression._(String name, this._configKey) : super(name, null);

final String _configKey;

@override
String runtimeValue() => getter(Platform.environment);
String runtimeValue() {
if (Platform.environment['FIREBASE_CONFIG'] case final String config) {
try {
if (jsonDecode(config) case final Map<String, dynamic> map) {
if (map[_configKey] case final String value) {
return value;
}
}
} on FormatException {
// ignore
}
}
return '';
}

@override
WireParamSpec<String> toSpec() {
Expand All @@ -820,45 +834,22 @@ sealed class ParamInput<T extends Object> {

// Internal Firebase expressions

static final databaseURL = InternalExpression._('DATABASE_URL', (env) {
if (!env.containsKey('FIREBASE_CONFIG')) return '';
try {
final config = jsonDecode(env['FIREBASE_CONFIG']!);
return config['databaseURL'] as String? ?? '';
} on FormatException {
return '';
}
});
static const databaseURL = InternalExpression._(
'DATABASE_URL',
'databaseURL',
);

static final projectId = InternalExpression._('PROJECT_ID', (env) {
if (!env.containsKey('FIREBASE_CONFIG')) return '';
try {
final config = jsonDecode(env['FIREBASE_CONFIG']!);
return config['projectId'] as String? ?? '';
} on FormatException {
return '';
}
});
static const projectId = InternalExpression._('PROJECT_ID', 'projectId');

static final gcloudProject = InternalExpression._('GCLOUD_PROJECT', (env) {
if (!env.containsKey('FIREBASE_CONFIG')) return '';
try {
final config = jsonDecode(env['FIREBASE_CONFIG']!);
return config['projectId'] as String? ?? '';
} on FormatException {
return '';
}
});
static const gcloudProject = InternalExpression._(
'GCLOUD_PROJECT',
'projectId',
);

static final storageBucket = InternalExpression._('STORAGE_BUCKET', (env) {
if (!env.containsKey('FIREBASE_CONFIG')) return '';
try {
final config = jsonDecode(env['FIREBASE_CONFIG']!);
return config['storageBucket'] as String? ?? '';
} on FormatException {
return '';
}
});
static const storageBucket = InternalExpression._(
'STORAGE_BUCKET',
'storageBucket',
);

// Factory methods for creating input types

Expand Down
Loading