Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Auth] Add @discardableResult to avoid warnings #14486

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ns-vasilev
Copy link
Contributor

This PR adds @discardableResult to avoid warnings, as described in #13649

Copy link

google-cla bot commented Feb 24, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@paulb777
Copy link
Member

Thanks @ns-vasilev. Please sign the CLA and we can take a look.

@ns-vasilev
Copy link
Contributor Author

@paulb777 I've done this

@paulb777
Copy link
Member

@ns-vasilev
Copy link
Contributor Author

@paulb777, I didn't notice that it's possible to restart the check, thanks 👍

@ns-vasilev ns-vasilev force-pushed the feature/auth/13649-discurdable-result branch from 6de7e95 to 7eee713 Compare March 7, 2025 08:42
@ncooke3
Copy link
Member

ncooke3 commented Mar 7, 2025

Thanks @ns-vasilev for exploring both approaches! New APIs follow an internal API proposal process so I will kick that off and circle back with any feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants