Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vertex AI] Add APIConfig to userInfo dictionary in coders #14592

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

andrewheard
Copy link
Contributor

Added the APIConfig to the JSONEncoder and JSONDecoder used in GenerativeAIService. The APIConfig is accessible via the computed property apiConfig during encoding and decoding of request / response types. This will simplify future decoding of CitationMetadata, which is deeply nested in the GenerateContentResponse, based on the backend API in use.

#no-changelog

Copy link

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

@andrewheard

This comment was marked as resolved.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the APIConfig to the JSONEncoder and JSONDecoder used in GenerativeAIService. This allows the APIConfig to be accessible during encoding and decoding of request/response types, which simplifies future decoding of CitationMetadata. The changes look good overall, with a few minor suggestions for improvement.

Summary of Findings

  • Force-unwrapping URLs: The code uses force-unwrapping when creating URLs, which can lead to runtime crashes if the URL string is invalid. Consider using optional binding or URL(string:) to handle potential nil values gracefully.
  • Fatal errors: The code uses fatalError in several places when the APIConfig is not found in the coder's userInfo. While this is acceptable for development, consider using a more graceful error handling mechanism in production code.
  • Redundant decoder configuration: The code initializes a JSONDecoder with keyDecodingStrategy = .convertFromSnakeCase which is no longer needed since the APIConfig is now being passed in.

Merge Readiness

The pull request is almost ready for merging. Before merging, I recommend addressing the force-unwrapping of URLs and considering a more graceful error handling mechanism than fatalError. I am unable to directly approve this pull request, and users should have others review and approve this code before merging.

@andrewheard andrewheard marked this pull request as ready for review March 18, 2025 00:20
@andrewheard andrewheard requested a review from paulb777 March 18, 2025 00:20
@andrewheard andrewheard marked this pull request as draft March 18, 2025 01:33
@andrewheard
Copy link
Contributor Author

@paulb777 I thought about this a bit more and realized that it would be a breaking change for anyone that is using our public Codable conformances (e.g., to read/write Chat history to/from disk). I think I'll switch to a simpler approach to decode CitationMetadata based on the keys in the payload (citations vs. citationSources). We can re-evaluate if there are bigger differences we need to handle in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants