[Vertex AI] Swift Testing generateContentStream integration test
#14611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request migrates and parameterizes generateContentStream and testGenerateContent_appCheckNotConfigured_shouldFail integration tests to Swift Testing. The changes look good overall, with improvements in test organization and coverage. Here are a few suggestions for improvement.
Merge Readiness
The code changes are well-structured and improve the test suite. I recommend addressing the minor suggestions provided in the review comments. I am unable to directly approve this pull request, and recommend that others review and approve this code before merging.
FirebaseVertexAI/Tests/TestApp/Tests/Integration/GenerateContentIntegrationTests.swift
Show resolved
Hide resolved
FirebaseVertexAI/Tests/TestApp/Tests/Integration/GenerateContentIntegrationTests.swift
Show resolved
Hide resolved
FirebaseVertexAI/Tests/TestApp/Tests/Integration/GenerateContentIntegrationTests.swift
Show resolved
Hide resolved
andrewheard
force-pushed
the
ah/vertex-gen-stream-integration
branch
from
c5d2164 to
3d08322
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated the
testGenerateContentStreamandtestGenerateContent_appCheckNotConfigured_shouldFailintegration tests fromXCTestto Swift Testing (inGenerateContentIntegrationTests) and parameterized them to run on all of their supported backend APIs.#no-changelog