Skip to content

fix: FIRCLSContextManagerTests flake #15757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ncooke3 wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

fix: FIRCLSContextManagerTests flake #15757

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dd8a528
fix: FIRCLSContextManagerTests flake
ncooke3 Jan 23, 2026
6f36465
attempt 1: remove unlink, use o_trunc
ncooke3 Jan 24, 2026
7f79de0
Revert "attempt 1: remove unlink, use o_trunc"
ncooke3 Jan 25, 2026
0963823
attempt 2: dispatch_sync to binaryimagequeue
ncooke3 Jan 25, 2026
2bea868
attempt 3: combine attempts 1 and 2
ncooke3 Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions .github/workflows/sdk.crashlytics.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,30 @@ jobs:
product: FirebaseCrashlytics
target: FirebaseCrashlytics-Unit-unit

catalyst-2:
uses: ./.github/workflows/_catalyst.yml
with:
product: FirebaseCrashlytics
target: FirebaseCrashlytics-Unit-unit

catalyst-3:
uses: ./.github/workflows/_catalyst.yml
with:
product: FirebaseCrashlytics
target: FirebaseCrashlytics-Unit-unit

catalyst-4:
uses: ./.github/workflows/_catalyst.yml
with:
product: FirebaseCrashlytics
target: FirebaseCrashlytics-Unit-unit

catalyst-5:
uses: ./.github/workflows/_catalyst.yml
with:
product: FirebaseCrashlytics
target: FirebaseCrashlytics-Unit-unit

pod_lib_lint:
uses: ./.github/workflows/_cocoapods.yml
with:
Expand Down
6 changes: 1 addition & 5 deletions Crashlytics/Crashlytics/Components/FIRCLSContext.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,13 +412,9 @@ bool FIRCLSContextRecordMetadata(NSString* rootPath, const FIRCLSContextInitData
const char* appQualitySessionId = [[initData appQualitySessionId] UTF8String];
const char* path =
[[rootPath stringByAppendingPathComponent:FIRCLSReportMetadataFile] fileSystemRepresentation];
if (!FIRCLSUnlinkIfExists(path)) {
FIRCLSSDKLog("Unable to unlink existing metadata file %s\n", strerror(errno));
}

FIRCLSFile file;

if (!FIRCLSFileInitWithPath(&file, path, false)) {
if (!FIRCLSFileInitWithPathMode(&file, path, false, false)) {
FIRCLSSDKLog("Unable to open metadata file %s\n", strerror(errno));
return false;
}
Expand Down
Loading