Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Crashlytics/Crashlytics/Components/FIRCLSApplication.m
Original file line number Diff line number Diff line change
Expand Up @@ -156,8 +156,8 @@ id FIRCLSApplicationSharedInstance(void) {
#endif

id<NSObject> FIRCLSApplicationBeginActivity(NSActivityOptions options, NSString* reason) {
if ([[NSProcessInfo processInfo] respondsToSelector:@selector(beginActivityWithOptions:
reason:)]) {
if ([[NSProcessInfo processInfo]
respondsToSelector:@selector(beginActivityWithOptions:reason:)]) {
return [[NSProcessInfo processInfo] beginActivityWithOptions:options reason:reason];
}

Expand Down
2 changes: 1 addition & 1 deletion Crashlytics/UnitTests/FIRCLSCompactUnwindTests.m
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ - (NSString*)resourcePath {
NSBundle* bundle = SWIFTPM_MODULE_BUNDLE;
return [bundle.resourcePath stringByAppendingPathComponent:@"Data"];
#else
NSBundle *bundle = [NSBundle bundleForClass:[self class]];
NSBundle* bundle = [NSBundle bundleForClass:[self class]];
return bundle.resourcePath;
#endif
}
Expand Down
2 changes: 1 addition & 1 deletion Crashlytics/UnitTests/FIRCLSDwarfTests.m
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ - (NSString*)resourcePath {
NSBundle* bundle = SWIFTPM_MODULE_BUNDLE;
return [bundle.resourcePath stringByAppendingPathComponent:@"Data"];
#else
NSBundle *bundle = [NSBundle bundleForClass:[self class]];
NSBundle* bundle = [NSBundle bundleForClass:[self class]];
return bundle.resourcePath;
#endif
}
Expand Down
8 changes: 4 additions & 4 deletions FirebaseMessaging/Sources/FIRMessaging.m
Original file line number Diff line number Diff line change
Expand Up @@ -391,8 +391,8 @@ - (void)handleIncomingLinkIfNeededFromMessage:(NSDictionary *)message {
return;
}
id<UIApplicationDelegate> appDelegate = application.delegate;
SEL continueUserActivitySelector = @selector(application:
continueUserActivity:restorationHandler:);
SEL continueUserActivitySelector =
@selector(application:continueUserActivity:restorationHandler:);

// Due to FIRAAppDelegateProxy swizzling, this selector will most likely get chosen, whether or
// not the actual application has implemented
Expand Down Expand Up @@ -617,8 +617,8 @@ - (void)setDelegate:(id<FIRMessagingDelegate>)delegate {
// NOTE: Once |didReceiveRegistrationToken:| can be made a required method, this
// check can be removed.
- (void)validateDelegateConformsToTokenAvailabilityMethods {
if (self.delegate && ![self.delegate respondsToSelector:@selector(messaging:
didReceiveRegistrationToken:)]) {
if (self.delegate &&
![self.delegate respondsToSelector:@selector(messaging:didReceiveRegistrationToken:)]) {
FIRMessagingLoggerWarn(kFIRMessagingMessageCodeTokenDelegateMethodsNotImplemented,
@"The object %@ does not respond to "
@"-messaging:didReceiveRegistrationToken:. Please implement "
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -221,8 +221,8 @@ - (void)testIncompleteAppDelegateRemoteNotificationWithFetchHandlerMethod {
[self.proxy swizzleMethodsIfPossible];

#if TARGET_OS_IOS || TARGET_OS_TV
SEL remoteNotificationWithFetchHandler = @selector(application:
didReceiveRemoteNotification:fetchCompletionHandler:);
SEL remoteNotificationWithFetchHandler =
@selector(application:didReceiveRemoteNotification:fetchCompletionHandler:);
XCTAssertTrue([incompleteAppDelegate respondsToSelector:remoteNotificationWithFetchHandler]);
#endif // TARGET_OS_IOS || TARGET_OS_TV

Expand Down Expand Up @@ -319,11 +319,11 @@ - (void)testIncompleteUserNotificationCenterDelegateMethod {
// Because the incomplete delete does not implement either of the optional delegate methods, we
// should swizzle nothing. If we had swizzled them, then respondsToSelector: would return YES
// even though the delegate does not implement the methods.
SEL willPresentSelector = @selector(userNotificationCenter:
willPresentNotification:withCompletionHandler:);
SEL willPresentSelector =
@selector(userNotificationCenter:willPresentNotification:withCompletionHandler:);
XCTAssertFalse([delegate respondsToSelector:willPresentSelector]);
SEL didReceiveResponseSelector = @selector(userNotificationCenter:
didReceiveNotificationResponse:withCompletionHandler:);
SEL didReceiveResponseSelector =
@selector(userNotificationCenter:didReceiveNotificationResponse:withCompletionHandler:);
XCTAssertFalse([delegate respondsToSelector:didReceiveResponseSelector]);
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,8 @@ void InstrumentURLSessionTaskDidCompleteWithError(FPRClassInstrumentor *instrume
NS_EXTENSION_UNAVAILABLE("Firebase Performance is not supported for extensions.")
void InstrumentURLSessionTaskDidSendBodyDataTotalBytesSentTotalBytesExpectedToSend(
FPRClassInstrumentor *instrumentor) {
SEL selector = @selector(URLSession:
task:didSendBodyData:totalBytesSent:totalBytesExpectedToSend:);
SEL selector =
@selector(URLSession:task:didSendBodyData:totalBytesSent:totalBytesExpectedToSend:);
FPRSelectorInstrumentor *selectorInstrumentor =
[instrumentor instrumentorForInstanceSelector:selector];
if (selectorInstrumentor) {
Expand Down Expand Up @@ -159,8 +159,8 @@ void InstrumentURLSessionDownloadTaskDidFinishDownloadToURL(FPRClassInstrumentor
NS_EXTENSION_UNAVAILABLE("Firebase Performance is not supported for extensions.")
void InstrumentURLSessionDownloadTaskDidWriteDataTotalBytesWrittenTotalBytesExpectedToWrite(
FPRClassInstrumentor *instrumentor) {
SEL selector = @selector(URLSession:
downloadTask:didWriteData:totalBytesWritten:totalBytesExpectedToWrite:);
SEL selector =
@selector(URLSession:downloadTask:didWriteData:totalBytesWritten:totalBytesExpectedToWrite:);
FPRSelectorInstrumentor *selectorInstrumentor =
[instrumentor instrumentorForInstanceSelector:selector];
if (selectorInstrumentor) {
Expand Down Expand Up @@ -244,9 +244,9 @@ - (void)registerObject:(id)object {
// Register the non-swizzled versions of these methods.
// NSURLSessionTaskDelegate methods.
CopySelector(@selector(URLSession:task:didCompleteWithError:), instrumentor);
CopySelector(@selector(URLSession:
task:didSendBodyData:totalBytesSent:totalBytesExpectedToSend:),
instrumentor);
CopySelector(
@selector(URLSession:task:didSendBodyData:totalBytesSent:totalBytesExpectedToSend:),
instrumentor);

// NSURLSessionDataDelegate methods.
CopySelector(@selector(URLSession:dataTask:didReceiveData:), instrumentor);
Expand All @@ -255,9 +255,10 @@ - (void)registerObject:(id)object {
CopySelector(@selector(URLSession:downloadTask:didFinishDownloadingToURL:), instrumentor);
CopySelector(@selector(URLSession:downloadTask:didResumeAtOffset:expectedTotalBytes:),
instrumentor);
CopySelector(@selector(URLSession:
downloadTask:didWriteData:totalBytesWritten:totalBytesExpectedToWrite:),
instrumentor);
CopySelector(
@selector(
URLSession:downloadTask:didWriteData:totalBytesWritten:totalBytesExpectedToWrite:),
instrumentor);

[instrumentor swizzle];
});
Expand Down
18 changes: 6 additions & 12 deletions Firestore/Example/Tests/SpecTests/FSTMockDatastore.mm
Original file line number Diff line number Diff line change
Expand Up @@ -75,12 +75,9 @@
GrpcConnection* grpc_connection,
WatchStreamCallback* callback,
MockDatastore* datastore)
: WatchStream{worker_queue,
auth_credentials_provider,
app_check_credentials_provider,
std::move(serializer),
grpc_connection,
callback},
: WatchStream{
worker_queue, auth_credentials_provider, app_check_credentials_provider,
std::move(serializer), grpc_connection, callback},
datastore_{datastore},
callback_{callback} {
}
Expand Down Expand Up @@ -177,12 +174,9 @@ void WriteWatchChange(const WatchChange& change, SnapshotVersion snap) {
GrpcConnection* grpc_connection,
WriteStreamCallback* callback,
MockDatastore* datastore)
: WriteStream{worker_queue,
auth_credentials_provider,
app_check_credentials_provider,
std::move(serializer),
grpc_connection,
callback},
: WriteStream{
worker_queue, auth_credentials_provider, app_check_credentials_provider,
std::move(serializer), grpc_connection, callback},
datastore_{datastore},
callback_{callback} {
}
Expand Down
2 changes: 1 addition & 1 deletion scripts/style.sh
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ case "$version" in
exit 1
;;
*)
echo "Please upgrade to clang-format version 21."
echo "Please upgrade to clang-format version 22."
echo "If it's installed via homebrew you can run:"
echo "brew upgrade clang-format"
exit 1
Expand Down
Loading