-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Add support for the new FCM registration ID. #16133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
leojaygoogle
wants to merge
24
commits into
main
Choose a base branch
from
fid
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 12 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
12a6ad8
Introduce new Info.plist key `FirebaseMessagingInstallationIdEnabled`.
leojaygoogle c3c3d67
Implement the FCM FID registration operation in the Messaging token m…
leojaygoogle b442d42
Add retry logic on network error and backend 5xx error.
leojaygoogle fe49a75
Implement the FCM FID unregistration operation.
leojaygoogle f1294be
Add didReceiveRegistration delegate method.
leojaygoogle 8c0ba25
Update the sample app to handle the new registration ID.
leojaygoogle b471f82
Update CHANGELOG
leojaygoogle 4b72a42
Style update.
leojaygoogle c28628b
Use the internal FirebaseInstallations header file.
leojaygoogle e7aeac8
Rename `registrationId` to `installationId` in messaging delegate met…
leojaygoogle 836b697
Update copyright header to include LLC
leojaygoogle dff8587
Fix various compile warnings.
leojaygoogle 503c5b6
Add an FIRMessagingErrorCode to indicate installation related errors.
leojaygoogle c12d985
Move heartbeatLogger from FIRMessagingTokenOperation to FIRMessagingT…
leojaygoogle 1d4c3f8
Fix style warnings and address review comments.
leojaygoogle e984467
Mark `authorizedEntity` as `nullable`.
leojaygoogle 125dac3
Add FIRMessagingInstallationIdUnregisteredNotification and make sure …
leojaygoogle d95a204
Monitor FID change events and register the new FID when it happens.
leojaygoogle f7cea1d
Delete unused methods.
leojaygoogle fc874aa
Add test `testRegisterNotifiesDelegateWhenInstallationIdEnabled`.
leojaygoogle 26c94d2
Add `testUnregisterNotifiesDelegateWhenInstallationIdEnabled`
leojaygoogle 6093f94
Move installationIDObserver setup to the `start` method, instead of `…
leojaygoogle e7433b8
Fix test ordering failure in FIRMessagingTokenInfoTest.
leojaygoogle 77ad7f5
Add test `testAppStartNotifiesDelegateWhenBothAutoInitAndInstallation…
leojaygoogle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
leojaygoogle marked this conversation as resolved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 changes: 34 additions & 0 deletions
34
FirebaseMessaging/Sources/Token/FIRMessagingFIDRegisterOperation.h
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| /* | ||
| * Copyright 2026 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| #import "FirebaseMessaging/Sources/Token/FIRMessagingTokenOperation.h" | ||
|
|
||
| @class FIRInstallations; | ||
|
|
||
| NS_ASSUME_NONNULL_BEGIN | ||
|
|
||
| @interface FIRMessagingFIDRegisterOperation : FIRMessagingTokenOperation | ||
|
|
||
| - (instancetype)initWithAuthorizedEntity:(NSString *)authorizedEntity | ||
| scope:(NSString *)scope | ||
| options:(nullable NSDictionary<NSString *, NSString *> *)options | ||
| instanceID:(NSString *)instanceID | ||
| heartbeatLogger:(id<FIRHeartbeatLoggerProtocol>)heartbeatLogger | ||
| installations:(FIRInstallations *)installations; | ||
|
|
||
| @end | ||
|
|
||
| NS_ASSUME_NONNULL_END |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we update FIRMessagingTest.m to test changes in this file? Some test cases to consider:
When
isInstallationIdEnabledis trueregister()can successfully invokedidReceiveRegistration()regardless whether the same FID has been registered or not and regardless whetherisAutoInitis enabled or not.unregister()should invokedidUnregister()and leave the app as unregistered.isAutoInit=true,didReceiveRegistration()is invoked on app start when a new FID is registered or the registered FID has expired or the FID is changed.token/deleteTokenshould throw an errorretrieveFCMTokenForSenderID/deleteFCMTokenForSenderIDshould throw an errorWhen
isInstallationIdEnabledis falseregister()/unregister()should throw an error.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will add tests for the first 3 items. Regarding throwing exceptions, our style guide suggests avoiding them. go/objc-style#avoid-throwing-exceptions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good! Good to know that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done