feat(appcheck): Add new internal, default provider#16190
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
|
/gemini review |
| } | ||
|
|
||
| - (nullable id<FIRAppCheckProvider>)createProviderWithApp:(nonnull FIRApp *)app { | ||
| // TODO(ncooke3): What about for local dev targeting macOS? |
There was a problem hiding this comment.
Any possible improvements to the Mac App user journey? Maybe asserting or returning nil with a log to use a custom provider?
There was a problem hiding this comment.
Code Review
This pull request introduces FIRDefaultProviderFactory to automatically select the App Check provider based on the execution environment, using the Debug provider for simulators and the DeviceCheck provider for devices. The automatic registration logic was moved from FIRDeviceCheckProviderFactory to this new factory. Corresponding unit tests were added to ensure correct provider instantiation. I have no feedback to provide.
No description provided.