Skip to content

feat(appcheck): Add new internal, default provider#16190

Draft
ncooke3 wants to merge 3 commits into
mainfrom
nc/fac-sim
Draft

feat(appcheck): Add new internal, default provider#16190
ncooke3 wants to merge 3 commits into
mainfrom
nc/fac-sim

Conversation

@ncooke3
Copy link
Copy Markdown
Member

@ncooke3 ncooke3 commented May 20, 2026

No description provided.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Comment thread FirebaseAppCheck/CHANGELOG.md Outdated
@ncooke3
Copy link
Copy Markdown
Member Author

ncooke3 commented May 20, 2026

/gemini review

}

- (nullable id<FIRAppCheckProvider>)createProviderWithApp:(nonnull FIRApp *)app {
// TODO(ncooke3): What about for local dev targeting macOS?
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any possible improvements to the Mac App user journey? Maybe asserting or returning nil with a log to use a custom provider?

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces FIRDefaultProviderFactory to automatically select the App Check provider based on the execution environment, using the Debug provider for simulators and the DeviceCheck provider for devices. The automatic registration logic was moved from FIRDeviceCheckProviderFactory to this new factory. Corresponding unit tests were added to ensure correct provider instantiation. I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant