Skip to content

[Auth] Re-enable Firefox webdriver tests #5551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

[Auth] Re-enable Firefox webdriver tests #5551

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6a9fb6e
Re-enable Firefox webdriver tests
sam-gc Sep 27, 2021
ed0a108
Disable potentially bad test
sam-gc Sep 27, 2021
b370ae1
Disable single test for firefox, enable all others
sam-gc Sep 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/auth/test/integration/webdriver/persistence.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,10 @@ browserDescribe('WebDriver persistence test', (driver, browser) => {
});

it('use in-memory and clear all persistences if indexedDB and localStorage are both broken', async () => {
if (browser === 'firefox') {
// TODO(b/198792664): Investigate Firefox timeout failures caused by this test
return;
}
await driver.webDriver.navigate().refresh();
// Simulate browsers that do not support indexedDB.
await driver.webDriver.executeScript('delete window.indexedDB;');
Expand Down
2 changes: 1 addition & 1 deletion packages/auth/test/integration/webdriver/util/test_runner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ interface TempSuite {
}

/** The browsers that these tests will run in */
const BROWSERS = ['chrome', /* 'firefox' */]; // TODO(b/198792664): Investigate Firefox timeout issues
const BROWSERS = ['chrome', 'firefox'];

/** One single AuthDriver instance to control everything */
const DRIVER = new AuthDriver();
Expand Down