Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markduckworth/ppl mep #8801

Merged
merged 79 commits into from
Mar 21, 2025
Merged

Markduckworth/ppl mep #8801

merged 79 commits into from
Mar 21, 2025

Conversation

MarkDuckworth
Copy link
Contributor

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in an issue so that we
    can discuss it together.

@MarkDuckworth
Multiple entry points for main package.
e23ecfb
@MarkDuckworth
MEP for firestore lite building
8006776
@MarkDuckworth
Fix issue with external exports
db00e40
@MarkDuckworth
Refactor to support multiple entry points for the lite SDK. Fixes imp…
de97518 
…ort issues and makes code organization across /pipelines and /lite/pipeliens
@MarkDuckworth
Type and comment cleanup
9c373ec
@MarkDuckworth
Make PipelineSource generic and remove useFluentPipelines
8b03745
@MarkDuckworth
Remove converter and placeholders for converter.
2e1c8f6
@MarkDuckworth
cleanup: remove documentReferenceFactory
d67807e
@MarkDuckworth
Linting and formatting
ea5c8e1
@MarkDuckworth
Update the typings export for pipelines and lite pipelines so that it…
f251a04 
… auguments the Firestore and Query classes.
@MarkDuckworth
Add missing Expr export
718ba98
@MarkDuckworth
Lint fixes
99ca193
@MarkDuckworth
TODO cleanup
c911f97
@MarkDuckworth
update api review
229b0c7
@MarkDuckworth
Query to Proto with integration tests
0522ea7
@MarkDuckworth
API tweaks from review. Selectable, FilterCondition, and Accumulator …
50a65e4 
…are abstract classes not interfaces. Removed extraneous Pipeline.sort overload
@MarkDuckworth
Remove console.log statements from prune-dts.ts
d2291d0
@MarkDuckworth
Merge branch 'feat/pipelines' of github.com:firebase/firebase-js-sdk …
d437b8e 
…into markduckworth/ppl-mep
@MarkDuckworth
code cleanup in prune-dts
f44ea4d
@MarkDuckworth
Add missing imports to pipelines.ts
16cfd24
@MarkDuckworth
If argument to FunctionExpr is a plain object or array, convert these…
7d6aec1 
… to expression using map(...) or array(...)
@MarkDuckworth
Add tests for evaluating expressions in arrays and maps
e923dfd
@MarkDuckworth
implement new FunctionExpressions as standalone functions
29149c0
@MarkDuckworth
Fix typo and formatting in pipeline.test.ts
dbe6821
@MarkDuckworth
Implement support for genericStage and genericFunction
35a361d
@MarkDuckworth
Implement new function expressions as methods on the Expr class.
da71f9a
@MarkDuckworth
Merge branch 'feat/pipelines' of github.com:firebase/firebase-js-sdk …
a06589a 
…into markduckworth/ppl-mep
@MarkDuckworth
Pipeline test reorganization
e820ee5
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 20, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: ddc7a6f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MarkDuckworth
Rename several FunctionExpr standalone exports from <name>Function to…
cfb0879 
… <name>. Meets API design
@MarkDuckworth
Removing the all-packages api report script because it is no longer n…
03fd4dd 
…eeded
@MarkDuckworth
Remove any from the public api surface
ec03a5e
@MarkDuckworth
lint fix
458412c
@MarkDuckworth
Code cleanup
a7b5deb
@MarkDuckworth
FindNearest integration tests
f6cc94b
@MarkDuckworth
Filling in gaps in test coverage
96e3d19
@MarkDuckworth
Implement Pipeline tests for the lite SDK
fc61479
@MarkDuckworth
Fixed a build issue with the lite SDK
68b8a76
@MarkDuckworth
Improved error message context when invalid user data is passed to a …
225edeb 
…pipeline without being wrapped in a call to constant(...)
@MarkDuckworth
Fix typo in old error message
8f819f8
@MarkDuckworth
Fix lite pipeline exports
df746b4
@MarkDuckworth
Merge branch 'main' of github.com:firebase/firebase-js-sdk into markd…
d55be8a 
…uckworth/ppl-mep
@MarkDuckworth
api-review files
898ea70
@MarkDuckworth
Merge branch 'feat/pipelines' into markduckworth/ppl-mep
fa56207
@MarkDuckworth MarkDuckworth marked this pull request as ready for review March 12, 2025 22:06
@MarkDuckworth MarkDuckworth requested review from a team as code owners March 12, 2025 22:06
wu-hui
wu-hui approved these changes Mar 13, 2025
View reviewed changes
@wu-hui
Copy link
Contributor

wu-hui commented Mar 13, 2025

You probably need to run yarn prettier?

@github-actions GitHub Actions
Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v7.0

@MarkDuckworth MarkDuckworth merged commit d18310a into feat/pipelines Mar 21, 2025
12 of 21 checks passed
@MarkDuckworth MarkDuckworth deleted the markduckworth/ppl-mep branch March 21, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tom-andersen tom-andersen tom-andersen left review comments

@wu-hui wu-hui wu-hui approved these changes

Assignees

@tom-andersen tom-andersen

@wu-hui wu-hui

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarkDuckworth @wu-hui @tom-andersen