Implement Partial Errors for FDC #8821

maneesht · 2025-02-28T23:34:57Z

No description provided.

changeset-bot · 2025-02-28T23:35:01Z

🦋 Changeset detected

Latest commit: c695523

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@firebase/data-connect	Patch
firebase	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

google-oss-bot · 2025-02-28T23:44:23Z

Size Report ¹

Affected Products

@firebase/data-connect
Type Base (5718838) Merge (441a66d) Diff
browser 21.1 kB 21.4 kB +305 B (+1.4%)
main 23.1 kB 23.6 kB +529 B (+2.3%)
module 21.1 kB 21.4 kB +305 B (+1.4%)
firebase
Type Base (5718838) Merge (441a66d) Diff
firebase-data-connect.js 17.3 kB 17.6 kB +284 B (+1.6%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/0rCjBaNyPC.html

google-oss-bot · 2025-02-28T23:56:15Z

Size Analysis Report ¹

Affected Products

`@firebase/data-connect`

`CallerSdkTypeEnum`

Size

Type	Base (`5718838`)	Merge (`441a66d`)	Diff
size	12.4 kB	12.6 kB	+181 B (+1.5%)
size-with-ext-deps	30.6 kB	30.8 kB	+183 B (+0.6%)

Dependency

Type Base (5718838) Merge (441a66d) Diff

classes

AppCheckTokenProvider
DataConnect
DataConnectError
FirebaseAuthProvider
MutationManager
QueryManager
RESTTransport

AppCheckTokenProvider
DataConnect
DataConnectError
DataConnectOperationError
FirebaseAuthProvider
MutationManager
QueryManager
RESTTransport

+ DataConnectOperationError

`DataConnect`

Size

Type	Base (`5718838`)	Merge (`441a66d`)	Diff
size	12.4 kB	12.6 kB	+181 B (+1.5%)
size-with-ext-deps	30.6 kB	30.8 kB	+183 B (+0.6%)

Dependency

Type Base (5718838) Merge (441a66d) Diff

classes

AppCheckTokenProvider
DataConnect
DataConnectError
FirebaseAuthProvider
MutationManager
QueryManager
RESTTransport

AppCheckTokenProvider
DataConnect
DataConnectError
DataConnectOperationError
FirebaseAuthProvider
MutationManager
QueryManager
RESTTransport

+ DataConnectOperationError

`DataConnectError`

Size

Type	Base (`5718838`)	Merge (`441a66d`)	Diff
size	?	12.6 kB	? (?)
size-with-ext-deps	?	30.8 kB	? (?)

Dependency

Type	Base (`5718838`)	Merge (`441a66d`)	Diff
functions	?	15 dependencies addToken areTransportOptionsEqual compareDates dcFetch getGoogApiClientValue getMessage getRefSerializer logDebug logError parseOptions registerDataConnect setEncoder setIfNotExists setSDKVersion urlBuilder	?
classes	?	AppCheckTokenProvider DataConnect DataConnectError DataConnectOperationError FirebaseAuthProvider MutationManager QueryManager RESTTransport	?
variables	?	12 dependencies CallerSdkTypeEnum Code FIREBASE_DATA_CONNECT_EMULATOR_HOST_VAR QUERY_STR SDK_VERSION SOURCE_CACHE SOURCE_SERVER connectFetch encoderImpl logger name version	?
enums	?		?

External Dependency

Module	Base (`5718838`)	Merge (`441a66d`)	Diff
`@firebase/app`	?	SDK_VERSION _isFirebaseServerApp _registerComponent _removeServiceInstance registerVersion	?
`@firebase/component`	?	Component	?
`@firebase/logger`	?	Logger	?
`@firebase/util`	?	FirebaseError	?

`DataConnectOperationError`

Size

Type	Base (`5718838`)	Merge (`441a66d`)	Diff
size	?	12.6 kB	? (?)
size-with-ext-deps	?	30.8 kB	? (?)

Dependency

Type	Base (`5718838`)	Merge (`441a66d`)	Diff
functions	?	15 dependencies addToken areTransportOptionsEqual compareDates dcFetch getGoogApiClientValue getMessage getRefSerializer logDebug logError parseOptions registerDataConnect setEncoder setIfNotExists setSDKVersion urlBuilder	?
classes	?	AppCheckTokenProvider DataConnect DataConnectError DataConnectOperationError FirebaseAuthProvider MutationManager QueryManager RESTTransport	?
variables	?	12 dependencies CallerSdkTypeEnum Code FIREBASE_DATA_CONNECT_EMULATOR_HOST_VAR QUERY_STR SDK_VERSION SOURCE_CACHE SOURCE_SERVER connectFetch encoderImpl logger name version	?
enums	?		?

External Dependency

Module	Base (`5718838`)	Merge (`441a66d`)	Diff
`@firebase/app`	?	SDK_VERSION _isFirebaseServerApp _registerComponent _removeServiceInstance registerVersion	?
`@firebase/component`	?	Component	?
`@firebase/logger`	?	Logger	?
`@firebase/util`	?	FirebaseError	?

`MUTATION_STR`

Size

Type	Base (`5718838`)	Merge (`441a66d`)	Diff
size	12.4 kB	12.6 kB	+181 B (+1.5%)
size-with-ext-deps	30.6 kB	30.8 kB	+183 B (+0.6%)

Dependency

Type Base (5718838) Merge (441a66d) Diff

classes

AppCheckTokenProvider
DataConnect
DataConnectError
FirebaseAuthProvider
MutationManager
QueryManager
RESTTransport

AppCheckTokenProvider
DataConnect
DataConnectError
DataConnectOperationError
FirebaseAuthProvider
MutationManager
QueryManager
RESTTransport

+ DataConnectOperationError

`MutationManager`

Size

Type	Base (`5718838`)	Merge (`441a66d`)	Diff
size	12.4 kB	12.6 kB	+181 B (+1.5%)
size-with-ext-deps	30.6 kB	30.8 kB	+183 B (+0.6%)

Dependency

Type Base (5718838) Merge (441a66d) Diff

classes

AppCheckTokenProvider
DataConnect
DataConnectError
FirebaseAuthProvider
MutationManager
QueryManager
RESTTransport

AppCheckTokenProvider
DataConnect
DataConnectError
DataConnectOperationError
FirebaseAuthProvider
MutationManager
QueryManager
RESTTransport

+ DataConnectOperationError

`QUERY_STR`

Size

Type	Base (`5718838`)	Merge (`441a66d`)	Diff
size	12.4 kB	12.6 kB	+181 B (+1.5%)
size-with-ext-deps	30.6 kB	30.8 kB	+183 B (+0.6%)

Dependency

Type Base (5718838) Merge (441a66d) Diff

classes

AppCheckTokenProvider
DataConnect
DataConnectError
FirebaseAuthProvider
MutationManager
QueryManager
RESTTransport

AppCheckTokenProvider
DataConnect
DataConnectError
DataConnectOperationError
FirebaseAuthProvider
MutationManager
QueryManager
RESTTransport

+ DataConnectOperationError

`SOURCE_CACHE`

Size

Type	Base (`5718838`)	Merge (`441a66d`)	Diff
size	12.4 kB	12.6 kB	+181 B (+1.5%)
size-with-ext-deps	30.6 kB	30.8 kB	+183 B (+0.6%)

Dependency

Type Base (5718838) Merge (441a66d) Diff

classes

AppCheckTokenProvider
DataConnect
DataConnectError
FirebaseAuthProvider
MutationManager
QueryManager
RESTTransport

AppCheckTokenProvider
DataConnect
DataConnectError
DataConnectOperationError
FirebaseAuthProvider
MutationManager
QueryManager
RESTTransport

+ DataConnectOperationError

`SOURCE_SERVER`

Size

Type	Base (`5718838`)	Merge (`441a66d`)	Diff
size	12.4 kB	12.6 kB	+181 B (+1.5%)
size-with-ext-deps	30.6 kB	30.8 kB	+183 B (+0.6%)

Dependency

Type Base (5718838) Merge (441a66d) Diff

classes

AppCheckTokenProvider
DataConnect
DataConnectError
FirebaseAuthProvider
MutationManager
QueryManager
RESTTransport

AppCheckTokenProvider
DataConnect
DataConnectError
DataConnectOperationError
FirebaseAuthProvider
MutationManager
QueryManager
RESTTransport

+ DataConnectOperationError

`areTransportOptionsEqual`

Size

Type	Base (`5718838`)	Merge (`441a66d`)	Diff
size	12.4 kB	12.6 kB	+181 B (+1.5%)
size-with-ext-deps	30.6 kB	30.8 kB	+183 B (+0.6%)

Dependency

Type Base (5718838) Merge (441a66d) Diff

classes

AppCheckTokenProvider
DataConnect
DataConnectError
FirebaseAuthProvider
MutationManager
QueryManager
RESTTransport

AppCheckTokenProvider
DataConnect
DataConnectError
DataConnectOperationError
FirebaseAuthProvider
MutationManager
QueryManager
RESTTransport

+ DataConnectOperationError

`connectDataConnectEmulator`

Size

Type	Base (`5718838`)	Merge (`441a66d`)	Diff
size	12.5 kB	12.6 kB	+181 B (+1.5%)
size-with-ext-deps	30.7 kB	30.9 kB	+183 B (+0.6%)

Dependency

Type Base (5718838) Merge (441a66d) Diff

classes

AppCheckTokenProvider
DataConnect
DataConnectError
FirebaseAuthProvider
MutationManager
QueryManager
RESTTransport

AppCheckTokenProvider
DataConnect
DataConnectError
DataConnectOperationError
FirebaseAuthProvider
MutationManager
QueryManager
RESTTransport

+ DataConnectOperationError

`executeMutation`

Size

Type	Base (`5718838`)	Merge (`441a66d`)	Diff
size	12.5 kB	12.6 kB	+181 B (+1.5%)
size-with-ext-deps	30.7 kB	30.9 kB	+183 B (+0.6%)

Dependency

Type Base (5718838) Merge (441a66d) Diff

classes

AppCheckTokenProvider
DataConnect
DataConnectError
FirebaseAuthProvider
MutationManager
QueryManager
RESTTransport

AppCheckTokenProvider
DataConnect
DataConnectError
DataConnectOperationError
FirebaseAuthProvider
MutationManager
QueryManager
RESTTransport

+ DataConnectOperationError

`executeQuery`

Size

Type	Base (`5718838`)	Merge (`441a66d`)	Diff
size	12.4 kB	12.6 kB	+181 B (+1.5%)
size-with-ext-deps	30.7 kB	30.9 kB	+183 B (+0.6%)

Dependency

Type Base (5718838) Merge (441a66d) Diff

classes

AppCheckTokenProvider
DataConnect
DataConnectError
FirebaseAuthProvider
MutationManager
QueryManager
RESTTransport

AppCheckTokenProvider
DataConnect
DataConnectError
DataConnectOperationError
FirebaseAuthProvider
MutationManager
QueryManager
RESTTransport

+ DataConnectOperationError

`getDataConnect`

Size

Type	Base (`5718838`)	Merge (`441a66d`)	Diff
size	13.1 kB	13.3 kB	+181 B (+1.4%)
size-with-ext-deps	38.4 kB	38.6 kB	+183 B (+0.5%)

Dependency

Type Base (5718838) Merge (441a66d) Diff

classes

AppCheckTokenProvider
DataConnect
DataConnectError
FirebaseAuthProvider
MutationManager
QueryManager
RESTTransport

AppCheckTokenProvider
DataConnect
DataConnectError
DataConnectOperationError
FirebaseAuthProvider
MutationManager
QueryManager
RESTTransport

+ DataConnectOperationError

`mutationRef`

Size

Type	Base (`5718838`)	Merge (`441a66d`)	Diff
size	12.5 kB	12.7 kB	+181 B (+1.4%)
size-with-ext-deps	30.7 kB	30.9 kB	+183 B (+0.6%)

Dependency

Type Base (5718838) Merge (441a66d) Diff

classes

AppCheckTokenProvider
DataConnect
DataConnectError
FirebaseAuthProvider
MutationManager
QueryManager
RESTTransport

AppCheckTokenProvider
DataConnect
DataConnectError
DataConnectOperationError
FirebaseAuthProvider
MutationManager
QueryManager
RESTTransport

+ DataConnectOperationError

`parseOptions`

Size

Type	Base (`5718838`)	Merge (`441a66d`)	Diff
size	12.4 kB	12.6 kB	+181 B (+1.5%)
size-with-ext-deps	30.6 kB	30.8 kB	+183 B (+0.6%)

Dependency

Type Base (5718838) Merge (441a66d) Diff

classes

AppCheckTokenProvider
DataConnect
DataConnectError
FirebaseAuthProvider
MutationManager
QueryManager
RESTTransport

AppCheckTokenProvider
DataConnect
DataConnectError
DataConnectOperationError
FirebaseAuthProvider
MutationManager
QueryManager
RESTTransport

+ DataConnectOperationError

`queryRef`

Size

Type	Base (`5718838`)	Merge (`441a66d`)	Diff
size	12.5 kB	12.7 kB	+181 B (+1.4%)
size-with-ext-deps	30.7 kB	30.9 kB	+183 B (+0.6%)

Dependency

Type Base (5718838) Merge (441a66d) Diff

classes

AppCheckTokenProvider
DataConnect
DataConnectError
FirebaseAuthProvider
MutationManager
QueryManager
RESTTransport

AppCheckTokenProvider
DataConnect
DataConnectError
DataConnectOperationError
FirebaseAuthProvider
MutationManager
QueryManager
RESTTransport

+ DataConnectOperationError

`setLogLevel`

Size

Type	Base (`5718838`)	Merge (`441a66d`)	Diff
size	12.4 kB	12.6 kB	+181 B (+1.5%)
size-with-ext-deps	30.7 kB	30.8 kB	+183 B (+0.6%)

Dependency

Type Base (5718838) Merge (441a66d) Diff

classes

AppCheckTokenProvider
DataConnect
DataConnectError
FirebaseAuthProvider
MutationManager
QueryManager
RESTTransport

AppCheckTokenProvider
DataConnect
DataConnectError
DataConnectOperationError
FirebaseAuthProvider
MutationManager
QueryManager
RESTTransport

+ DataConnectOperationError

`subscribe`

Size

Type	Base (`5718838`)	Merge (`441a66d`)	Diff
size	13.6 kB	13.8 kB	+181 B (+1.3%)
size-with-ext-deps	39.0 kB	39.2 kB	+183 B (+0.5%)

Dependency

Type Base (5718838) Merge (441a66d) Diff

classes

AppCheckTokenProvider
DataConnect
DataConnectError
FirebaseAuthProvider
MutationManager
QueryManager
RESTTransport

AppCheckTokenProvider
DataConnect
DataConnectError
DataConnectOperationError
FirebaseAuthProvider
MutationManager
QueryManager
RESTTransport

+ DataConnectOperationError

`terminate`

Size

Type	Base (`5718838`)	Merge (`441a66d`)	Diff
size	12.4 kB	12.6 kB	+181 B (+1.5%)
size-with-ext-deps	30.7 kB	30.8 kB	+183 B (+0.6%)

Dependency

Type Base (5718838) Merge (441a66d) Diff

classes

AppCheckTokenProvider
DataConnect
DataConnectError
FirebaseAuthProvider
MutationManager
QueryManager
RESTTransport

AppCheckTokenProvider
DataConnect
DataConnectError
DataConnectOperationError
FirebaseAuthProvider
MutationManager
QueryManager
RESTTransport

+ DataConnectOperationError

`toQueryRef`

Size

Type	Base (`5718838`)	Merge (`441a66d`)	Diff
size	13.3 kB	13.5 kB	+181 B (+1.4%)
size-with-ext-deps	38.6 kB	38.8 kB	+183 B (+0.5%)

Dependency

Type Base (5718838) Merge (441a66d) Diff

classes

AppCheckTokenProvider
DataConnect
DataConnectError
FirebaseAuthProvider
MutationManager
QueryManager
RESTTransport

AppCheckTokenProvider
DataConnect
DataConnectError
DataConnectOperationError
FirebaseAuthProvider
MutationManager
QueryManager
RESTTransport

+ DataConnectOperationError

`validateArgs`

Size

Type	Base (`5718838`)	Merge (`441a66d`)	Diff
size	13.2 kB	13.4 kB	+181 B (+1.4%)
size-with-ext-deps	38.6 kB	38.8 kB	+183 B (+0.5%)

Dependency

Type Base (5718838) Merge (441a66d) Diff

classes

AppCheckTokenProvider
DataConnect
DataConnectError
FirebaseAuthProvider
MutationManager
QueryManager
RESTTransport

AppCheckTokenProvider
DataConnect
DataConnectError
DataConnectOperationError
FirebaseAuthProvider
MutationManager
QueryManager
RESTTransport

+ DataConnectOperationError

`validateDCOptions`

Size

Type	Base (`5718838`)	Merge (`441a66d`)	Diff
size	12.6 kB	12.8 kB	+181 B (+1.4%)
size-with-ext-deps	30.9 kB	31.0 kB	+183 B (+0.6%)

Dependency

Type Base (5718838) Merge (441a66d) Diff

classes

AppCheckTokenProvider
DataConnect
DataConnectError
FirebaseAuthProvider
MutationManager
QueryManager
RESTTransport

AppCheckTokenProvider
DataConnect
DataConnectError
DataConnectOperationError
FirebaseAuthProvider
MutationManager
QueryManager
RESTTransport

+ DataConnectOperationError

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/czf01GRmX8.html

stephenarosaj

LGTM

packages/data-connect/src/api/index.ts

dconeybe

Looks great!

dconeybe and others added 5 commits February 26, 2025 13:34

Add API for partial errors

f63d34d

Update API reports

6032daf

src/core/error.ts: cleanups

c5d3829

data-connect.api.md: updated

8a33180

Implemented partial error

9f535fb

maneesht added 2 commits February 28, 2025 15:38

Removed only

763dcd3

Removed only

8978a65

maneesht added 5 commits March 14, 2025 13:44

Merge remote-tracking branch 'origin/main' into mtewani/partial-errors

7005b5a

Updated error type name

1ce98e6

Updated data connect API

c616528

Merge remote-tracking branch 'origin/main' into mtewani/partial-errors

f08d28d

Updated typings

1f5fa03

maneesht marked this pull request as ready for review March 19, 2025 21:56

maneesht requested review from aashishpatil-g and a team as code owners March 19, 2025 21:56

Create sharp-nails-glow.md

a41d2ef

maneesht requested review from a team as code owners March 19, 2025 21:57

stephenarosaj approved these changes Mar 19, 2025

View reviewed changes

hsubox76 approved these changes Mar 19, 2025

View reviewed changes

hsubox76 reviewed Mar 19, 2025

View reviewed changes

packages/data-connect/src/api/index.ts Outdated Show resolved Hide resolved

Addressed comments

23b7845

dconeybe requested changes Mar 20, 2025

View reviewed changes

packages/data-connect/src/api/index.ts Outdated Show resolved Hide resolved

packages/data-connect/src/api/index.ts Outdated Show resolved Hide resolved

maneesht added 3 commits March 20, 2025 09:32

Addressed comments

12ce1bd

Updated docgen

d650f5d

Bumped emulator version

e1f5533

dconeybe approved these changes Mar 21, 2025

View reviewed changes

maneesht added 2 commits March 20, 2025 18:13

Merge remote-tracking branch 'origin/main' into mtewani/partial-errors

61c13fb

Brought back log

c695523

maneesht merged commit edb4001 into main Mar 21, 2025
47 of 48 checks passed

maneesht deleted the mtewani/partial-errors branch March 21, 2025 22:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement Partial Errors for FDC #8821

Implement Partial Errors for FDC #8821

maneesht commented Feb 28, 2025

changeset-bot bot commented Feb 28, 2025 •

edited

Loading

google-oss-bot commented Feb 28, 2025 •

edited

Loading

`@firebase/data-connect`

`firebase`

google-oss-bot commented Feb 28, 2025 •

edited

Loading

`@firebase/data-connect`

`CallerSdkTypeEnum`

`DataConnect`

`DataConnectError`

`DataConnectOperationError`

`MUTATION_STR`

`MutationManager`

`QUERY_STR`

`SOURCE_CACHE`

`SOURCE_SERVER`

`areTransportOptionsEqual`

`connectDataConnectEmulator`

`executeMutation`

`executeQuery`

`getDataConnect`

`mutationRef`

`parseOptions`

`queryRef`

`setLogLevel`

`subscribe`

`terminate`

`toQueryRef`

`validateArgs`

`validateDCOptions`

stephenarosaj left a comment

dconeybe left a comment

Implement Partial Errors for FDC #8821

Implement Partial Errors for FDC #8821

Conversation

maneesht commented Feb 28, 2025

changeset-bot bot commented Feb 28, 2025 • edited Loading

🦋 Changeset detected

google-oss-bot commented Feb 28, 2025 • edited Loading

Size Report 1

Affected Products

@firebase/data-connect

firebase

Test Logs

google-oss-bot commented Feb 28, 2025 • edited Loading

Size Analysis Report 1

Affected Products

@firebase/data-connect

CallerSdkTypeEnum

DataConnect

DataConnectError

DataConnectOperationError

MUTATION_STR

MutationManager

QUERY_STR

SOURCE_CACHE

SOURCE_SERVER

areTransportOptionsEqual

connectDataConnectEmulator

executeMutation

executeQuery

getDataConnect

mutationRef

parseOptions

queryRef

setLogLevel

subscribe

terminate

toQueryRef

validateArgs

validateDCOptions

Test Logs

stephenarosaj left a comment

Choose a reason for hiding this comment

dconeybe left a comment

Choose a reason for hiding this comment

changeset-bot bot commented Feb 28, 2025 •

edited

Loading

google-oss-bot commented Feb 28, 2025 •

edited

Loading

Size Report ¹

`@firebase/data-connect`

`firebase`

google-oss-bot commented Feb 28, 2025 •

edited

Loading

Size Analysis Report ¹

`@firebase/data-connect`

`CallerSdkTypeEnum`

`DataConnect`

`DataConnectError`

`DataConnectOperationError`

`MUTATION_STR`

`MutationManager`

`QUERY_STR`

`SOURCE_CACHE`

`SOURCE_SERVER`

`areTransportOptionsEqual`

`connectDataConnectEmulator`

`executeMutation`

`executeQuery`

`getDataConnect`

`mutationRef`

`parseOptions`

`queryRef`

`setLogLevel`

`subscribe`

`terminate`

`toQueryRef`

`validateArgs`

`validateDCOptions`