Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate GroundingAttribution #8832

Merged
merged 5 commits into from
Mar 20, 2025
Merged

Conversation

dlarocque
Copy link
Contributor

GroundingAttribution is deprecated and will never be defined. We should label this as deprecated so users don't use it. In the next major release, we should remove this.

@dlarocque dlarocque requested review from a team as code owners March 6, 2025 19:20
Copy link

changeset-bot bot commented Mar 6, 2025

🦋 Changeset detected

Latest commit: 3a0299c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@firebase/vertexai Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dlarocque dlarocque requested review from a team as code owners March 6, 2025 19:21
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 6, 2025

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (51465ce)Merge (49f9f3c)Diff
    browser380 kB381 kB+828 B (+0.2%)
    main589 kB590 kB+1.07 kB (+0.2%)
    module380 kB381 kB+828 B (+0.2%)
    react-native381 kB381 kB+828 B (+0.2%)
  • @firebase/firestore-lite

    TypeBase (51465ce)Merge (49f9f3c)Diff
    browser112 kB113 kB+813 B (+0.7%)
    main154 kB155 kB+1.12 kB (+0.7%)
    module112 kB113 kB+813 B (+0.7%)
    react-native112 kB113 kB+813 B (+0.7%)
  • bundle

    15 size changes

    TypeBase (51465ce)Merge (49f9f3c)Diff
    firestore (CSI Auto Indexing Disable and Delete)271 kB272 kB+493 B (+0.2%)
    firestore (CSI Auto Indexing Enable)271 kB272 kB+493 B (+0.2%)
    firestore (Persistence)303 kB303 kB+456 B (+0.2%)
    firestore (Query Cursors)250 kB250 kB+456 B (+0.2%)
    firestore (Query)247 kB248 kB+456 B (+0.2%)
    firestore (Read data once)235 kB236 kB+456 B (+0.2%)
    firestore (Read Write w Persistence)327 kB328 kB+456 B (+0.1%)
    firestore (Realtime updates)237 kB238 kB+456 B (+0.2%)
    firestore (Transaction)214 kB215 kB+493 B (+0.2%)
    firestore (Write data)214 kB214 kB+493 B (+0.2%)
    firestore-lite (Query Cursors)103 kB104 kB+467 B (+0.5%)
    firestore-lite (Query)99.4 kB99.9 kB+467 B (+0.5%)
    firestore-lite (Read data once)74.9 kB75.4 kB+467 B (+0.6%)
    firestore-lite (Transaction)100 kB101 kB+467 B (+0.5%)
    firestore-lite (Write data)84.5 kB85.0 kB+467 B (+0.6%)

  • firebase

    TypeBase (51465ce)Merge (49f9f3c)Diff
    firebase-compat.js792 kB793 kB+420 B (+0.1%)
    firebase-firestore-compat.js339 kB339 kB+420 B (+0.1%)
    firebase-firestore-lite.js130 kB131 kB+813 B (+0.6%)
    firebase-firestore.js439 kB440 kB+828 B (+0.2%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/ubc4LbXZl6.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 6, 2025

Size Analysis Report 1

This report is too large (548,451 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/eHeQn61esb.html

@dlarocque dlarocque force-pushed the dl/deprecate-groundingattributions branch from 8f6e6a1 to e05f542 Compare March 6, 2025 20:16
Copy link
Contributor

github-actions bot commented Mar 6, 2025

Changeset File Check ✅

  • No modified packages are missing from the changeset file.
  • No changeset formatting errors detected.

@dlarocque dlarocque requested a review from hsubox76 March 17, 2025 17:25
@dlarocque dlarocque merged commit faaeb48 into main Mar 20, 2025
35 of 37 checks passed
@dlarocque dlarocque deleted the dl/deprecate-groundingattributions branch March 20, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants