Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give check-changeset job write permissions on pull requests #8833

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

dlarocque
Copy link
Contributor

This fixes an issue where a step fails with a 403 for no write permissions: https://github.com/firebase/firebase-js-sdk/actions/runs/13706506246/job/38332961549

@dlarocque dlarocque requested review from a team as code owners March 6, 2025 19:36
Copy link

changeset-bot bot commented Mar 6, 2025

⚠️ No Changeset found

Latest commit: dcb983f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dlarocque dlarocque force-pushed the dl/changeset-perms branch from 2814fbb to dcb983f Compare March 6, 2025 19:37
@dlarocque dlarocque requested review from DellaBitta and hsubox76 March 6, 2025 19:39
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 6, 2025

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 6, 2025

@dlarocque dlarocque merged commit 51465ce into main Mar 6, 2025
39 checks passed
@dlarocque dlarocque deleted the dl/changeset-perms branch March 6, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants