Surface all App Check errors in public getToken() method #8842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f5a1e4d The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Report 1Affected Products
Test Logs |
DellaBitta
approved these changes
Mar 13, 2025
| @@ -54,7 +55,8 @@ const ERRORS: ErrorMap<AppCheckError> = { | |||
| [AppCheckError.STORAGE_WRITE]: | |||
| 'Error thrown when writing to storage. Original error: {$originalErrorMessage}.', | |||
| [AppCheckError.RECAPTCHA_ERROR]: 'ReCAPTCHA error.', | |||
| [AppCheckError.THROTTLED]: `Requests throttled due to {$httpStatus} error. Attempts allowed again after {$time}` | |||
| [AppCheckError.INITIAL_THROTTLE]: `{$httpStatus} error. Attempts allowed again after {$time}`, | |||
| [AppCheckError.THROTTLED]: `Requests throttled due to previous {$httpStatus} error. Attempts allowed again after {$time}` | |||
There was a problem hiding this comment.
nit, these should be transposed to match the order in ErrorParams and AppCheckError.
There was a problem hiding this comment.
Flipped it around the other way on the other two since logically I guess the "initial throttle" should come first.
Size Analysis Report 1Affected Products
Test Logs |
Merged
|
@hsubox76 Thank you for addressing this promptly. May I ask when we can expect this fix to be released? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two main changes here are
getToken()method. Errors here should not block 2P calls to App Check (internal calls from Auth, Firestore, etc)I've also decided to stop logging getToken errors with
console.error- these should all be thrown by the publicgetToken()now, and the internal products calling getToken internally (Auth, Firestore, etc.) have access to the error message in a property of AppCheckTokenResult which they can log in the format they choose.Fixes #8822