-
Notifications
You must be signed in to change notification settings - Fork 916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set github actions to use commit hashes #8852
Conversation
|
Size Report 1Affected ProductsNo changes between base commit (e8865f2) and merge commit (22190ff).Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (e8865f2) and merge commit (22190ff).Test Logs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you amend the PR description to include the fact that two workflows have been deleted?
@@ -42,10 +42,12 @@ jobs: | |||
- uses: actions/setup-node@v4 | |||
with: | |||
node-version: 22.10.0 | |||
- uses: 'google-github-actions/auth@v0' | |||
# This commit represents v0.8.3 | |||
- uses: 'google-github-actions/auth@c4799db9111fba4461e9f9da8732e5057b394f72' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason why this one is in quotes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was originally in quotes, didn't want to change it. I think both syntaxes are okay but the quotes are needed if there are special characters or something, so the original author was probably being careful.
Added. |
In light of a recent vulnerability introduced in a community Github Action (none of the ones we are using), we are switching our Github Actions to use commit hashes instead of version numbers. I am leaving the official Github Actions alone (
actions/
) as they are officially provided by Github and if they are compromised, Github might as well be compromised.I left comments saying which version each corresponds to. In each case I picked a commit hash representing the same version as was previously referenced, except for
hashicorp/setup-terraform
which was a version behind and I thought would be safe to bump to the latest. So some may be well behind the latest version, such as google-github-actions/auth, which is 2 versions behind, as I didn't think this was the time to experiment with a version bump.I didn't add these to renovate.json ignoreDeps because maybe we should be reminded to manually update these (after giving some time to check for vulnerabilities).
Also deleted