Skip to content

Exponential Retries for ping #9037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 73 commits into
base: main
Choose a base branch
from
Open

Exponential Retries for ping #9037

wants to merge 73 commits into from

Conversation

maneesht
Copy link
Contributor

No description provided.

maneesht and others added 30 commits April 11, 2025 14:30
@maneesht
Added test project to fdc
02c52c6
@maneesht
Fixed formatting
37d0f18
@maneesht
Fix linting
a4d7813
@maneesht
Excluded example integration from tsconfig
170b15a
@maneesht
Fixed example-integration package.json
ec405ae
@maneesht
Added ssl check for firestore
248f654
@maneesht
Added ssl checks for RTDB
14ef1bc
@maneesht
Merge remote-tracking branch 'origin/main' into mtewani/add-ssl-check…
a8fe7de 
…s-use-emulat9or
@maneesht
Removed unnecessary files
df4a115
@maneesht
Removed unnecessary data connect changes
f867d3b
@maneesht
Create gentle-laws-kneel.md
4f23f33
@maneesht
Added code to pass on credentials if using a cloud workstation
55b1c0a
@maneesht
Create nine-pugs-crash.md
e0a59c5
@maneesht
Addressed comments
8d93780
@maneesht
Merge branch 'mtewani/fix-auth-redirects-studio' of https://github.co…
78142b9 
…m/firebase/firebase-js-sdk into mtewani/fix-auth-redirects-studio
@maneesht
Removed unused import
5e76a0a
@maneesht
include storage changes
b8b485d
@maneesht
Updated api review
21ecf95
@maneesht
Removed unnecessary import
24c1575
@maneesht
Fix formatting
7c7f3ae
@maneesht
Fixed data connect test
d62409a
@maneesht
Included extra url in externs
82faa08
@maneesht
Fixed fdc tests
32c461a
@maneesht
Passed in emulator information
da5b7bf
@maneesht
Fixed formattign
b424e58
@maneesht
WIP
7d2313f
@maneesht
Added emulator status
6e0761d
@maneesht
Removed firebaseapp import
e7b292d
@maneesht
Merge remote-tracking branch 'origin/main' into mtewani/add-emulator-…
beff97f 
…overlay
@maneesht
Removed app check change
6ca5c24
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 13, 2025

🦋 Changeset detected

Latest commit: 12759bc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@firebase/auth Patch
@firebase/firestore Patch
@firebase/util Patch
@firebase/database Patch
@firebase/storage Patch
@firebase/functions Patch
@firebase/auth-compat Patch
firebase Patch
@firebase/firestore-compat Patch
@firebase/analytics-compat Patch
@firebase/analytics Patch
@firebase/app-check-compat Patch
@firebase/app-check Patch
@firebase/app-compat Patch
@firebase/app Patch
@firebase/component Patch
@firebase/data-connect Patch
@firebase/database-compat Patch
@firebase/database-types Patch
@firebase/functions-compat Patch
@firebase/installations-compat Patch
@firebase/installations Patch
@firebase/messaging-compat Patch
@firebase/messaging Patch
@firebase/performance-compat Patch
@firebase/performance Patch
@firebase/remote-config-compat Patch
@firebase/remote-config Patch
@firebase/storage-compat Patch
@firebase/vertexai Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v13.0

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • @firebase/util

    TypeBase (799de59)Merge (8229a9f)Diff
    browser29.3 kB29.6 kB+335 B (+1.1%)
    main35.7 kB36.0 kB+335 B (+0.9%)
    module29.3 kB29.6 kB+335 B (+1.1%)

  • bundle

    34 size changes

    TypeBase (799de59)Merge (8229a9f)Diff
    auth (GoogleFBTwitterGitHubPopup)109 kB110 kB+246 B (+0.2%)
    database (Append to a list of data)154 kB155 kB+221 B (+0.1%)
    database (Filtering data)153 kB154 kB+221 B (+0.1%)
    database (Listen for child events)170 kB170 kB+221 B (+0.1%)
    database (Listen for value events + Detach listeners)170 kB170 kB+221 B (+0.1%)
    database (Listen for value events)170 kB170 kB+221 B (+0.1%)
    database (Read data once)169 kB169 kB+221 B (+0.1%)
    database (Save data as transactions)172 kB172 kB+221 B (+0.1%)
    database (Sort data)155 kB155 kB+221 B (+0.1%)
    database (Write data)154 kB154 kB+221 B (+0.1%)
    firestore (CSI Auto Indexing Disable and Delete)280 kB280 kB+221 B (+0.1%)
    firestore (CSI Auto Indexing Enable)280 kB280 kB+221 B (+0.1%)
    firestore (Persistence)311 kB311 kB+221 B (+0.1%)
    firestore (Query Cursors)256 kB256 kB+221 B (+0.1%)
    firestore (Query)254 kB254 kB+221 B (+0.1%)
    firestore (Read data once)242 kB242 kB+221 B (+0.1%)
    firestore (Read Write w Persistence)335 kB336 kB+222 B (+0.1%)
    firestore (Realtime updates)244 kB244 kB+221 B (+0.1%)
    firestore (Transaction)221 kB221 kB+221 B (+0.1%)
    firestore (Write data)220 kB221 kB+221 B (+0.1%)
    firestore-lite (Query Cursors)109 kB109 kB+223 B (+0.2%)
    firestore-lite (Query)105 kB106 kB+223 B (+0.2%)
    firestore-lite (Read data once)80.7 kB80.9 kB+223 B (+0.3%)
    firestore-lite (Transaction)106 kB106 kB+223 B (+0.2%)
    firestore-lite (Write data)90.3 kB90.5 kB+223 B (+0.2%)
    functions (call)39.4 kB39.6 kB+223 B (+0.6%)
    storage (getBytes)47.2 kB47.4 kB+223 B (+0.5%)
    storage (getDownloadURL)49.3 kB49.5 kB+223 B (+0.5%)
    storage (getMetadata)48.7 kB48.9 kB+223 B (+0.5%)
    storage (list + listAll)48.1 kB48.4 kB+223 B (+0.5%)
    storage (updateMetadata)49.0 kB49.2 kB+223 B (+0.5%)
    storage (uploadBytes)53.8 kB54.1 kB+223 B (+0.4%)
    storage (uploadBytesResumable)63.8 kB64.0 kB+223 B (+0.3%)
    storage (uploadString)54.0 kB54.3 kB+223 B (+0.4%)

  • firebase

    15 size changes

    TypeBase (799de59)Merge (8229a9f)Diff
    firebase-auth-compat.js145 kB146 kB+199 B (+0.1%)
    firebase-auth-cordova.js142 kB143 kB+172 B (+0.1%)
    firebase-auth-web-extension.js125 kB125 kB+172 B (+0.1%)
    firebase-auth.js163 kB163 kB+174 B (+0.1%)
    firebase-compat.js802 kB802 kB+178 B (+0.0%)
    firebase-data-connect.js18.2 kB18.4 kB+172 B (+0.9%)
    firebase-database-compat.js168 kB169 kB+198 B (+0.1%)
    firebase-database.js192 kB192 kB+177 B (+0.1%)
    firebase-firestore-compat.js347 kB347 kB+201 B (+0.1%)
    firebase-firestore-lite.js137 kB137 kB+177 B (+0.1%)
    firebase-firestore.js449 kB449 kB+181 B (+0.0%)
    firebase-functions-compat.js14.7 kB14.9 kB+174 B (+1.2%)
    firebase-functions.js19.5 kB19.7 kB+172 B (+0.9%)
    firebase-storage-compat.js44.2 kB44.4 kB+199 B (+0.5%)
    firebase-storage.js51.2 kB51.3 kB+172 B (+0.3%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/WZha3bzmai.html

@google-oss-bot
Copy link
Contributor

Size Analysis Report 1

Affected Products

  • @firebase/auth

    • connectAuthEmulator

      Size

      TypeBase (799de59)Merge (8229a9f)Diff
      size-with-ext-deps69.2 kB69.4 kB+221 B (+0.3%)

    • getAuth

      Size

      TypeBase (799de59)Merge (8229a9f)Diff
      size-with-ext-deps109 kB109 kB+246 B (+0.2%)

  • @firebase/data-connect

    • connectDataConnectEmulator

      Size

      TypeBase (799de59)Merge (8229a9f)Diff
      size-with-ext-deps31.2 kB31.4 kB+220 B (+0.7%)

  • @firebase/database

    • connectDatabaseEmulator

      Size

      TypeBase (799de59)Merge (8229a9f)Diff
      size-with-ext-deps145 kB145 kB+220 B (+0.2%)

    • getDatabase

      Size

      TypeBase (799de59)Merge (8229a9f)Diff
      size-with-ext-deps152 kB152 kB+221 B (+0.1%)

  • @firebase/firestore

    • connectFirestoreEmulator

      Size

      TypeBase (799de59)Merge (8229a9f)Diff
      size-with-ext-deps93.3 kB93.5 kB+221 B (+0.2%)

    • getFirestore

      Size

      TypeBase (799de59)Merge (8229a9f)Diff
      size-with-ext-deps101 kB101 kB+223 B (+0.2%)

    • initializeFirestore

      Size

      TypeBase (799de59)Merge (8229a9f)Diff
      size-with-ext-deps91.8 kB92.0 kB+220 B (+0.2%)

  • @firebase/functions

    • connectFunctionsEmulator

      Size

      TypeBase (799de59)Merge (8229a9f)Diff
      size-with-ext-deps25.3 kB25.6 kB+222 B (+0.9%)

    • getFunctions

      Size

      TypeBase (799de59)Merge (8229a9f)Diff
      size-with-ext-deps33.2 kB33.4 kB+223 B (+0.7%)

  • @firebase/storage

    • connectStorageEmulator

      Size

      TypeBase (799de59)Merge (8229a9f)Diff
      size-with-ext-deps34.8 kB35.0 kB+222 B (+0.6%)

    • getStorage

      Size

      TypeBase (799de59)Merge (8229a9f)Diff
      size-with-ext-deps42.7 kB43.0 kB+223 B (+0.5%)

  • @firebase/util

    • pingServer

      Size

      TypeBase (799de59)Merge (8229a9f)Diff
      size103 B319 B+216 B (+209.7%)
      size-with-ext-deps103 B319 B+216 B (+209.7%)

      Dependency

      TypeBase (799de59)Merge (8229a9f)Diff
      variables

      MAX_PING_RETRIES
pingQueue

      + MAX_PING_RETRIES
+ pingQueue

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/XoS7LUHmCX.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lisajian lisajian Awaiting requested review from lisajian lisajian is a code owner

@Xiaoshouzi-gh Xiaoshouzi-gh Awaiting requested review from Xiaoshouzi-gh Xiaoshouzi-gh is a code owner

@sam-gc sam-gc Awaiting requested review from sam-gc sam-gc is a code owner

@pashanka pashanka Awaiting requested review from pashanka pashanka is a code owner

@mansisampat mansisampat Awaiting requested review from mansisampat mansisampat is a code owner

@NhienLam NhienLam Awaiting requested review from NhienLam NhienLam is a code owner

@tonyjhuang tonyjhuang Awaiting requested review from tonyjhuang tonyjhuang is a code owner

@aashishpatil-g aashishpatil-g Awaiting requested review from aashishpatil-g aashishpatil-g is a code owner

At least 3 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maneesht @google-oss-bot