Collect Angular context when calling recordError directly

[tonybaroneee]

Discussion

Collect framework-specific attributes whenever recordError is called, explicitly or implicitly.

Testing

Unit tested, manually tested

API Changes

N/A

[changeset-bot]

⚠️ No Changeset found

Latest commit: 3d23d5e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[gemini-code-assist]

Summary of Changes

Hello @tonybaroneee, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a more robust and extensible way to collect framework-specific attributes, such as Angular route paths, when errors are reported to Crashlytics. By implementing a frameworkAttributesProvider on the CrashlyticsService, the system can now automatically enrich error logs with relevant context without requiring manual attribute passing. This change streamlines error reporting and improves the diagnostic information available for debugging.

Highlights

• Refactored Angular Context Collection: The mechanism for collecting Angular-specific context, such as the route path, has been refactored. Instead of passing these attributes directly to recordError, they are now provided via a new frameworkAttributesProvider.
• Centralized Attribute Retrieval in recordError: The recordError function now automatically checks for and retrieves framework-specific attributes from a configured frameworkAttributesProvider on the Crashlytics instance, centralizing the attribute collection logic.
• New frameworkAttributesProvider API: The CrashlyticsService now exposes a frameworkAttributesProvider property, allowing frameworks like Angular to inject a function that supplies relevant context attributes when an error is recorded.
• Improved Test Coverage: New unit tests have been added to ensure that framework attributes are correctly collected, merged, and reported by recordError.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a mechanism to collect framework-specific attributes, such as the Angular route path, when reporting errors. This is achieved by adding a frameworkAttributesProvider to the CrashlyticsService, which is then used by the recordError function. The Angular FirebaseErrorHandler is updated to implement this provider. The changes are logical, well-structured, and include thorough unit tests for the new functionality. The implementation correctly handles the merging of different attribute sources, ensuring that explicitly provided attributes take precedence. I have one suggestion to improve code clarity and maintainability in service.ts by using a type alias.