feat(ai) Google Maps Grounding Support #9458
Conversation
|
Summary of ChangesHello @DellaBitta, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates Google Maps grounding capabilities into the AI system, enabling models to leverage location-based information for more contextually relevant responses. It introduces new API structures for defining Google Maps tools and handling maps-specific grounding data, alongside mechanisms for providing geographical context in requests. This enhancement allows for richer, location-aware AI interactions. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for Google Maps Grounding, adding new tools, configurations, and response types. The changes include new API definitions and integration tests to validate the feature. My review focuses on a critical issue with unexported TypeScript interfaces that would break the SDK for consumers, a documentation error, and opportunities to improve the new test code by reducing duplication and removing dead code. Overall, the implementation is solid, and the tests cover the necessary scenarios.
| it('generateContent: google maps grounding prompt location', async () => { | ||
| const model = getGenerativeModel(testConfig.ai, { | ||
| model: testConfig.model, | ||
| generationConfig: commonGenerationConfig, | ||
| safetySettings: commonSafetySettings, | ||
| tools: [{ googleMaps: {} }] | ||
| }); | ||
|
|
||
| const result = await model.generateContent( | ||
| 'Where is a good place to grab a coffee near Arlington, MA?' | ||
| ); | ||
| const response = result.response; | ||
| const groundingMetadata = response.candidates?.[0].groundingMetadata; | ||
| expect(groundingMetadata).to.exist; | ||
| expect( | ||
| groundingMetadata!.groundingChunks | ||
| ).to.have.length.greaterThanOrEqual(1); | ||
| groundingMetadata!.groundingChunks!.forEach(groundingChunk => { | ||
| expect(groundingChunk.maps).to.exist; | ||
| expect(groundingChunk.maps!.uri).to.exist; | ||
| expect(groundingChunk.maps!.title).to.exist; | ||
| expect(groundingChunk.maps!.placeId).to.exist; | ||
| }); | ||
| expect( | ||
| groundingMetadata?.groundingSupports | ||
| ).to.have.length.greaterThanOrEqual(1); | ||
| groundingMetadata!.groundingSupports!.forEach(groundingSupport => { | ||
| expect( | ||
| groundingSupport.groundingChunkIndices | ||
| ).to.have.length.greaterThanOrEqual(1); | ||
| expect(groundingSupport.segment).to.exist; | ||
| expect(groundingSupport.segment?.endIndex).to.exist; | ||
| expect(groundingSupport.segment?.text).to.exist; | ||
| }); | ||
| expect(groundingMetadata!.googleMapsWidgetContextToken).to.not.exist; | ||
| }); |
There was a problem hiding this comment.
There's a lot of duplicated code across the new tests for Google Maps grounding. The assertions for groundingMetadata, groundingChunks, and groundingSupports are identical in multiple tests.
To improve maintainability and reduce redundancy, consider extracting this common assertion logic into a helper function. For example:
function assertGoogleMapsGrounding(groundingMetadata: any) {
expect(groundingMetadata).to.exist;
expect(
groundingMetadata.groundingChunks
).to.have.length.greaterThanOrEqual(1);
groundingMetadata.groundingChunks.forEach(groundingChunk => {
expect(groundingChunk.maps).to.exist;
expect(groundingChunk.maps.uri).to.exist;
expect(groundingChunk.maps.title).to.exist;
expect(groundingChunk.maps.placeId).to.exist;
});
expect(
groundingMetadata.groundingSupports
).to.have.length.greaterThanOrEqual(1);
groundingMetadata.groundingSupports.forEach(groundingSupport => {
expect(
groundingSupport.groundingChunkIndices
).to.have.length.greaterThanOrEqual(1);
expect(groundingSupport.segment).to.exist;
expect(groundingSupport.segment.endIndex).to.exist;
expect(groundingSupport.segment.text).to.exist;
});
}Then each test can simply call assertGoogleMapsGrounding(groundingMetadata);.
1 participant
Discussion
Implement new tools to use Grounding with Google Maps, similar to how Grounding with Google Search works.
Testing
Integration tests.
API Changes
See internal doc: go/fal-maps-grounding-api