Skip to content

Conversation

@dlarocque
Copy link
Contributor

@dlarocque dlarocque commented Jan 15, 2026

Adds support for regexFind and regexFindAll expressions to Firestore Pipelines.

These new features were tested with trivial integration tests.

@changeset-bot
Copy link

changeset-bot bot commented Jan 15, 2026

🦋 Changeset detected

Latest commit: 8dbc932

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
firebase Minor
@firebase/firestore Minor
@firebase/firestore-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @dlarocque, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances Firestore's data manipulation capabilities by introducing two new regular expression functions, regexFind and regexFindAll, to its pipeline expressions. These additions enable developers to precisely extract either the first occurrence or all occurrences of a pattern within string data, providing more powerful and flexible data processing directly within Firestore queries.

Highlights

  • New Regex Functions: Added support for regexFind and regexFindAll Pipeline expressions in Firestore, allowing users to extract matching substrings from string fields or expressions.
  • API and Documentation Updates: The new functions are exposed through the API, and comprehensive documentation has been added for both the Expression class methods and standalone functions, including usage examples.
  • Testing: Integration and lite-API specific tests have been included to ensure the correct functionality of regexFind and regexFindAll.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 15, 2026

Changeset File Check ✅

  • No modified packages are missing from the changeset file.
  • No changeset formatting errors detected.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for regexFind and regexFindAll pipeline expressions to Firestore. The changes include updating the API surface, implementing the new expression types, adding documentation, and providing tests. The implementation looks solid, and the tests cover the new functionality. I've found a few minor issues in the documentation and JSDoc comments, including some typos and misleading examples, which I've commented on. Overall, this is a great addition.

@firebase firebase deleted a comment from github-actions bot Jan 16, 2026
@dlarocque dlarocque marked this pull request as ready for review January 16, 2026 15:46
@dlarocque dlarocque requested review from a team as code owners January 16, 2026 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants