Conversation
This commit aligns the Firestore Web SDK Pipeline DML implementation with the finalized Java and Node.js SDKs to ensure strict API parity. Specifically: - Removed deferred insert and upsert Pipeline methods, along with their Stage classes and Option typings. - Aligned delete API to accept zero arguments (removed DeleteOptions wrapper). - Aligned update API to accept an array of Selectables (representing transformedFields) directly instead of an UpdateOptions wrapper. - Skipped/deleted related DML operation tests from the web sdk integration tests since DMLs cannot be tested from the web sdk currently.
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces delete() and update() stages to the Firestore Pipeline API, makes the collection field optional in CollectionStageOptions, and refines error handling and logging. Feedback focuses on preventing a potential runtime error from an unsafe non-null assertion in pipeline-source.ts, removing an unused import in pipeline.ts, and adding validation to the update() method to ensure field transformations are provided.
| } from './stage_options'; | ||
| import { UserDataReader, UserDataSource } from './user_data_reader'; | ||
| import { AbstractUserDataWriter } from './user_data_writer'; | ||
| import { CollectionReference } from './reference'; |
There was a problem hiding this comment.
The import of CollectionReference is unused in this file and should be removed to keep the code clean.
2 participants
No description provided.