Conversation
🦋 Changeset detectedLatest commit: 03f94d3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces image generation configuration options, including aspect ratio and image size, and expands the FinishReason enumeration with new image-related and technical statuses. The badFinishReasons array was updated to include these new reasons; however, feedback indicates that several existing reasons like BLOCKLIST and PROHIBITED_CONTENT are still missing and should be included to ensure consistent error handling across the SDK.
Changeset File Check ✅
|
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces support for ImageConfig (including aspect ratio and size) and expands the FinishReason enum to achieve parity with the iOS SDK. The changes span the API definition, internal type declarations, response helper logic, and include a new test case for verifying configuration propagation. Feedback focuses on maintaining naming consistency for the ImageConfigAspectRatio constant keys, which should use a lowercase 'x' to match existing patterns in the SDK and the provided API report.
paulb777
force-pushed
the
pb-nanobanana-image-config
branch
from
ec5f010 to
45efb70
Compare
…o match ImagenAspectRatio
paulb777
force-pushed
the
pb-nanobanana-image-config
branch
from
45efb70 to
8911375
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces support for ImageConfig (aspect ratio and size) and expands the FinishReason enum to include new values, ensuring parity with the iOS SDK. The changes include updates to the API definitions, documentation, and test cases. A review comment suggested removing quotes from the keys in the ImageConfigAspectRatio constant object to maintain consistency with other constant definitions in the codebase.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces ImageConfig to the Firebase AI SDK, enabling configuration of aspect ratios and image sizes for Gemini models. It also expands the FinishReason enumeration with several new values related to image generation and safety to ensure parity with the iOS SDK. The changes include updates to public API definitions, documentation, and the addition of unit tests. Review feedback identifies a redundant sinon.restore() call in the test suite and suggests providing more descriptive documentation for the image size constants.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces support for ImageConfig (aspect ratio and size) for Gemini models and expands the FinishReason enum with new image-related and tool-related values to achieve parity with the iOS SDK. The changes include updates to API definitions, documentation, and a new test case to ensure imageConfig is correctly passed to ChatSession. Feedback from the review suggests removing an unnecessary async keyword in a test and addressing unnecessary ESLint disable/enable comments for the ImageConfigAspectRatio enum to maintain consistency.
1 participant
Replicating ImageConfig and expanded FinishReason support from iOS to JS SDK.